Add semantic label plumbing [chromium/src : main]
0 views
Skip to first unread message
Alexander Cooper (Gerrit)
Dec 11, 2025, 3:45:19 PM (5 days ago) Dec 11
to Brandon Jones, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Brandon Jones and Chromium IPC Reviews
Alexander Cooper added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alexander Cooper . resolved
Brandon and IPC Reviewer PTAL; note that this feature is currently still disabled by default.
Related details
Attention is currently required from:
- Brandon Jones
- Chromium IPC Reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Dec 11, 2025, 3:49:43 PM (5 days ago) Dec 11
to Alexander Cooper, Chromium IPC Reviews, Elly FJ, Brandon Jones, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Brandon Jones and Elly FJ
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: elly...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): elly...@chromium.org
Reviewer source(s):
elly...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Brandon Jones
- Elly FJ
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elly FJ (Gerrit)
Dec 11, 2025, 6:48:50 PM (5 days ago) Dec 11
to Alexander Cooper, Elly FJ, Chromium IPC Reviews, Brandon Jones, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Alexander Cooper and Brandon Jones
Elly FJ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Elly FJ
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alexander Cooper
- Brandon Jones
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Dec 12, 2025, 3:47:54 PM (4 days ago) Dec 12
to Alexander Cooper, Elly FJ, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Alexander Cooper
Brandon Jones voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alexander Cooper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Dec 12, 2025, 4:52:07 PM (4 days ago) Dec 12
to Brandon Jones, Elly FJ, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Alexander Cooper voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Cooper
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 12, 2025, 5:47:07 PM (4 days ago) Dec 12
to Alexander Cooper, Brandon Jones, Elly FJ, Chromium IPC Reviews, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Add semantic label plumbing
When the runtime knows what semantic labels should be present, send the
data over mojom so that the page can surface this data. There is a
very limited set of semantic labels available, and thus we intentionally
plumb this across via an enum so that we can be intentional about the
labels that we allow to be shared by the runtime.
Bug: 394636076
Change-Id: I5d07d87ece0dbe8e4346d9d10e751a0bb4f03516
Reviewed-by: Elly FJ <elly...@chromium.org>
Commit-Queue: Alexander Cooper <alco...@chromium.org>
Reviewed-by: Brandon Jones <baj...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558301}
Files:
- M chrome/browser/android/vr/arcore_device/fake_arcore.cc
- M device/vr/android/arcore/arcore_plane_manager.cc
- M device/vr/openxr/openxr_spatial_plane_manager.cc
- M device/vr/openxr/openxr_spatial_plane_manager.h
- M device/vr/public/mojom/vr_service.mojom
- M third_party/blink/renderer/modules/xr/xr_plane.cc
- M third_party/blink/renderer/modules/xr/xr_plane.h
Change size: M
Delta: 7 files changed, 97 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brandon Jones, +1 by Elly FJ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages