[xr] Validate that camera SyncTokens are empty for Cardboard/OpenXR [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
May 28, 2026, 3:57:29 PM (5 days ago) May 28
to Mingjing Zhang, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Mingjing Zhang
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mingjing Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
May 28, 2026, 4:14:10 PM (5 days ago) May 28
to Alexander Cooper, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper
Mingjing Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mingjing Zhang . resolved
Hi Alex, as per our [previous discussion](https://chromium-review.googlesource.com/c/chromium/src/+/7853071/comment/c8f5dfb8_339c1df1/), there's no camera image (and therefore no camera sync tokens) for cardboard. But we wonder if the same is true for OpenXR? We thought that there might be a camera image for OpenXR but didn't find one in the code. So we tentatively added the no- SyncToken validation for OpenXR too. Please let us know if this is desirable. Thanks.
Related details
Attention is currently required from:
- Alexander Cooper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
May 28, 2026, 4:17:12 PM (5 days ago) May 28
to Mingjing Zhang, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Mingjing Zhang
Alexander Cooper voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mingjing Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
May 28, 2026, 4:30:12 PM (5 days ago) May 28
to Alexander Cooper, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Mingjing Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 28, 2026, 5:45:47 PM (5 days ago) May 28
to Mingjing Zhang, Alexander Cooper, Vasiliy Telezhnikov, chromium...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[xr] Validate that camera SyncTokens are empty for Cardboard/OpenXR
In Cardboard and OpenXR, there are no camera shared images, and
therefore no camera SyncTokens should be sent from Blink to the device
process. This CL enforces this expectation by calling ReportBadMessage
if the received camera_sync_tokens parameter is not empty.
Bug: 40286368
Change-Id: Ib577f16f6ef5753fb90cba1f1dc305ca5cdac273
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Mingjing Zhang <mjz...@chromium.org>
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637970}
Files:
- M device/vr/android/cardboard/cardboard_render_loop.cc
- M device/vr/openxr/openxr_render_loop.cc
Change size: S
Delta: 2 files changed, 14 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov, +1 by Alexander Cooper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages