WebXR: Fix ineffective width check in XRGPUTextureArraySwapChain [chromium/src : main]

0 views
Skip to first unread message

Alexander Cooper (Gerrit)

unread,
Feb 6, 2026, 12:08:01 PM (9 days ago) Feb 6
to Zhixin Tu, AyeAye, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Zhixin Tu

Alexander Cooper added 1 comment

Commit Message
Line 10, Patchset 1 (Latest):descriptor is copied, and add a death test to cover non-divisible widths.
Alexander Cooper . unresolved

Missing? (Okay if you opted not to create it anymore, just update the commit description)

Open in Gerrit

Related details

Attention is currently required from:
  • Zhixin Tu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I326e4a10ba48f11748f183af65098c138020d8e9
Gerrit-Change-Number: 7548903
Gerrit-PatchSet: 1
Gerrit-Owner: Zhixin Tu <tuzhi...@gmail.com>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Attention: Zhixin Tu <tuzhi...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Feb 2026 17:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Zhixin Tu (Gerrit)

unread,
Feb 6, 2026, 12:27:40 PM (9 days ago) Feb 6
to Alexander Cooper, AyeAye, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper

Zhixin Tu added 1 comment

Commit Message
Line 10, Patchset 1:descriptor is copied, and add a death test to cover non-divisible widths.
Alexander Cooper . resolved

Missing? (Okay if you opted not to create it anymore, just update the commit description)

Zhixin Tu

Thanks for pointing this out. I've updated the description.

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I326e4a10ba48f11748f183af65098c138020d8e9
    Gerrit-Change-Number: 7548903
    Gerrit-PatchSet: 2
    Gerrit-Owner: Zhixin Tu <tuzhi...@gmail.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 17:27:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Alexander Cooper <alco...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alexander Cooper (Gerrit)

    unread,
    Feb 6, 2026, 12:29:42 PM (9 days ago) Feb 6
    to Zhixin Tu, Brandon Jones, AyeAye, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
    Attention needed from Brandon Jones and Zhixin Tu

    Alexander Cooper voted

    Code-Review+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brandon Jones
    • Zhixin Tu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I326e4a10ba48f11748f183af65098c138020d8e9
    Gerrit-Change-Number: 7548903
    Gerrit-PatchSet: 2
    Gerrit-Owner: Zhixin Tu <tuzhi...@gmail.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Attention: Zhixin Tu <tuzhi...@gmail.com>
    Gerrit-Attention: Brandon Jones <baj...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 17:29:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Brandon Jones (Gerrit)

    unread,
    Feb 6, 2026, 7:03:55 PM (8 days ago) Feb 6
    to Zhixin Tu, Chromium LUCI CQ, Alexander Cooper, AyeAye, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
    Attention needed from Alexander Cooper and Zhixin Tu

    Brandon Jones voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexander Cooper
    • Zhixin Tu
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I326e4a10ba48f11748f183af65098c138020d8e9
      Gerrit-Change-Number: 7548903
      Gerrit-PatchSet: 2
      Gerrit-Owner: Zhixin Tu <tuzhi...@gmail.com>
      Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
      Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
      Gerrit-Attention: Zhixin Tu <tuzhi...@gmail.com>
      Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
      Gerrit-Comment-Date: Sat, 07 Feb 2026 00:03:45 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Zhixin Tu (Gerrit)

      unread,
      Feb 9, 2026, 9:46:24 AM (6 days ago) Feb 9
      to Brandon Jones, Chromium LUCI CQ, Alexander Cooper, AyeAye, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
      Attention needed from Alexander Cooper

      Zhixin Tu voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alexander Cooper
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I326e4a10ba48f11748f183af65098c138020d8e9
      Gerrit-Change-Number: 7548903
      Gerrit-PatchSet: 2
      Gerrit-Owner: Zhixin Tu <tuzhi...@gmail.com>
      Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
      Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
      Gerrit-Reviewer: Zhixin Tu <tuzhi...@gmail.com>
      Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
      Gerrit-Comment-Date: Mon, 09 Feb 2026 14:45:50 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 9, 2026, 9:57:17 AM (6 days ago) Feb 9
      to Zhixin Tu, Brandon Jones, Alexander Cooper, AyeAye, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      WebXR: Fix ineffective width check in XRGPUTextureArraySwapChain

      Move the width divisibility CHECK to run after the wrapped swap chain’s
      descriptor is copied.
      Bug: 481934001
      Change-Id: I326e4a10ba48f11748f183af65098c138020d8e9
      Reviewed-by: Brandon Jones <baj...@chromium.org>
      Reviewed-by: Alexander Cooper <alco...@chromium.org>
      Commit-Queue: Zhixin Tu <tuzhi...@gmail.com>
      Cr-Commit-Position: refs/heads/main@{#1581730}
      Files:
      • M third_party/blink/renderer/modules/xr/xr_gpu_texture_array_swap_chain.cc
      Change size: XS
      Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Alexander Cooper, +1 by Brandon Jones
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I326e4a10ba48f11748f183af65098c138020d8e9
      Gerrit-Change-Number: 7548903
      Gerrit-PatchSet: 3
      Gerrit-Owner: Zhixin Tu <tuzhi...@gmail.com>
      Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
      Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Zhixin Tu <tuzhi...@gmail.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages