Revert "[XR] Refactor XR/JXR related code into a DFM" [chromium/src : main]

0 views
Skip to first unread message

Eriko Kurimoto (Gerrit)

unread,
Jan 13, 2026, 11:18:43 PMJan 13
to Gurmeet Kalra, Andrew Grieve, Chromium LUCI CQ, Nick Mondello, AyeAye, Yizhi Zhao, Chromium Metrics Reviews, srahim...@chromium.org, security-...@chromium.org, feature-v...@chromium.org
Attention needed from Andrew Grieve, Gurmeet Kalra and Nick Mondello

Eriko Kurimoto voted

Auto-Submit+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Gurmeet Kalra
  • Nick Mondello
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f5a15448eae7e58a2c93abe2c4aa708bafce297
Gerrit-Change-Number: 7453433
Gerrit-PatchSet: 1
Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
Gerrit-Reviewer: Nick Mondello <mond...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Yizhi Zhao <yi...@google.com>
Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Nick Mondello <mond...@google.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 04:18:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Jan 13, 2026, 11:19:18 PMJan 13
to Eriko Kurimoto, Gurmeet Kalra, Andrew Grieve, Chromium LUCI CQ, Nick Mondello, AyeAye, Yizhi Zhao, Chromium Metrics Reviews, srahim...@chromium.org, security-...@chromium.org, feature-v...@chromium.org
Attention needed from Andrew Grieve, Gurmeet Kalra and Nick Mondello

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Gurmeet Kalra
  • Nick Mondello
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f5a15448eae7e58a2c93abe2c4aa708bafce297
    Gerrit-Change-Number: 7453433
    Gerrit-PatchSet: 1
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Yizhi Zhao <yi...@google.com>
    Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Attention: Nick Mondello <mond...@google.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 04:19:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 11:19:43 PMJan 13
    to Eriko Kurimoto, Rubber Stamper, Gurmeet Kalra, Andrew Grieve, Nick Mondello, AyeAye, Yizhi Zhao, Chromium Metrics Reviews, srahim...@chromium.org, security-...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[XR] Refactor XR/JXR related code into a DFM"

    This reverts commit 581383a2f09ca6f830b535a087266729a16625fd.

    Reason for revert: Culprit causing tree closure
    error log: https://ci.chromium.org/ui/p/chromium/builders/ci/android-desktop-x64-official/1282/overview

    Original change's description:
    > [XR] Refactor XR/JXR related code into a DFM
    >
    > This CL introduces the XR DFM. Now significantly sized dependencies like
    > scenecore will live in the XR DFM. Additionally, XR class
    > implementations will live in the split. These are accessed using a
    > provider and module interfaces.
    >
    > Confirmed that this conditionally installs on Moohan and Aura. Also
    > verified when running install on tangor, the XR split is not installed.
    > This CL provides size saving benefits for Chrome, and will also allow
    > the XR team to develop larger features without increasing binary size.
    >
    > Following this CL, Canary will be monitored to ensure that the module is
    > functioning properly, in the event it is not, it will be rolled back.
    >
    > Verified on moohan:
    > https://drive.google.com/file/d/11UpIEyPMdih1XqAZxZbTBBQjypez80JQ/view?usp=sharing&resourcekey=0-ANNhj65K1PJf8H2HL11NKg
    >
    > Bug: 473861143
    > Fixed: 473861143
    >
    > Change-Id: I91aa80ed588dffb0e50cad60d4f3f10f6027f343
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7404203
    > Commit-Queue: Nick Mondello <mond...@google.com>
    > Reviewed-by: Andrew Grieve <agr...@chromium.org>
    > Reviewed-by: Gurmeet Kalra <gurm...@google.com>
    > Cr-Commit-Position: refs/heads/main@{#1568848}
    Bug: 473861143
    Bug: 473861143
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I2f5a15448eae7e58a2c93abe2c4aa708bafce297
    Auto-Submit: Eriko Kurimoto <elk...@chromium.org>
    Owners-Override: Eriko Kurimoto <elk...@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1568889}
    Files:
    • M chrome/android/BUILD.gn
    • M chrome/android/chrome_java_sources.gni
    • M chrome/android/expectations/trichrome_chrome_64_32_bundle.proguard_flags.expected
    • M chrome/android/expectations/trichrome_chrome_64_32_bundle__chrome.AndroidManifest.expected
    • D chrome/android/expectations/trichrome_chrome_64_32_bundle__xr.AndroidManifest.expected
    • M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • D chrome/android/java/src/org/chromium/chrome/browser/xr/scenecore/XrModuleProvider.java
    • R chrome/android/java/src/org/chromium/chrome/browser/xr/scenecore/XrSceneCoreSessionInitializerImpl.java
    • R chrome/android/java/src/org/chromium/chrome/browser/xr/scenecore/XrSceneCoreSessionManagerImpl.java
    • M chrome/android/modules/chrome_feature_modules.gni
    • D chrome/android/modules/xr/BUILD.gn
    • D chrome/android/modules/xr/internal/java/AndroidManifest.xml
    • D chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrModuleProviderImpl.java
    • D chrome/android/modules/xr/xr_module.gni
    • M chrome/android/proguard/main.flags
    • M chrome/browser/ui/android/strings/android_chrome_strings.grd
    • D chrome/browser/ui/android/strings/android_chrome_strings_grd/IDS_XR_MODULE_TITLE.png.sha1
    Change size: M
    Delta: 17 files changed, 12 insertions(+), 194 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f5a15448eae7e58a2c93abe2c4aa708bafce297
    Gerrit-Change-Number: 7453433
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Pandora1MG (Gerrit)

    unread,
    Jan 14, 2026, 1:38:29 AMJan 14
    to Chromium LUCI CQ, Eriko Kurimoto, Rubber Stamper, Gurmeet Kalra, Andrew Grieve, Nick Mondello, AyeAye, Yizhi Zhao, Chromium Metrics Reviews, srahim...@chromium.org, security-...@chromium.org, feature-v...@chromium.org
    Attention needed from Andrew Grieve, Eriko Kurimoto, Gurmeet Kalra, Nick Mondello and Yizhi Zhao

    Pandora1MG added 1 comment

    Patchset-level comments
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Grieve
    • Eriko Kurimoto
    • Gurmeet Kalra
    • Nick Mondello
    • Yizhi Zhao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f5a15448eae7e58a2c93abe2c4aa708bafce297
    Gerrit-Change-Number: 7453433
    Gerrit-PatchSet: 2
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Pandora1MG <pando...@gmail.com>
    Gerrit-CC: Yizhi Zhao <yi...@google.com>
    Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Attention: Nick Mondello <mond...@google.com>
    Gerrit-Attention: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Attention: Yizhi Zhao <yi...@google.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 06:37:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Nick Mondello (Gerrit)

    unread,
    Jan 14, 2026, 1:55:37 PMJan 14
    to Chromium LUCI CQ, Eriko Kurimoto, Pandora1MG, Rubber Stamper, Gurmeet Kalra, Andrew Grieve, AyeAye, Yizhi Zhao, Chromium Metrics Reviews, srahim...@chromium.org, security-...@chromium.org, feature-v...@chromium.org
    Attention needed from Andrew Grieve, Gurmeet Kalra and Yizhi Zhao

    Nick Mondello added 1 comment

    Patchset-level comments
    Nick Mondello . resolved

    The failing build was 1282, and the revert landed in 1284, but 1283 passed, so going to reland

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Grieve
    • Gurmeet Kalra
    • Yizhi Zhao
    Gerrit-Attention: Yizhi Zhao <yi...@google.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 18:55:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Gurmeet Kalra (Gerrit)

    unread,
    May 28, 2026, 2:03:09 PM (5 days ago) May 28
    to Chromium LUCI CQ, Eriko Kurimoto, Pandora1MG, rubber-...@appspot.gserviceaccount.com, Andrew Grieve, Nick Mondello, android-bu...@system.gserviceaccount.com, Yizhi Zhao, Chromium Metrics Reviews, srahim...@chromium.org, security-...@chromium.org, feature-v...@chromium.org
    Attention needed from Andrew Grieve and Yizhi Zhao

    Gurmeet Kalra added 1 comment

    Patchset-level comments
    Gurmeet Kalra . resolved

    Moved to cc to prevent this cl to show up in my dashboard `Your turn` section as it is was already auto merged.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Grieve
    • Yizhi Zhao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f5a15448eae7e58a2c93abe2c4aa708bafce297
    Gerrit-Change-Number: 7453433
    Gerrit-PatchSet: 2
    Gerrit-Owner: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eriko Kurimoto <elk...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Gurmeet Kalra <gurm...@google.com>
    Gerrit-CC: Pandora1MG <pando...@gmail.com>
    Gerrit-CC: Yizhi Zhao <yi...@google.com>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Attention: Yizhi Zhao <yi...@google.com>
    Gerrit-Comment-Date: Thu, 28 May 2026 18:02:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages