Andrew Grieve (Gerrit)

unread,

Feb 9, 2026, 11:46:28 AM (6 days ago) Feb 9

to Andrew Grieve, Fiaz Muhammad, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, davidj...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, torne...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Fiaz Muhammad

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Fiaz Muhammad

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fiaz Muhammad (Gerrit)

unread,

Feb 9, 2026, 1:37:07 PM (5 days ago) Feb 9

to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, davidj...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, torne...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Andrew Grieve

Fiaz Muhammad added 6 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Fiaz Muhammad . resolved

These are just nits since this this CL is just an inlining. Feel free to disregard these!

I'm wondering if it's just worth inlining all other cases where booleanNonNullObservableSupplier (and other temps) are used, since I think it subtracts from readability.

File chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneMediator.java

Line 216, Patchset 2 (Latest): booleanNonNullObservableSupplier1.addSyncObserverAndPostIfNonNull(

Fiaz Muhammad . unresolved

Looks a bit cluttered without the inlined observer ref and the verbose temp var names. Maybe inline the temp vars? Ignore if this involves some kind of problem with generics that I'm aware of.

File chrome/android/java/src/org/chromium/chrome/browser/ui/ExclusiveAccessManager.java

Line 100, Patchset 2 (Latest):

                        // Exclusive Access Manager always follows the fullscreen state. We
                        // subscribe to the FS state supplier in case when the fullscreen is
                        // delayed. Thanks to that EAM stat supplier will update on all FS
                        // enter and exit events.
                        // Exiting fullscreen should unlock all other locks.

Fiaz Muhammad . unresolved

Duplicated comment.

File chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java

Line 2417, Patchset 2 (Latest): // On show snackbar, hide page zoom dialog

Fiaz Muhammad . unresolved

Duplicated comment.

File chrome/android/javatests/src/org/chromium/chrome/browser/appearance/settings/AppearanceSettingsFragmentTest.java

Line 115, Patchset 2 (Latest):

                    // Safely call onPreferenceChange only on non-null observers (since tablets
                    // don't call #initBookmarkBarPrefForUserPrefs).

Fiaz Muhammad . unresolved

Duplicated comment.

File components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/scrim/ScrimManager.java

Line 193, Patchset 2 (Latest): integerNonNullObservableSupplier1.addSyncObserverAndPostIfNonNull(mOnStatusBarColorChanged);

Fiaz Muhammad . unresolved

Same as previous comment related to clutter!

Open in Gerrit

Related details

Attention is currently required from:

Andrew Grieve

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fiaz Muhammad (Gerrit)

unread,

Feb 9, 2026, 1:37:11 PM (5 days ago) Feb 9

to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, davidj...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, torne...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Andrew Grieve

Fiaz Muhammad voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Andrew Grieve

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fiaz Muhammad (Gerrit)

unread,

Feb 9, 2026, 1:37:23 PM (5 days ago) Feb 9

to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, davidj...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, torne...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Andrew Grieve

Fiaz Muhammad added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Fiaz Muhammad . unresolved

These are just nits since this this CL is just an inlining. Feel free to disregard these!
I'm wondering if it's just worth inlining all other cases where booleanNonNullObservableSupplier (and other temps) are used, since I think it subtracts from readability.

Fiaz Muhammad

Unresolve.

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrew Grieve (Gerrit)

unread,

Feb 9, 2026, 2:09:44 PM (5 days ago) Feb 9

to Andrew Grieve, Fiaz Muhammad, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, davidj...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, torne...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Andrew Grieve voted and added 6 comments

Votes added by Andrew Grieve

Commit-Queue	+2
Owners-Override	+1

6 comments

Patchset-level comments

File-level comment, Patchset 2:

Fiaz Muhammad . resolved

These are just nits since this this CL is just an inlining. Feel free to disregard these!
I'm wondering if it's just worth inlining all other cases where booleanNonNullObservableSupplier (and other temps) are used, since I think it subtracts from readability.

Fiaz Muhammad

Unresolve.

Andrew Grieve

Done

File chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneMediator.java

Line 216, Patchset 2: booleanNonNullObservableSupplier1.addSyncObserverAndPostIfNonNull(

Fiaz Muhammad . resolved

Looks a bit cluttered without the inlined observer ref and the verbose temp var names. Maybe inline the temp vars? Ignore if this involves some kind of problem with generics that I'm aware of.

Andrew Grieve

Thanks for catching! I only did spot checks and didn't notice this. Pretty sure this is intelli-j just being silly.

File chrome/android/java/src/org/chromium/chrome/browser/ui/ExclusiveAccessManager.java

Line 100, Patchset 2: // Exclusive Access Manager always follows the fullscreen state. We


                        // subscribe to the FS state supplier in case when the fullscreen is
                        // delayed. Thanks to that EAM stat supplier will update on all FS
                        // enter and exit events.
                        // Exiting fullscreen should unlock all other locks.

Fiaz Muhammad . resolved

Duplicated comment.

Andrew Grieve

Done

File chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java

Line 2417, Patchset 2: // On show snackbar, hide page zoom dialog

Fiaz Muhammad . resolved

Duplicated comment.

Andrew Grieve

Done

File chrome/android/javatests/src/org/chromium/chrome/browser/appearance/settings/AppearanceSettingsFragmentTest.java

Line 115, Patchset 2: // Safely call onPreferenceChange only on non-null observers (since tablets


                    // don't call #initBookmarkBarPrefForUserPrefs).

Fiaz Muhammad . resolved

Duplicated comment.

Andrew Grieve

Done

File components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/scrim/ScrimManager.java

Line 193, Patchset 2: integerNonNullObservableSupplier1.addSyncObserverAndPostIfNonNull(mOnStatusBarColorChanged);

Fiaz Muhammad . resolved

Same as previous comment related to clutter!

Andrew Grieve

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Fiaz Muhammad (Gerrit)

unread,

Feb 9, 2026, 2:28:00 PM (5 days ago) Feb 9

to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, davidj...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, torne...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Andrew Grieve

Fiaz Muhammad voted and added 1 comment

Votes added by Fiaz Muhammad

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Fiaz Muhammad . resolved

LGTM!

Open in Gerrit

Related details

Attention is currently required from:

Andrew Grieve

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Andrew Grieve (Gerrit)

unread,

Feb 9, 2026, 3:21:33 PM (5 days ago) Feb 9

to Andrew Grieve, Fiaz Muhammad, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, davidj...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, torne...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Andrew Grieve voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 9, 2026, 3:42:05 PM (5 days ago) Feb 9

to Andrew Grieve, Fiaz Muhammad, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, davidj...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, iwells...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, torne...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Inline ObservableSupplier.addObserver() (part 1)

The call is an alias for "addSyncObserverAndPostIfNonNull()".

Used Android Studio to inline the method from
NonNullObserverableSupplier (entirely mechanical).

Bug: 483038528

Change-Id: Iebddaa40109b9a77f802a533e4f769bd87bc35ad

Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7559650

Reviewed-by: Fiaz Muhammad <mf...@google.com>

Commit-Queue: Andrew Grieve <agr...@chromium.org>

Owners-Override: Andrew Grieve <agr...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1581989}

Files:

M chrome/android/features/keyboard_accessory/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/ManualFillingMediator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/ArchivedTabsDialogCoordinator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/ArchivedTabsMessageService.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/IncognitoTabSwitcherPane.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/SharedGroupObserverUnitTest.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogCoordinator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherBackPressHandlerManager.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPane.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneBase.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneCoordinator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneDrawableMediator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneMediator.java
M chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceCoordinator.java
M chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceMediator.java
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
M chrome/android/java/src/org/chromium/chrome/browser/app/download/home/DownloadPage.java
M chrome/android/java/src/org/chromium/chrome/browser/autofill/WebContentsViewRectProvider.java
M chrome/android/java/src/org/chromium/chrome/browser/chrome_item_picker/TabItemPickerCoordinator.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerImpl.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/AnimationInterruptor.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/NewTabAnimationLayout.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/content/EngagementSignalsHandler.java
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/features/toolbar/CustomTabBrowserControlsVisibilityDelegate.java
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/BrowserControlsManager.java
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandlerBase.java
M chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
M chrome/android/java/src/org/chromium/chrome/browser/hub/HubTabSwitcherMetricsRecorder.java
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerV2.java
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsConstraintsHelper.java
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabImpl.java
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabViewAndroidDelegate.java
M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
M chrome/android/java/src/org/chromium/chrome/browser/ui/BottomContainer.java
M chrome/android/java/src/org/chromium/chrome/browser/ui/ExclusiveAccessManager.java
M chrome/android/java/src/org/chromium/chrome/browser/ui/RootUiCoordinator.java
M chrome/android/java/src/org/chromium/chrome/browser/ui/system/StatusBarColorController.java
M chrome/android/javatests/src/org/chromium/chrome/browser/appearance/settings/AppearanceSettingsFragmentTest.java
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/compositor/CompositorViewHolderUnitTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/ArchivedTabModelSelectorImplTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImplTest.java
M chrome/browser/back_press/android/java/src/org/chromium/chrome/browser/back_press/BackPressHelper.java
M chrome/browser/back_press/android/java/src/org/chromium/chrome/browser/back_press/BackPressManager.java
M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManagerMediator.java
M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarMediator.java
M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarVisibilityProvider.java
M chrome/browser/bookmarks/android/junit/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarItemsLayoutManagerTest.java
M chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/BrowserStateBrowserControlsVisibilityDelegate.java
M chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/BrowserStateBrowserControlsVisibilityDelegateTest.java
M chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/TopControlsStacker.java
M chrome/browser/browser_controls/android/java/src/org/chromium/chrome/browser/browser_controls/TopControlsStackerUnitTest.java
M chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/FeedStream.java
M chrome/browser/hub/android/java/src/org/chromium/chrome/browser/hub/HubLayoutScrimController.java
M chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubBottomToolbarMediator.java
M chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubColorMixerImpl.java
M chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubCoordinator.java
M chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubToolbarCoordinator.java
M chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubToolbarMediator.java
M chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/PaneManagerImpl.java
M chrome/browser/keyboard_accessory/android/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/bar_component/KeyboardAccessoryCoordinator.java
M chrome/browser/keyboard_accessory/android/java/src/org/chromium/chrome/browser/keyboard_accessory/data/KeyboardAccessoryData.java
M chrome/browser/readaloud/android/java/src/org/chromium/chrome/browser/readaloud/ReadAloudControllerUnitTest.java
M chrome/browser/readaloud/android/java/src/org/chromium/chrome/browser/readaloud/player/PlayerMediator.java
M chrome/browser/selection/android/java/src/org/chromium/chrome/browser/selection/SelectionPopupBackPressHandler.java
M chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/TabDragStateDataTest.java
M chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/ArchivedTabCountTracker.java
M chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelImpl.java
M chrome/browser/ui/android/desktop_windowing/java/src/org/chromium/chrome/browser/ui/desktop_windowing/AppHeaderCoordinator.java
M chrome/browser/ui/android/hats/internal/java/src/org/chromium/chrome/browser/ui/hats/SurveyClientImpl.java
M chrome/browser/ui/android/layouts/java/src/org/chromium/chrome/browser/layouts/CompositorModelChangeProcessor.java
M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarCoordinator.java
M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediator.java
M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestionsDropdownEmbedderImpl.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/CustomTabCount.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/KeyboardAccessoryStateSupplier.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/LocationBarFocusScrimHandler.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/MiniOriginBarController.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/ToolbarPositionController.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/back_button/BackButtonMediator.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/reload_button/ReloadButtonMediator.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToggleTabStackButtonCoordinator.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarControlContainer.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarControlContainerTest.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTablet.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/TopToolbarOverlayMediator.java
M chrome/browser/ui/android/web_app_header/java/src/org/chromium/chrome/browser/ui/web_app_header/WebAppHeaderLayoutMediator.java
M chrome/browser/ui/messages/android/java/src/org/chromium/chrome/browser/ui/messages/snackbar/SnackbarTest.java
M components/browser_ui/bottomsheet/android/internal/java/src/org/chromium/components/browser_ui/bottomsheet/BottomSheetControllerImpl.java
M components/browser_ui/modaldialog/android/java/src/org/chromium/components/browser_ui/modaldialog/AppModalPresenter.java
M components/browser_ui/util/android/java/src/org/chromium/components/browser_ui/util/ComposedBrowserControlsVisibilityDelegateTest.java
M components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/scrim/ScrimManager.java
M components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/scrim/ScrimMediator.java
M components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/textbubble/TextBubbleBackPressHandler.java
M components/webxr/android/java/src/org/chromium/components/webxr/XrDelegateImpl.java
M ui/android/java/src/org/chromium/ui/base/ApplicationViewportInsetTracker.java
M ui/android/junit/src/org/chromium/ui/base/ApplicationViewportInsetTrackerTest.java
M ui/edge_to_edge/android/java/src/org/chromium/ui/edge_to_edge/EdgeToEdgeSystemBarColorHelper.java

Change size: L

Delta: 104 files changed, 232 insertions(+), 160 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Fiaz Muhammad

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Inline ObservableSupplier.addObserver() (part 1) [chromium/src : main]

Andrew Grieve (Gerrit)

New activity on the change

Related details

Fiaz Muhammad (Gerrit)

Fiaz Muhammad added 6 comments

Related details

Fiaz Muhammad (Gerrit)

Fiaz Muhammad voted Code-Review+1

Related details

Fiaz Muhammad (Gerrit)

Fiaz Muhammad added 1 comment

Andrew Grieve (Gerrit)

Andrew Grieve voted and added 6 comments

Votes added by Andrew Grieve

6 comments

Related details

Fiaz Muhammad (Gerrit)

Fiaz Muhammad voted and added 1 comment

Votes added by Fiaz Muhammad

1 comment

Related details

Andrew Grieve (Gerrit)

Andrew Grieve voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information