Add flip_y support for Xr layers on browser side [chromium/src : main]

0 views

Skip to first unread message

Alexander Cooper (Gerrit)

unread,

May 26, 2026, 6:29:44 PM (7 days ago) May 26

to Yong Li (xWF), Brandon Jones, chromium...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org

Attention needed from Brandon Jones and Yong Li (xWF)

Alexander Cooper added 2 comments

Commit Message

Line 7, Patchset 3 (Latest):Add flip_y support for Xr layers on browser side

Alexander Cooper . unresolved

This part of the change feels reasonable; but security reviews (for .mojom files) often want to see both sides together, so realistically we should merge this with whatever blink plumbing sets/sends it.

File device/vr/openxr/openxr_graphics_binding.cc

Line 213, Patchset 3 (Latest): GetFlipLayerLayout(*layer_it->second));

Alexander Cooper . unresolved

Given how much it's passed around
`OpenXrCompositionLayer& layer = *layer_it->second;`
After the continue block may be reasonable.

Open in Gerrit

Related details

Attention is currently required from:

Brandon Jones
Yong Li (xWF)

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Yong Li (xWF) (Gerrit)

unread,

Jun 1, 2026, 2:18:36 PM (yesterday) Jun 1

to Code Review Nudger, Alexander Cooper, Brandon Jones, chromium...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org

Yong Li (xWF) abandoned this change.

View Change

Abandoned

going to be merged into the other CL

Yong Li (xWF) abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages