Disable GL_RASTERIZER_DISCARD when clearing XR targets [chromium/src : main]
AI Code Reviewer (Gerrit)
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
Platform::WebGLContextType GetWebGLVersion() const { return webgl_version_; }nit: Blink Style Guide: Precede setters with the word “Set”; use bare words for getters. Consider renaming `GetWebGLVersion()` to `WebGLVersion()` to match the variable name `webgl_version_`, as it does not conflict with the type name.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Brandon Jones voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brandon Jones
| Commit-Queue | +1 |
1 comment
Related details
- Kenneth Russell
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenneth Russell (Gerrit)
Kenneth Russell voted and added 3 comments![]( "Open in Gerrit")
Votes added by Kenneth Russell
| Code-Review | +1 |
3 comments
lgtm
Fixes: 516781007Should be "Fixed" not "Fixes". You can also remove the "Bug:" line if using "Fixed".
Platform::WebGLContextType GetWebGLVersion() const { return webgl_version_; }Might want to add "bool IsWebGL2()" instead of this to make the call site simpler.
Related details
- Brandon Jones
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Brandon Jones voted and added 4 comments![]( "Open in Gerrit")
Votes added by Brandon Jones
| Auto-Submit | +1 |
4 comments
Should be "Fixed" not "Fixes". You can also remove the "Bug:" line if using "Fixed".
I've found that either "Fixed" or "Fixes" works, actually. Didn't know that allowed the Bug line to be omitted, though.
Fixed. ;)
Platform::WebGLContextType GetWebGLVersion() const { return webgl_version_; }nit: Blink Style Guide: Precede setters with the word “Set”; use bare words for getters. Consider renaming `GetWebGLVersion()` to `WebGLVersion()` to match the variable name `webgl_version_`, as it does not conflict with the type name.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Acknowledged
Platform::WebGLContextType GetWebGLVersion() const { return webgl_version_; }Might want to add "bool IsWebGL2()" instead of this to make the call site simpler.
- Kenneth Russell
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenneth Russell (Gerrit)
Kenneth Russell voted and added 2 comments![]( "Open in Gerrit")
Votes added by Kenneth Russell
| Code-Review | +1 |
2 comments
lgtm with one issue still.
Fixes: 516781007Still not Fixed. Have to edit the bug description here in Gerrit, not locally and then re-uploading.
Related details
- Brandon Jones
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Brandon Jones voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brandon Jones
| Auto-Submit | +1 |
| Commit-Queue | +2 |
Still not Fixed. Have to edit the bug description here in Gerrit, not locally and then re-uploading.
Bleh. Done for real this time.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Brandon Jones added 1 comment![]( "Open in Gerrit")
Fixes: 516781007Brandon JonesStill not Fixed. Have to edit the bug description here in Gerrit, not locally and then re-uploading.
Bleh. Done for real this time.
Oh, and apparently my assertion that "Fixes" and "Fixed" are interchangable comes from Dawn, which
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Disable GL_RASTERIZER_DISCARD when clearing XR targets
Prevents a scenario where uninitialized content may be exposed by
a page that sets GL_RASTERIZER_DISCARD prior to getting new WebXR
textures.
- M third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
- M third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.h
- M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
- M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
- M third_party/blink/renderer/modules/xr/xr_webgl_swap_chain.cc
- M third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h
- M third_party/blink/renderer/platform/graphics/gpu/drawing_buffer_test_helpers.h
- M third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
Code-Review: +1 by Kenneth Russell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |