WebXR layers: Allow "default" and "stereo" layout [chromium/src : main]

0 views
Skip to first unread message

Yong Li (xWF) (Gerrit)

unread,
Dec 11, 2025, 11:34:07 AM (5 days ago) Dec 11
to Giovanni Ortuno Urquidi, AyeAye, Chromium IPC Reviews, Alexander Cooper, Brandon Jones, Evgenii Alekseev (xWF), AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Alexander Cooper, Brandon Jones, Giovanni Ortuno Urquidi and Yong Li (xWF)

Message from Yong Li (xWF)

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
  • Brandon Jones
  • Giovanni Ortuno Urquidi
  • Yong Li (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I12d9215b09800d001755b34d018ac8338194eb9c
Gerrit-Change-Number: 7243435
Gerrit-PatchSet: 6
Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Evgenii Alekseev (xWF) <eale...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
Gerrit-Attention: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 16:34:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Cooper (Gerrit)

unread,
Dec 11, 2025, 12:59:04 PM (5 days ago) Dec 11
to Yong Li (xWF), Giovanni Ortuno Urquidi, AyeAye, Chromium IPC Reviews, Brandon Jones, Evgenii Alekseev (xWF), AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Brandon Jones, Giovanni Ortuno Urquidi and Yong Li (xWF)

Alexander Cooper voted and added 4 comments

Votes added by Alexander Cooper

Code-Review+1

4 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Alexander Cooper . resolved

LGTM, a couple of minor tweaks for readability.

File third_party/blink/renderer/modules/xr/xr_composition_layer.cc
Line 87, Patchset 6 (Latest): }
Alexander Cooper . unresolved

Late feedback, but maybe a CHECK here that layout_ != kDefault anymore (e.g. that it was resolved), in case the if/else chain above ever gets more complicated. (Mostly just for future documentation purposes).

File third_party/blink/renderer/modules/xr/xr_cylinder_layer.cc
Line 21, Patchset 6 (Latest): init->textureType().AsEnum() == V8XRTextureType::Enum::kTextureArray),
Alexander Cooper . unresolved

NIT: Would probably be more readable to just use this enum as the parameter rather than a bool that needs to be commented.

File third_party/blink/web_tests/external/wpt/webxr/layers/xrLayerInit.https.html
Line 118, Patchset 6 (Latest): // Cover all shaped layer types.
.then(testCommonXRLayerInitErrors(create_quad_layer, valid_init, t, gl))
.then(testCommonXRLayerInitErrors(create_cylinder_layer, valid_init, t, gl))
.then(testCommonXRLayerInitErrors(create_equirect_layer, valid_init, t, gl))
.then(testCommonXRLayerInitErrors(create_cube_layer, valid_init, t, gl))
// Cube layers don't have texture type specified.
.then(testXRLayerInitTextureArrayErrors(create_quad_layer, valid_init, t, gl))
.then(testXRLayerInitTextureArrayErrors(create_cylinder_layer, valid_init, t, gl))
.then(testXRLayerInitTextureArrayErrors(create_equirect_layer, valid_init, t, gl))
// Cube layers don't have transforms.
.then(testXRLayerInitTransformErrors(create_quad_layer, valid_init, t))
.then(testXRLayerInitTransformErrors(create_cylinder_layer, valid_init, t))
.then(testXRLayerInitTransformErrors(create_equirect_layer, valid_init, t))
// Test layout errors.
.then(testXRLayerInitLayoutErrors(create_quad_layer, valid_init, t, false))
.then(testXRLayerInitLayoutErrors(create_cylinder_layer, valid_init, t, false))
.then(testXRLayerInitLayoutErrors(create_equirect_layer, valid_init, t, false))
.then(testXRLayerInitLayoutErrors(create_cube_layer, valid_init, t, true/*is_cube*/));
Alexander Cooper . unresolved

NIT: I think I'd prefer to group this by layer type for readability. (So you do .then(testCommonXRLayerInitErrors(create_quad_layer, ...))
.then(testXRLayerInitTextureArrayErrors(create_quad_layer, ...))
...
.then(testCommonXRLayerInitErrors(create_cylinder_layer, ...)
...

Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Jones
  • Giovanni Ortuno Urquidi
  • Yong Li (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I12d9215b09800d001755b34d018ac8338194eb9c
Gerrit-Change-Number: 7243435
Gerrit-PatchSet: 6
Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Evgenii Alekseev (xWF) <eale...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
Gerrit-Attention: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 17:58:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yong Li (xWF) (Gerrit)

unread,
Dec 11, 2025, 1:49:45 PM (5 days ago) Dec 11
to Alexander Cooper, Giovanni Ortuno Urquidi, AyeAye, Chromium IPC Reviews, Brandon Jones, Evgenii Alekseev (xWF), AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Alexander Cooper, Brandon Jones and Giovanni Ortuno Urquidi

Yong Li (xWF) added 3 comments

File third_party/blink/renderer/modules/xr/xr_composition_layer.cc
Line 87, Patchset 6: }
Alexander Cooper . resolved

Late feedback, but maybe a CHECK here that layout_ != kDefault anymore (e.g. that it was resolved), in case the if/else chain above ever gets more complicated. (Mostly just for future documentation purposes).

Yong Li (xWF)

Done

File third_party/blink/renderer/modules/xr/xr_cylinder_layer.cc
Line 21, Patchset 6: init->textureType().AsEnum() == V8XRTextureType::Enum::kTextureArray),
Alexander Cooper . resolved

NIT: Would probably be more readable to just use this enum as the parameter rather than a bool that needs to be commented.

Yong Li (xWF)

Done

File third_party/blink/web_tests/external/wpt/webxr/layers/xrLayerInit.https.html
Line 118, Patchset 6: // Cover all shaped layer types.

.then(testCommonXRLayerInitErrors(create_quad_layer, valid_init, t, gl))
.then(testCommonXRLayerInitErrors(create_cylinder_layer, valid_init, t, gl))
.then(testCommonXRLayerInitErrors(create_equirect_layer, valid_init, t, gl))
.then(testCommonXRLayerInitErrors(create_cube_layer, valid_init, t, gl))
// Cube layers don't have texture type specified.
.then(testXRLayerInitTextureArrayErrors(create_quad_layer, valid_init, t, gl))
.then(testXRLayerInitTextureArrayErrors(create_cylinder_layer, valid_init, t, gl))
.then(testXRLayerInitTextureArrayErrors(create_equirect_layer, valid_init, t, gl))
// Cube layers don't have transforms.
.then(testXRLayerInitTransformErrors(create_quad_layer, valid_init, t))
.then(testXRLayerInitTransformErrors(create_cylinder_layer, valid_init, t))
.then(testXRLayerInitTransformErrors(create_equirect_layer, valid_init, t))
// Test layout errors.
.then(testXRLayerInitLayoutErrors(create_quad_layer, valid_init, t, false))
.then(testXRLayerInitLayoutErrors(create_cylinder_layer, valid_init, t, false))
.then(testXRLayerInitLayoutErrors(create_equirect_layer, valid_init, t, false))
.then(testXRLayerInitLayoutErrors(create_cube_layer, valid_init, t, true/*is_cube*/));
Alexander Cooper . resolved

NIT: I think I'd prefer to group this by layer type for readability. (So you do .then(testCommonXRLayerInitErrors(create_quad_layer, ...))
.then(testXRLayerInitTextureArrayErrors(create_quad_layer, ...))
...
.then(testCommonXRLayerInitErrors(create_cylinder_layer, ...)
...

Yong Li (xWF)

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
  • Brandon Jones
  • Giovanni Ortuno Urquidi
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I12d9215b09800d001755b34d018ac8338194eb9c
      Gerrit-Change-Number: 7243435
      Gerrit-PatchSet: 6
      Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
      Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
      Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
      Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Evgenii Alekseev (xWF) <eale...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Brandon Jones <baj...@chromium.org>
      Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
      Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
      Gerrit-Comment-Date: Thu, 11 Dec 2025 18:49:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Alexander Cooper <alco...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Alexander Cooper (Gerrit)

      unread,
      Dec 11, 2025, 1:52:02 PM (5 days ago) Dec 11
      to Yong Li (xWF), Giovanni Ortuno Urquidi, AyeAye, Chromium IPC Reviews, Brandon Jones, Evgenii Alekseev (xWF), AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
      Attention needed from Brandon Jones, Giovanni Ortuno Urquidi and Yong Li (xWF)

      Alexander Cooper voted and added 1 comment

      Votes added by Alexander Cooper

      Code-Review+1

      1 comment

      File third_party/blink/renderer/modules/xr/xr_composition_layer.cc
      Line 89, Patchset 7 (Latest): CHECK(layout_ != V8XRLayerLayout::Enum::kDefault);
      Alexander Cooper . unresolved

      Ultra NIT: CHECK_NE(layout_, V8XRLayerLayout::Enum::kDefault);

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Brandon Jones
      • Giovanni Ortuno Urquidi
      • Yong Li (xWF)
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I12d9215b09800d001755b34d018ac8338194eb9c
        Gerrit-Change-Number: 7243435
        Gerrit-PatchSet: 7
        Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
        Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
        Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
        Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
        Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
        Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Evgenii Alekseev (xWF) <eale...@google.com>
        Gerrit-CC: gwsq
        Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
        Gerrit-Attention: Brandon Jones <baj...@chromium.org>
        Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
        Gerrit-Comment-Date: Thu, 11 Dec 2025 18:51:49 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Yong Li (xWF) (Gerrit)

        unread,
        Dec 11, 2025, 2:03:09 PM (5 days ago) Dec 11
        to Alexander Cooper, Giovanni Ortuno Urquidi, AyeAye, Chromium IPC Reviews, Brandon Jones, Evgenii Alekseev (xWF), AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
        Attention needed from Alexander Cooper, Brandon Jones and Giovanni Ortuno Urquidi

        Yong Li (xWF) added 1 comment

        File third_party/blink/renderer/modules/xr/xr_composition_layer.cc
        Line 89, Patchset 7: CHECK(layout_ != V8XRLayerLayout::Enum::kDefault);
        Alexander Cooper . resolved

        Ultra NIT: CHECK_NE(layout_, V8XRLayerLayout::Enum::kDefault);

        Yong Li (xWF)

        Fix applied.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alexander Cooper
        • Brandon Jones
        • Giovanni Ortuno Urquidi
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I12d9215b09800d001755b34d018ac8338194eb9c
            Gerrit-Change-Number: 7243435
            Gerrit-PatchSet: 8
            Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
            Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
            Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
            Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
            Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
            Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
            Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
            Gerrit-CC: Evgenii Alekseev (xWF) <eale...@google.com>
            Gerrit-CC: gwsq
            Gerrit-Attention: Brandon Jones <baj...@chromium.org>
            Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
            Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
            Gerrit-Comment-Date: Thu, 11 Dec 2025 19:02:22 +0000
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Alexander Cooper (Gerrit)

            unread,
            Dec 11, 2025, 2:08:57 PM (5 days ago) Dec 11
            to Yong Li (xWF), Giovanni Ortuno Urquidi, AyeAye, Chromium IPC Reviews, Brandon Jones, Evgenii Alekseev (xWF), AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
            Attention needed from Brandon Jones, Giovanni Ortuno Urquidi and Yong Li (xWF)

            Alexander Cooper voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Brandon Jones
            • Giovanni Ortuno Urquidi
            • Yong Li (xWF)
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I12d9215b09800d001755b34d018ac8338194eb9c
              Gerrit-Change-Number: 7243435
              Gerrit-PatchSet: 8
              Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
              Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
              Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
              Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
              Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
              Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
              Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
              Gerrit-CC: Evgenii Alekseev (xWF) <eale...@google.com>
              Gerrit-CC: gwsq
              Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
              Gerrit-Attention: Brandon Jones <baj...@chromium.org>
              Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
              Gerrit-Comment-Date: Thu, 11 Dec 2025 19:08:44 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy
              Reply all
              Reply to author
              Forward
              0 new messages