Andrew Paseltiner (Gerrit)

unread,

Mar 11, 2026, 10:02:42 AM (5 days ago) Mar 11

to Daniel Cheng, Peter Beverloo, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, extension...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mtomas...@chromium.org, cros-enterpris...@chromium.org, mfoltz+wa...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, chfreme...@chromium.org, jasonrobe...@google.com, chromium-a...@chromium.org

Attention needed from Daniel Cheng

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Mar 12, 2026, 2:54:29 PM (3 days ago) Mar 12

to Andrew Paseltiner, Daniel Cheng, Peter Beverloo, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, extension...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mtomas...@chromium.org, cros-enterpris...@chromium.org, mfoltz+wa...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, chfreme...@chromium.org, jasonrobe...@google.com, chromium-a...@chromium.org

Attention needed from Andrew Paseltiner

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Daniel Cheng . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Andrew Paseltiner

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Andrew Paseltiner (Gerrit)

unread,

Mar 12, 2026, 2:57:11 PM (3 days ago) Mar 12

to Daniel Cheng, Peter Beverloo, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, extension...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mtomas...@chromium.org, cros-enterpris...@chromium.org, mfoltz+wa...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, chfreme...@chromium.org, jasonrobe...@google.com, chromium-a...@chromium.org

Andrew Paseltiner voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 12, 2026, 5:38:31 PM (3 days ago) Mar 12

to Andrew Paseltiner, Daniel Cheng, Peter Beverloo, Rijubrata Bhaumik, AyeAye, extension...@chromium.org, feature-v...@chromium.org, filesapp...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mtomas...@chromium.org, cros-enterpris...@chromium.org, mfoltz+wa...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, chfreme...@chromium.org, jasonrobe...@google.com, chromium-a...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove redundant string creation with GURL construction

The single-argument GURL constructor accepts a std::string_view, so it
is not necessary to create a string solely to invoke it. When it is
necessary to create a string dynamically, base::StrCat is more efficient
than repeated concatenations.

Change-Id: I1de77928e0f4ef4fb1ec340e2d82d6779aa583c9

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7653218

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Andrew Paseltiner <apase...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1598689}

Files:

M chrome/browser/ash/file_system_provider/extension_provider.cc
M chrome/browser/ui/webui/theme_source.cc
M chrome/browser/vr/graphics_delegate_win.cc
M components/mirroring/service/mirroring_gpu_factories_factory.cc
M components/paint_preview/renderer/paint_preview_recorder_utils.cc
M content/browser/media/android/browser_gpu_video_accelerator_factories.cc
M content/browser/renderer_host/compositor_impl_android.cc
M content/services/isolated_xr_device/xr_runtime_provider.cc
M content/shell/browser/shell_platform_delegate_views.cc
M services/video_capture/video_capture_service_impl.cc

Change size: S

Delta: 10 files changed, 20 insertions(+), 21 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Remove redundant string creation with GURL construction [chromium/src : main]

Andrew Paseltiner (Gerrit)

New activity on the change

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

1 comment

Related details

Andrew Paseltiner (Gerrit)

Andrew Paseltiner voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information