[webxr] Filter out empty camera sync tokens in Blink [chromium/src : main]

0 views
Skip to first unread message

Yong Li (xWF) (Gerrit)

unread,
May 29, 2026, 4:24:12 PM (4 days ago) May 29
to Vasiliy Telezhnikov, Mingjing Zhang, Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper, Mingjing Zhang and Yong Li (xWF)

Message from Yong Li (xWF)

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
  • Mingjing Zhang
  • Yong Li (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1fffd70aa67cc361f7c46cf4b1e1f7da1d872196
Gerrit-Change-Number: 7885484
Gerrit-PatchSet: 2
Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Mingjing Zhang <mjz...@chromium.org>
Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
Gerrit-Comment-Date: Fri, 29 May 2026 20:24:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mingjing Zhang (Gerrit)

unread,
May 29, 2026, 4:26:29 PM (4 days ago) May 29
to Yong Li (xWF), android-bu...@system.gserviceaccount.com, Vasiliy Telezhnikov, Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper and Yong Li (xWF)

Mingjing Zhang voted and added 1 comment

Votes added by Mingjing Zhang

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mingjing Zhang . resolved

LGTM. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
  • Yong Li (xWF)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1fffd70aa67cc361f7c46cf4b1e1f7da1d872196
    Gerrit-Change-Number: 7885484
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
    Gerrit-Comment-Date: Fri, 29 May 2026 20:26:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alexander Cooper (Gerrit)

    unread,
    May 29, 2026, 4:29:52 PM (4 days ago) May 29
    to Yong Li (xWF), Mingjing Zhang, android-bu...@system.gserviceaccount.com, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
    Attention needed from Yong Li (xWF)

    Alexander Cooper voted and added 2 comments

    Votes added by Alexander Cooper

    Code-Review+1

    2 comments

    Patchset-level comments
    Alexander Cooper . resolved

    LGTM thanks

    Commit Message
    Line 10, Patchset 1:graphics binding is registered. On every frame, Blink automatically
    populates the camera_sync_tokens list. If the camera is not accessed,
    Alexander Cooper . resolved

    Can we not instead prevent this?

    Mingjing Zhang

    I think the alternative is to validate the camera SyncTokens [on the Blink side](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/xr/xr_session.cc;l=2334;drc=fcc8e2e643f4beab78d87a7a8566f0ed50332666;bpv=1;bpt=1), and not to push any empty SyncTokens into the `camera_sync_tokens` vector in the first place.

    Alex, do you prefer this Blink-side solution?

    Alexander Cooper

    Yeah, I think it's better to have a well behaved blink send only the tokens we expect

    Mingjing Zhang

    Yeah I agree.

    yyonglii@ Thank you for working on this fix. Could you instead move the SyncToken validation to the Blink side? Thanks.

    Alexander Cooper

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yong Li (xWF)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1fffd70aa67cc361f7c46cf4b1e1f7da1d872196
    Gerrit-Change-Number: 7885484
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Comment-Date: Fri, 29 May 2026 20:29:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Mingjing Zhang <mjz...@chromium.org>
    Comment-In-Reply-To: Alexander Cooper <alco...@chromium.org>
    satisfied_requirement
    open
    diffy

    Yong Li (xWF) (Gerrit)

    unread,
    Jun 1, 2026, 8:22:36 AM (yesterday) Jun 1
    to Alexander Cooper, Mingjing Zhang, android-bu...@system.gserviceaccount.com, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

    Yong Li (xWF) voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1fffd70aa67cc361f7c46cf4b1e1f7da1d872196
    Gerrit-Change-Number: 7885484
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    Gerrit-CC: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 12:22:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 1, 2026, 10:26:43 AM (yesterday) Jun 1
    to Yong Li (xWF), Alexander Cooper, Mingjing Zhang, android-bu...@system.gserviceaccount.com, Vasiliy Telezhnikov, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [webxr] Filter out empty camera sync tokens in Blink

    A non-empty camera sync tokens array fails validation checks on browser
    side. Now only send a non-empty array when there are valid tokens.

    This CL also re-enables the `WebXrVrOpenXrBrowserTest.TestLayers` test
    which was previously disabled due to this crash.
    Bug: 517698312
    Change-Id: I1fffd70aa67cc361f7c46cf4b1e1f7da1d872196
    Commit-Queue: Yong Li (xWF) <yyon...@google.com>
    Reviewed-by: Mingjing Zhang <mjz...@chromium.org>
    Reviewed-by: Alexander Cooper <alco...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1639363}
    Files:
    • M chrome/browser/vr/webxr_vr_layers_browser_test.cc
    • M third_party/blink/renderer/modules/xr/xr_session.cc
    Change size: XS
    Delta: 2 files changed, 5 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alexander Cooper, +1 by Mingjing Zhang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1fffd70aa67cc361f7c46cf4b1e1f7da1d872196
    Gerrit-Change-Number: 7885484
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages