Add SharedImageExportResult to ReturnedResource [chromium/src : main]
Vasiliy Telezhnikov (Gerrit)
Vasiliy Telezhnikov voted and added 4 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
4 comments
// A |sync_token| is an identifier for a point in the parent compositor'snit: Please, update the comment
friend class viz::SurfaceResourceHolder;nit: Do we need this one as we use EndImport now?
auto sync_token = (resource_)nit: I think we should always have resource here. We CHECK that it exists in ctor, we never reset it except the move that happens in `ReleaseResource`. And we either call it from here or dtor.
It's also [CHECKed in the callback](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource.cc;drc=6fe04ac5cd13eaa7013d9da4b94144b4caa1fabf;l=115)
Related details
- Mingjing Zhang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
Mingjing Zhang added 3 comments![]( "Open in Gerrit")
// A |sync_token| is an identifier for a point in the parent compositor'snit: Please, update the comment
Done
nit: Do we need this one as we use EndImport now?
Removed. We no longer need this friend declaration.
nit: I think we should always have resource here. We CHECK that it exists in ctor, we never reset it except the move that happens in `ReleaseResource`. And we either call it from here or dtor.
It's also [CHECKed in the callback](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource.cc;drc=6fe04ac5cd13eaa7013d9da4b94144b4caa1fabf;l=115)
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
Mingjing Zhang added 1 comment![]( "Open in Gerrit")
+blundell@ Please review `ash/frame_sink/*` and `device/vr/android/arcore/ar_compositor_frame_sink.cc`. Thanks.
Context: This CL introduces the struct SharedImageExportResult which wraps one single SyncToken that was previously directly exposed to the clients. This is a transitional step towards hiding SyncTokens in ClientSharedImage. SharedImageExportResult is supposed to be eventually opaque to clients (but not fully so in the current CL since clients still need the SyncToken). ClientSharedImage::EndExport for now serves as a converter that consumes a SharedImageExportResult and yields a SyncToken.
Related details
- Colin Blundell
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
- Mingjing Zhang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
Mingjing Zhang added 1 comment![]( "Open in Gerrit")
+chrome-ipc-reviews@ Please review all `.mojom` and `*mojom_traits.h` files. Thanks.
Context: The new SharedImageExportResult serves as a wrapper for SyncToken used in ReturnedResource. For now clients still need to get the SyncToken from SharedImageExportResult, but our eventual goal is to make this wrapper fully opaque to clients, and handle SyncToken automatically without needing the clients' active participation.
Related details
- Chromium IPC Reviews
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): joenot...@google.com
Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Joe Mason
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |