Update Blink layer and add metrics support for WebXR mesh [chromium/src : main]
Boris Sazonov (Gerrit)
Boris Sazonov added 1 comment![]( "Open in Gerrit")
Changes in chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java seem unintended, can you please double-check?
Related details
- Adam Ren (xWF)
- Alexander Cooper
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Brandon Jones added 2 comments![]( "Open in Gerrit")
import android.content.pm.PackageManager;Are the changes to this file intentional? They seem unrelated to the rest of the CL.
Related details
- Adam Ren (xWF)
- Alexander Cooper
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Alexander Cooper added 3 comments![]( "Open in Gerrit")
import android.content.pm.PackageManager;Are the changes to this file intentional? They seem unrelated to the rest of the CL.
I think these may be leftover from some logic I had him move/remove in the original large CL, the changes here should be removed.
{wf::EnableWebXRMeshDetection,
raw_ref(device::features::kWebXRIncubations)},If we just let the runtime_enabled_features.json5 create a feature we can just go through the steps of adding an about_flags entry; but maybe it's better under incubations.
<!-- LINT.ThenChange(//third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom:WebFeature) -->Please fix this ERROR reported by If This Then That: Changes in the preceding block may need to be reflected in these files: /third_p...
Changes in the preceding block may need to be reflected in these files: /third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom If this does not apply, add 'NO_IFTTT=some reason...' to your commit message
Related details
- Adam Ren (xWF)
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Ren (xWF) (Gerrit)
Adam Ren (xWF) added 3 comments![]( "Open in Gerrit")
Changes in chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java seem unintended, can you please double-check?
Yes, thanks for reminding. It has been removed.
import android.content.pm.PackageManager;Alexander CooperAre the changes to this file intentional? They seem unrelated to the rest of the CL.
I think these may be leftover from some logic I had him move/remove in the original large CL, the changes here should be removed.
Yes, thanks for reminding. It has been removed.
{wf::EnableWebXRMeshDetection,
raw_ref(device::features::kWebXRIncubations)},If we just let the runtime_enabled_features.json5 create a feature we can just go through the steps of adding an about_flags entry; but maybe it's better under incubations.
- Alexander Cooper
- Boris Sazonov
- Brandon Jones
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Ren (xWF) (Gerrit)
Adam Ren (xWF) added 1 comment![]( "Open in Gerrit")
<!-- LINT.ThenChange(//third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom:WebFeature) -->Please fix this ERROR reported by If This Then That: Changes in the preceding block may need to be reflected in these files: /third_p...
Changes in the preceding block may need to be reflected in these files: /third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom If this does not apply, add 'NO_IFTTT=some reason...' to your commit message
Will modify this after all CLs have LGTM and rebasing to the mainline.
Related details
- Alexander Cooper
- Boris Sazonov
- Brandon Jones
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Alexander Cooper added 2 comments![]( "Open in Gerrit")
LGTM once the additional ERROR is fixed.
<!-- LINT.ThenChange(//third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom:WebFeature) -->Adam Ren (xWF)Please fix this ERROR reported by If This Then That: Changes in the preceding block may need to be reflected in these files: /third_p...
Changes in the preceding block may need to be reflected in these files: /third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom If this does not apply, add 'NO_IFTTT=some reason...' to your commit message
Will modify this after all CLs have LGTM and rebasing to the mainline.
I think that one will hit exactly as many merge conflicts as this entry here, so maybe better to just do it now.
Related details
- Adam Ren (xWF)
- Brandon Jones
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Adam Ren (xWF)
- Brandon Jones
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Ren (xWF) (Gerrit)
Adam Ren (xWF) added 1 comment![]( "Open in Gerrit")
<!-- LINT.ThenChange(//third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom:WebFeature) -->Adam Ren (xWF)Please fix this ERROR reported by If This Then That: Changes in the preceding block may need to be reflected in these files: /third_p...
Changes in the preceding block may need to be reflected in these files: /third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom If this does not apply, add 'NO_IFTTT=some reason...' to your commit message
Alexander CooperWill modify this after all CLs have LGTM and rebasing to the mainline.
I think that one will hit exactly as many merge conflicts as this entry here, so maybe better to just do it now.
- Alexander Cooper
- Brandon Jones
- Kouhei Ueno
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
- Adam Ren (xWF)
- Alexander Cooper
- Brandon Jones
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |