[blink][xr] Add a XRLayerUpdate struct to combine LayerId and image ref [chromium/src : main]
0 views
Skip to first unread message
Mingjing Zhang (Gerrit)
Mar 6, 2026, 4:55:16 AM (10 days ago) Mar 6
to Vasiliy Telezhnikov, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Mingjing Zhang added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/xr/xr_frame_provider.h
Line 38, Patchset 4:
struct XRLayerHolder {Vasiliy Telezhnikov . resolved
Mingjing Zhangnit: XRLayerUpdate, as essentially we're tracking update to each layer.
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Mar 9, 2026, 1:18:11 PM (6 days ago) Mar 9
to Mingjing Zhang, Vasiliy Telezhnikov, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Mingjing Zhang
Brandon Jones voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brandon Jones
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mingjing Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
Mar 10, 2026, 12:44:38 AM (6 days ago) Mar 10
to Brandon Jones, Vasiliy Telezhnikov, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Mingjing Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 10, 2026, 1:32:58 AM (6 days ago) Mar 10
to Mingjing Zhang, Brandon Jones, Vasiliy Telezhnikov, AI Code Reviewer, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[blink][xr] Add a XRLayerUpdate struct to combine LayerId and image ref
This CL adds a new XRLayerUpdate struct that holds a LayerId and a
unique_ptr to SharedImageHolder in order to track the update for each
layer. This change is a prerequisite for supporting automatic SyncToken
management in XR code.
Bug: 40286368
Change-Id: I815f6d790a88b9d009d99f04b4abd48e651adab7
Reviewed-by: Brandon Jones <baj...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Mingjing Zhang <mjz...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1596841}
Files:
- M third_party/blink/renderer/modules/xr/xr_frame_provider.cc
- M third_party/blink/renderer/modules/xr/xr_frame_provider.h
Change size: S
Delta: 2 files changed, 21 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brandon Jones, +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages