Jay Harris (Gerrit)

unread,

Feb 8, 2026, 9:52:22 PM (6 days ago) Feb 8

to Rebekah Potter, Chromium LUCI CQ, Demetrios Papadopoulos, chromium...@chromium.org, Sophie Chang, Peter Williamson, Nikhil Nayunigari, AyeAye, menghua...@google.com, xiangdongkong+...@google.com, stevenjb+wa...@chromium.org, michaelcheco+...@google.com, byronle...@chromium.org, hansberry+w...@chromium.org, khorimoto+wa...@chromium.org, vasilii+watchlis...@chromium.org, suetfei+wa...@google.com, ajayramamurth...@google.com, jackshira+w...@google.com, crisrael+w...@google.com, feature-v...@chromium.org, weiluanw...@google.com, oshima...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, mickeybu...@chromium.org, longbowei+fe...@google.com, jackshira+wa...@google.com, mdjone...@chromium.org, borealis-re...@google.com, chrome-intelligence-te...@google.com, ashleydp+fe...@google.com, gavinwill+watch-...@chromium.org, jimmyxgong+watch-shor...@chromium.org, chromeos-ca...@google.com, druber...@chromium.org, pushi+wat...@google.com, chromium-a...@chromium.org, xlythe+wa...@google.com, tbarzi...@chromium.org, extension...@chromium.org, longbowei+watch-shor...@google.com, nikhilcn+wat...@google.com, wangdanny+fe...@google.com, storage...@chromium.org, chlily...@chromium.org, ayman...@chromium.org, cros-ed...@google.com, jimmyxgong+w...@chromium.org, chungshe...@google.com, michaelcheco+...@google.com, jimmyxgong+f...@chromium.org, cambickel+fe...@google.com, ntp-dev...@chromium.org, dclasson+w...@google.com, chadduffin+w...@chromium.org, jackshira+w...@google.com, croissant-...@chromium.org, dfried...@chromium.org, hsuregan+wa...@chromium.org, omnibox-...@chromium.org, chadduffin+wa...@chromium.org, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, estali...@chromium.org, cambickel+watch-shor...@google.com, khorimoto+w...@chromium.org, ejcaruso+wa...@chromium.org, hansberry+wa...@chromium.org, yuezhang...@chromium.org, gavinwill+sc...@chromium.org, jimmyxgong+watch...@chromium.org, dtraino...@chromium.org, jiajunz+wa...@google.com, jiajunz+wat...@google.com, apaselti...@chromium.org, cros-setti...@google.com, hsuregan+wat...@chromium.org, dewitt...@chromium.org, crost...@chromium.org, yyhyyh+fee...@google.com, feature-me...@chromium.org, chrome-intell...@chromium.org, alexmt...@chromium.org, jonmann+wa...@chromium.org, hansenmichael...@google.com, rrsilva+wat...@google.com, dennyh...@google.com, jdonnel...@chromium.org

Jay Harris voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jay Harris (Gerrit)

unread,

Feb 9, 2026, 9:36:01 PM (5 days ago) Feb 9

to Rebekah Potter, Chromium LUCI CQ, Demetrios Papadopoulos, chromium...@chromium.org, Sophie Chang, Peter Williamson, Nikhil Nayunigari, AyeAye, menghua...@google.com, xiangdongkong+...@google.com, stevenjb+wa...@chromium.org, michaelcheco+...@google.com, byronle...@chromium.org, hansberry+w...@chromium.org, khorimoto+wa...@chromium.org, vasilii+watchlis...@chromium.org, suetfei+wa...@google.com, ajayramamurth...@google.com, jackshira+w...@google.com, crisrael+w...@google.com, feature-v...@chromium.org, weiluanw...@google.com, oshima...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, mickeybu...@chromium.org, longbowei+fe...@google.com, jackshira+wa...@google.com, mdjone...@chromium.org, borealis-re...@google.com, chrome-intelligence-te...@google.com, ashleydp+fe...@google.com, gavinwill+watch-...@chromium.org, jimmyxgong+watch-shor...@chromium.org, chromeos-ca...@google.com, druber...@chromium.org, pushi+wat...@google.com, chromium-a...@chromium.org, xlythe+wa...@google.com, tbarzi...@chromium.org, extension...@chromium.org, longbowei+watch-shor...@google.com, nikhilcn+wat...@google.com, wangdanny+fe...@google.com, storage...@chromium.org, chlily...@chromium.org, ayman...@chromium.org, cros-ed...@google.com, jimmyxgong+w...@chromium.org, chungshe...@google.com, michaelcheco+...@google.com, jimmyxgong+f...@chromium.org, cambickel+fe...@google.com, ntp-dev...@chromium.org, dclasson+w...@google.com, chadduffin+w...@chromium.org, jackshira+w...@google.com, croissant-...@chromium.org, dfried...@chromium.org, hsuregan+wa...@chromium.org, omnibox-...@chromium.org, chadduffin+wa...@chromium.org, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, estali...@chromium.org, cambickel+watch-shor...@google.com, khorimoto+w...@chromium.org, ejcaruso+wa...@chromium.org, hansberry+wa...@chromium.org, yuezhang...@chromium.org, gavinwill+sc...@chromium.org, jimmyxgong+watch...@chromium.org, dtraino...@chromium.org, jiajunz+wa...@google.com, jiajunz+wat...@google.com, apaselti...@chromium.org, cros-setti...@google.com, hsuregan+wat...@chromium.org, dewitt...@chromium.org, crost...@chromium.org, yyhyyh+fee...@google.com, feature-me...@chromium.org, chrome-intell...@chromium.org, alexmt...@chromium.org, jonmann+wa...@chromium.org, hansenmichael...@google.com, rrsilva+wat...@google.com, dennyh...@google.com, jdonnel...@chromium.org

Jay Harris voted and added 1 comment

Votes added by Jay Harris

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Jay Harris . resolved

dpapad@ rebekah@ ptal

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Feb 10, 2026, 1:00:59 PM (5 days ago) Feb 10

to Jay Harris, Rebekah Potter, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, Peter Williamson, Nikhil Nayunigari, AyeAye, menghua...@google.com, xiangdongkong+...@google.com, stevenjb+wa...@chromium.org, michaelcheco+...@google.com, byronle...@chromium.org, hansberry+w...@chromium.org, khorimoto+wa...@chromium.org, vasilii+watchlis...@chromium.org, suetfei+wa...@google.com, ajayramamurth...@google.com, jackshira+w...@google.com, crisrael+w...@google.com, feature-v...@chromium.org, weiluanw...@google.com, oshima...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, mickeybu...@chromium.org, longbowei+fe...@google.com, jackshira+wa...@google.com, mdjone...@chromium.org, borealis-re...@google.com, chrome-intelligence-te...@google.com, ashleydp+fe...@google.com, gavinwill+watch-...@chromium.org, jimmyxgong+watch-shor...@chromium.org, chromeos-ca...@google.com, druber...@chromium.org, pushi+wat...@google.com, chromium-a...@chromium.org, xlythe+wa...@google.com, tbarzi...@chromium.org, extension...@chromium.org, longbowei+watch-shor...@google.com, nikhilcn+wat...@google.com, wangdanny+fe...@google.com, storage...@chromium.org, chlily...@chromium.org, ayman...@chromium.org, cros-ed...@google.com, jimmyxgong+w...@chromium.org, chungshe...@google.com, michaelcheco+...@google.com, jimmyxgong+f...@chromium.org, cambickel+fe...@google.com, ntp-dev...@chromium.org, dclasson+w...@google.com, chadduffin+w...@chromium.org, jackshira+w...@google.com, croissant-...@chromium.org, dfried...@chromium.org, hsuregan+wa...@chromium.org, omnibox-...@chromium.org, chadduffin+wa...@chromium.org, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, estali...@chromium.org, cambickel+watch-shor...@google.com, khorimoto+w...@chromium.org, ejcaruso+wa...@chromium.org, hansberry+wa...@chromium.org, yuezhang...@chromium.org, gavinwill+sc...@chromium.org, jimmyxgong+watch...@chromium.org, dtraino...@chromium.org, jiajunz+wa...@google.com, jiajunz+wat...@google.com, apaselti...@chromium.org, cros-setti...@google.com, hsuregan+wat...@chromium.org, dewitt...@chromium.org, crost...@chromium.org, yyhyyh+fee...@google.com, feature-me...@chromium.org, chrome-intell...@chromium.org, alexmt...@chromium.org, jonmann+wa...@chromium.org, hansenmichael...@google.com, rrsilva+wat...@google.com, dennyh...@google.com, jdonnel...@chromium.org

Attention needed from Jay Harris

Demetrios Papadopoulos added 8 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Jay Harris . resolved

dpapad@ rebekah@ ptal

Demetrios Papadopoulos

For some reason none of us is in the attention set as of this writing, which is why this CL does not show up in my queue.

File-level comment, Patchset 4 (Latest):

Demetrios Papadopoulos . unresolved

Can you also update docs/webui/webui_explainer.md to use the new names?

Also, how about migrating one build_webui() target to use the new names as part of tihs CL, so that we know that directly using the names also works corerctly?

Commit Message

Line 7, Patchset 4 (Latest):Replace `mojo_files` and `mojo_files_deps` with `generated_ts_files` and `generated_ts_files_deps`.

Demetrios Papadopoulos . unresolved

This sentence is missing the most important part, which is "build_webui()" or "WebUI".

```suggestion
WebUI: Generalize the names of mojo_files, mojo_files_deps.
```

Line 9, Patchset 4 (Latest):

For now, the old parameters still exist but are aliases to the new ones. I've added a deprecation notice in `webui_build_configuration.md`

Demetrios Papadopoulos . unresolved

Respect line limitns. Use the "Format" button in the Gerrit UI.

Line 14, Patchset 4 (Latest):

Demetrios Papadopoulos . unresolved

Delete extra blank line.

File docs/webui/webui_build_configuration.md

Line 660, Patchset 4 (Latest):

generated_ts_files: List of generated files. These will be copied to a temporary
            location so that they can be passed to ts_library() along with
            other files. Optional parameter.

Demetrios Papadopoulos . unresolved

Re-align the start of each line with the ":"

```suggestion
generated_ts_files: List of generated files. These will be copied to a temporary
                   location so that they can be passed to ts_library() along with
                   other files. Optional parameter.
```
(here and below)

Line 667, Patchset 4 (Latest):generated_base_path: Specifies the directory under which generated files will be served at

Demetrios Papadopoulos . unresolved

Let's rename to `generated_ts_files_base_path` ?

File ui/webui/resources/tools/build_webui.gni

Line 105, Patchset 4 (Latest): # (or deprecated `mojo_files`), or 'ts_files` must be defined. Otherwise, the

Demetrios Papadopoulos . unresolved

Since dealing with mojo_files is already handled earlier at this file, and `mojo_files` is not mentioned anywhere below, let's delete this part of the comment?

Open in Gerrit

Related details

Attention is currently required from:

Jay Harris

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Feb 10, 2026, 1:01:40 PM (5 days ago) Feb 10

to Jay Harris, Rebekah Potter, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, Peter Williamson, Nikhil Nayunigari, AyeAye, menghua...@google.com, xiangdongkong+...@google.com, stevenjb+wa...@chromium.org, michaelcheco+...@google.com, byronle...@chromium.org, hansberry+w...@chromium.org, khorimoto+wa...@chromium.org, vasilii+watchlis...@chromium.org, suetfei+wa...@google.com, ajayramamurth...@google.com, jackshira+w...@google.com, crisrael+w...@google.com, feature-v...@chromium.org, weiluanw...@google.com, oshima...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, mickeybu...@chromium.org, longbowei+fe...@google.com, jackshira+wa...@google.com, mdjone...@chromium.org, borealis-re...@google.com, chrome-intelligence-te...@google.com, ashleydp+fe...@google.com, gavinwill+watch-...@chromium.org, jimmyxgong+watch-shor...@chromium.org, chromeos-ca...@google.com, druber...@chromium.org, pushi+wat...@google.com, chromium-a...@chromium.org, xlythe+wa...@google.com, tbarzi...@chromium.org, extension...@chromium.org, longbowei+watch-shor...@google.com, nikhilcn+wat...@google.com, wangdanny+fe...@google.com, storage...@chromium.org, chlily...@chromium.org, ayman...@chromium.org, cros-ed...@google.com, jimmyxgong+w...@chromium.org, chungshe...@google.com, michaelcheco+...@google.com, jimmyxgong+f...@chromium.org, cambickel+fe...@google.com, ntp-dev...@chromium.org, dclasson+w...@google.com, chadduffin+w...@chromium.org, jackshira+w...@google.com, croissant-...@chromium.org, dfried...@chromium.org, hsuregan+wa...@chromium.org, omnibox-...@chromium.org, chadduffin+wa...@chromium.org, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, estali...@chromium.org, cambickel+watch-shor...@google.com, khorimoto+w...@chromium.org, ejcaruso+wa...@chromium.org, hansberry+wa...@chromium.org, yuezhang...@chromium.org, gavinwill+sc...@chromium.org, jimmyxgong+watch...@chromium.org, dtraino...@chromium.org, jiajunz+wa...@google.com, jiajunz+wat...@google.com, apaselti...@chromium.org, cros-setti...@google.com, hsuregan+wat...@chromium.org, dewitt...@chromium.org, crost...@chromium.org, yyhyyh+fee...@google.com, feature-me...@chromium.org, chrome-intell...@chromium.org, alexmt...@chromium.org, jonmann+wa...@chromium.org, hansenmichael...@google.com, rrsilva+wat...@google.com, dennyh...@google.com, jdonnel...@chromium.org

Attention needed from Jay Harris

Demetrios Papadopoulos added 1 comment

Commit Message

Line 7, Patchset 4 (Latest):Replace `mojo_files` and `mojo_files_deps` with `generated_ts_files` and `generated_ts_files_deps`.

Demetrios Papadopoulos . unresolved

This sentence is missing the most important part, which is "build_webui()" or "WebUI".
```suggestion
WebUI: Generalize the names of mojo_files, mojo_files_deps.
```

Demetrios Papadopoulos

Or even better as follows?

```
WebUI: Generalize the names of mojo_files, mojo_files_deps in build_webui().
```

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Replace `mojo_files` and `mojo_files_deps` with `generated_ts_files` and `generated_ts_files_deps`. [chromium/src : main]

Jay Harris (Gerrit)

Jay Harris voted Commit-Queue+1

Related details

Jay Harris (Gerrit)

Jay Harris voted and added 1 comment

Votes added by Jay Harris

1 comment

Related details

Demetrios Papadopoulos (Gerrit)

Demetrios Papadopoulos added 8 comments

Related details

Demetrios Papadopoulos (Gerrit)

Demetrios Papadopoulos added 1 comment