[M149] [WebXR] Check buffer detachment in XRFrame::fillPoses [chromium/src : refs/branch-heads/7827]

0 views
Skip to first unread message

Alexander Cooper (Gerrit)

unread,
May 28, 2026, 11:34:54 AM (5 days ago) May 28
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, feature-v...@chromium.org, blink-...@chromium.org

Alexander Cooper voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7827
Gerrit-Change-Id: Iac568599933c366e88e56659b783eff92f67948c
Gerrit-Change-Number: 7880145
Gerrit-PatchSet: 2
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Comment-Date: Thu, 28 May 2026 15:34:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 28, 2026, 12:14:48 PM (5 days ago) May 28
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Alexander Cooper, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, feature-v...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M149] [WebXR] Check buffer detachment in XRFrame::fillPoses

Original change's description:
> [WebXR] Check buffer detachment in XRFrame::fillPoses
>
> During XRFrame::fillPoses, calling XRSpace::getPose() can synchronously
> execute script event handlers (e.g., reset events). This script may
> detach the passed-in Float32Array transforms buffer. This change validates
> that the array buffer is not detached prior to writing pose matrices.
>
> Fixed: 513774197
> Change-Id: Iac568599933c366e88e56659b783eff92f67948c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7872178
> Reviewed-by: Brandon Jones <baj...@chromium.org>
> Commit-Queue: Brandon Jones <baj...@chromium.org>
> Auto-Submit: Alexander Cooper <alco...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1636464}

(cherry picked from commit 0bf582443baa115943b71303e89869f41acd5c88)
Bug: 517018364,513774197
Change-Id: Iac568599933c366e88e56659b783eff92f67948c
Commit-Queue: Alexander Cooper <alco...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7827@{#1958}
Cr-Branched-From: 9f3e9aaccba63bd2ec30334e45e0bfd07ebcc8f1-refs/heads/main@{#1625079}
Files:
  • M third_party/blink/renderer/modules/xr/xr_frame.cc
Change size: S
Delta: 1 file changed, 13 insertions(+), 1 deletion(-)
Branch: refs/branch-heads/7827
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7827
Gerrit-Change-Id: Iac568599933c366e88e56659b783eff92f67948c
Gerrit-Change-Number: 7880145
Gerrit-PatchSet: 3
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages