Add missing blink-side features to plane-detection API [chromium/src : main]
Alexander Cooper (Gerrit)
Alexander Cooper voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Cooper
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Related details
- Brandon Jones
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
AI Code Reviewer (Gerrit)
AI Code Reviewer added 2 comments![]( "Open in Gerrit")
bool initiated_room_capture_ = false;nit: Precede boolean values with words like “is” and “did”. Consider renaming `initiated_room_capture_` to `did_initiate_room_capture_` or `has_initiated_room_capture_` to clearly indicate it is a boolean state. (Blink Style Guide: Naming - Precede boolean values with words like “is” and “did”)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
StrCat({kFeatureNotSupportedBySessionPrefix,Blink Style Guide: Prefer blink:: types over STL and base types. `base::StrCat` produces `std::string`. Please use `WTF::String` concatenation (e.g. `operator+` or `StringBuilder`) to avoid unnecessary type conversions.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
- Brandon Jones
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Alexander Cooper voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alexander Cooper
| Auto-Submit | +1 |
2 comments
nit: Precede boolean values with words like “is” and “did”. Consider renaming `initiated_room_capture_` to `did_initiate_room_capture_` or `has_initiated_room_capture_` to clearly indicate it is a boolean state. (Blink Style Guide: Naming - Precede boolean values with words like “is” and “did”)
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Done
Blink Style Guide: Prefer blink:: types over STL and base types. `base::StrCat` produces `std::string`. Please use `WTF::String` concatenation (e.g. `operator+` or `StringBuilder`) to avoid unnecessary type conversions.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Invalid: There actually *is* a WTF::StrCat, which is what intellisense informs me this is using.
Related details
- Brandon Jones
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Brandon Jones voted![]( "Open in Gerrit")
- Alexander Cooper
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/56689.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
- Alexander Cooper
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Add missing blink-side features to plane-detection API
Two features have been added to the plane-detection spec since we last
did work on it. Namely these are the `semanticLabel` attribute and the
`initiateRoomCapture` method. This adds the implementation for both of
those, with `semanticLabel` returning an empty string as allowed by the
spec for an "unknown" label, and with `initiateRoomCapture` doing the
appropriate checks before resulting in a successful no-op, as none of
our runtimes have the ability to request room capture explicitly, again
as allowed by spec.
- M third_party/blink/renderer/modules/xr/xr_plane.cc
- M third_party/blink/renderer/modules/xr/xr_plane.h
- M third_party/blink/renderer/modules/xr/xr_plane.idl
- M third_party/blink/renderer/modules/xr/xr_session.cc
- M third_party/blink/renderer/modules/xr/xr_session.h
- M third_party/blink/renderer/modules/xr/xr_session.idl
- A third_party/blink/web_tests/external/wpt/webxr/plane-detection/META.yml
- A third_party/blink/web_tests/external/wpt/webxr/plane-detection/WEB_FEATURES.yml
- A third_party/blink/web_tests/external/wpt/webxr/plane-detection/idlharness.https.window.js
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Code-Review: +1 by Brandon Jones
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56689
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |