WebXR: Setup DOM overlay fullscreen state only on session success [chromium/src : main]
0 views
Skip to first unread message
Alexander Cooper (Gerrit)
May 22, 2026, 6:13:17 PM (11 days ago) May 22
to Brandon Jones, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones
Alexander Cooper voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Cooper
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Brandon Jones
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
May 26, 2026, 4:42:53 PM (7 days ago) May 26
to Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper
Brandon Jones voted![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Cooper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 26, 2026, 6:17:28 PM (7 days ago) May 26
to Alexander Cooper, Brandon Jones, chromium...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
WebXR: Setup DOM overlay fullscreen state only on session success
Previously, when requesting a WebXR session with DOM Overlay, the
browser process would speculatively notify the RenderFrameHost that an
XR overlay was being set up prior to session confirmation. If the XR
runtime rejected or failed to establish the session, the browser could
get left in an inconsistent state regarding fullscreen entrance rules.
This change defers notifying the RenderFrameHost about the XR overlay
setup until after the immersive session has been fully established and
granted by the XR runtime.
Fixed: 514039492
Change-Id: Ie5eb759dc09fa239d93168b01f38b745f50b89cd
Reviewed-by: Brandon Jones <baj...@chromium.org>
Commit-Queue: Brandon Jones <baj...@chromium.org>
Auto-Submit: Alexander Cooper <alco...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1636518}
Files:
- M content/browser/xr/service/vr_service_impl.cc
Change size: S
Delta: 1 file changed, 6 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brandon Jones
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages