Android: Make MonotonicObservableSupplier inherit Supplier<@Nullable T> [chromium/src : main]

0 views

Skip to first unread message

Andrew Grieve (Gerrit)

unread,

Feb 4, 2026, 1:17:51 PM (11 days ago) Feb 4

to Andrew Grieve, Henrique Nakashima, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, chrome-tab-group-en...@google.com, davidj...@chromium.org, dtraino...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, pkotwic...@chromium.org, roagarw...@chromium.org, torne...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Henrique Nakashima

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Henrique Nakashima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Henrique Nakashima (Gerrit)

unread,

Feb 4, 2026, 1:29:24 PM (11 days ago) Feb 4

to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, chrome-tab-group-en...@google.com, davidj...@chromium.org, dtraino...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, pkotwic...@chromium.org, roagarw...@chromium.org, torne...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Attention needed from Andrew Grieve

Henrique Nakashima voted and added 1 comment

Votes added by Henrique Nakashima

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Henrique Nakashima . resolved

I would've tried to break this down a bit into [migrate Supplier<A>, ..., migrate Supplier<E>, change MonotonicObservableSupplier, but if this is easier go for it.

Yay! 😄

Open in Gerrit

Related details

Attention is currently required from:

Andrew Grieve

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Andrew Grieve (Gerrit)

unread,

Feb 4, 2026, 1:37:34 PM (10 days ago) Feb 4

Andrew Grieve voted and added 1 comment

Votes added by Andrew Grieve

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Henrique Nakashima . resolved

I would've tried to break this down a bit into [migrate Supplier<A>, ..., migrate Supplier<E>, change MonotonicObservableSupplier, but if this is easier go for it.
Yay! 😄

Andrew Grieve

I could have split out some to of the changes to NonNullObservableSuppliers, but all the individual ones need to go together because of the change to ChromeNullAwayLibraryModel.java.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 4, 2026, 1:43:00 PM (10 days ago) Feb 4

to Andrew Grieve, Henrique Nakashima, chromium...@chromium.org, Peter Beverloo, agriev...@chromium.org, ayman...@chromium.org, browser-comp...@chromium.org, chili...@chromium.org, chrome-tab-group-en...@google.com, davidj...@chromium.org, dtraino...@chromium.org, ender...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, gcasto+w...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, lizeb+watch...@chromium.org, lizeb...@chromium.org, mattsimm...@chromium.org, mdjone...@chromium.org, meilian...@chromium.org, ntp-dev...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, peilinwa...@google.com, pkotwic...@chromium.org, roagarw...@chromium.org, torne...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, wychen...@chromium.org, yfriedm...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Android: Make MonotonicObservableSupplier inherit Supplier<@Nullable T>

And fix all warnings that come with it.

Bug: 467389696

Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size

Change-Id: I86becbc2f3c149941e3401fd726d7062a261bd7a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7533558

Reviewed-by: Henrique Nakashima <hnaka...@chromium.org>

Commit-Queue: Andrew Grieve <agr...@chromium.org>

Owners-Override: Henrique Nakashima <hnaka...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1579593}

Files:

M base/android/java/src/org/chromium/base/supplier/BaseObservableSupplierImpl.java
M base/android/java/src/org/chromium/base/supplier/SupplierUtils.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/IncognitoTabSwitcherPane.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogCoordinator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogMediator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupVisualDataDialogManager.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupsPane.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListContainerProperties.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListContainerViewBinder.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListMediator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPane.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneBase.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneCoordinator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherPaneCoordinatorFactoryUnitTest.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/pinned_tabs_strip/PinnedTabStripMediator.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetFusebox.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetManager.java
M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/tab_bottom_sheet/TabBottomSheetManagerTest.java
M chrome/android/java/src/org/chromium/chrome/browser/ActivityTabProvider.java
M chrome/android/java/src/org/chromium/chrome/browser/TabbedMismatchedIndicesHandler.java
M chrome/android/java/src/org/chromium/chrome/browser/TabbedModeTabDelegateFactory.java
M chrome/android/java/src/org/chromium/chrome/browser/app/tab_activity_glue/ActivityTabWebContentsDelegateAndroid.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerImpl.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/TabGroupContextMenuCoordinator.java
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandlerBase.java
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandlerCompat.java
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandlerFactory.java
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandlerLegacy.java
M chrome/android/java/src/org/chromium/chrome/browser/history/HistoryActivity.java
M chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
M chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiInstanceManagerApi31.java
M chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiInstanceManagerImpl.java
M chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerV2.java
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxActionDelegateImpl.java
M chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordCheckupLauncher.java
M chrome/android/java/src/org/chromium/chrome/browser/read_later/ReadingListBackPressHandler.java
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
M chrome/android/java/src/org/chromium/chrome/browser/settings/FragmentDependencyProvider.java
M chrome/android/java/src/org/chromium/chrome/browser/settings/SettingsActivity.java
M chrome/android/java/src/org/chromium/chrome/browser/sync/synced_set_up/CrossDeviceSettingImporter.java
M chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SettableLookAheadObservableSupplier.java
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorProfileSupplier.java
M chrome/android/java/src/org/chromium/chrome/browser/ui/AdaptiveToolbarUiCoordinator.java
M chrome/android/java/src/org/chromium/chrome/browser/ui/activity_recreation/ActivityRecreationController.java
M chrome/android/java/src/org/chromium/chrome/browser/ui/system/StatusBarColorController.java
M chrome/android/java/src/org/chromium/chrome/browser/vr/VrCompositorDelegateImpl.java
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActionsNotificationManager.java
M chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManagerTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/history/HistoryUiTest.java
M chrome/android/junit/src/org/chromium/chrome/browser/searchwidget/SearchActivityUnitTest.java
M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarMediator.java
M chrome/browser/commerce/merchant_viewer/android/java/src/org/chromium/chrome/browser/merchant_viewer/MerchantTrustBottomSheetMediator.java
M chrome/browser/commerce/price_tracking/android/java/src/org/chromium/chrome/browser/price_tracking/PriceTrackingButtonController.java
M chrome/browser/data_sharing/android/java/src/org/chromium/chrome/browser/data_sharing/DataSharingTabManager.java
M chrome/browser/educational_tip/java/src/org/chromium/chrome/browser/educational_tip/cards/HistorySyncPromoCoordinator.java
M chrome/browser/incognito/android/java/src/org/chromium/chrome/browser/incognito/IncognitoStartup.java
M chrome/browser/readaloud/android/java/src/org/chromium/chrome/browser/readaloud/ReadAloudController.java
M chrome/browser/single_tab/android/java/src/org/chromium/chrome/browser/single_tab/SingleTabModuleBuilder.java
M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediator.java
M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediatorTest.java
M chrome/browser/ui/android/signin/java/src/org/chromium/chrome/browser/ui/signin/BottomSheetSigninAndHistorySyncCoordinator.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/ToolbarPositionController.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToggleTabStackButton.java
M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToggleTabStackButtonCoordinator.java
M tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/ChromeNullAwayLibraryModel.java
M ui/android/java/src/org/chromium/ui/base/WindowAndroid.java

Change size: L

Delta: 73 files changed, 326 insertions(+), 318 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Henrique Nakashima

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages