Create and use XrNextChainBuilder to simplify extending next chains [chromium/src : main]
0 views
Skip to first unread message
Alexander Cooper (Gerrit)
Feb 12, 2026, 5:23:45 PM (2 days ago) Feb 12
to Brandon Jones, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones
Alexander Cooper added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Brandon Jones
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Feb 12, 2026, 5:32:01 PM (2 days ago) Feb 12
to Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper
Brandon Jones voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brandon Jones
| Code-Review | +1 |
1 comment
Patchset-level comments
Brandon Jones . resolved
LGTM! Thanks for taking the time to update existing chains too!
Related details
Attention is currently required from:
- Alexander Cooper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Feb 12, 2026, 5:33:27 PM (2 days ago) Feb 12
to Brandon Jones, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Alexander Cooper voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 12, 2026, 5:56:36 PM (2 days ago) Feb 12
to Alexander Cooper, Brandon Jones, chromium...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Create and use XrNextChainBuilder to simplify extending next chains
Creates a templated XrNextChainBuilder to allow appending arbitrary
structs to the next chain of an existing struct. This approach
constantly pushes items further down the next chain. It was briefly
considered to constantly track and append to the end of the current next
chain, but given comments regarding asan builds on a similar dawn
helper, this approach was chosen instead.
This change also adopts the XrNextChainBuilder in several places where
next chains were being extended. For now, if the next chain only
contained (and seemed like it would only ever contain for the
foreseeable future) two items (e.g. SystemProperties structs), the new
struct was not used, as it would only add complexity to those simple
scenarios.
Note that this also involved changing the types for the method on the
OpenXrHandTracker to extend the next chain, as this is now a more robust
solution.
Change-Id: Ic58532719f7431b8c18d0e50efa525f2b44f2376
Reviewed-by: Brandon Jones <baj...@chromium.org>
Commit-Queue: Alexander Cooper <alco...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1584266}
Files:
- M device/vr/openxr/android/openxr_light_estimator_android.cc
- M device/vr/openxr/fb/openxr_hand_tracker_fb.cc
- M device/vr/openxr/fb/openxr_hand_tracker_fb.h
- M device/vr/openxr/openxr_hand_tracker.cc
- M device/vr/openxr/openxr_hand_tracker.h
- M device/vr/openxr/openxr_spatial_plane_manager.cc
- M device/vr/openxr/openxr_util.h
Change size: M
Delta: 7 files changed, 60 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brandon Jones
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages