Android: Convert XrSessionTypeSupplier -> SettableNonNullObservableSupplier [chromium/src : main]

0 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Dec 12, 2025, 9:54:25 AM (4 days ago) Dec 12
to Andrew Grieve, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Calder Kitagawa

Andrew Grieve voted

Auto-Submit+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Calder Kitagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I965045fa8434a2f5eef28d0ed127ed336ad19f8d
Gerrit-Change-Number: 7253230
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Attention: Calder Kitagawa <ckit...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Dec 2025 14:54:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Calder Kitagawa (Gerrit)

unread,
Dec 12, 2025, 11:08:10 AM (4 days ago) Dec 12
to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Andrew Grieve

Calder Kitagawa voted and added 1 comment

Votes added by Calder Kitagawa

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Calder Kitagawa . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I965045fa8434a2f5eef28d0ed127ed336ad19f8d
    Gerrit-Change-Number: 7253230
    Gerrit-PatchSet: 2
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Comment-Date: Fri, 12 Dec 2025 16:07:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Andrew Grieve (Gerrit)

    unread,
    Dec 12, 2025, 11:58:07 AM (4 days ago) Dec 12
    to Andrew Grieve, Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org

    Andrew Grieve voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I965045fa8434a2f5eef28d0ed127ed336ad19f8d
    Gerrit-Change-Number: 7253230
    Gerrit-PatchSet: 2
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    Gerrit-Comment-Date: Fri, 12 Dec 2025 16:58:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 12, 2025, 12:01:04 PM (4 days ago) Dec 12
    to Andrew Grieve, Calder Kitagawa, chromium...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Android: Convert XrSessionTypeSupplier -> SettableNonNullObservableSupplier
    Bug: 467389696
    Change-Id: I965045fa8434a2f5eef28d0ed127ed336ad19f8d
    Owners-Override: Andrew Grieve <agr...@chromium.org>
    Commit-Queue: Andrew Grieve <agr...@chromium.org>
    Auto-Submit: Andrew Grieve <agr...@chromium.org>
    Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1558101}
    Files:
    • M components/webxr/android/BUILD.gn
    • M components/webxr/android/java/src/org/chromium/components/webxr/XrSessionCoordinator.java
    • D components/webxr/android/java/src/org/chromium/components/webxr/XrSessionTypeSupplier.java
    Change size: S
    Delta: 3 files changed, 9 insertions(+), 29 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Calder Kitagawa
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I965045fa8434a2f5eef28d0ed127ed336ad19f8d
    Gerrit-Change-Number: 7253230
    Gerrit-PatchSet: 3
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Calder Kitagawa <ckit...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages