[WebXR] Gate Image Tracking feature support behind kWebXRIncubations [chromium/src : main]

0 views
Skip to first unread message

Alexander Cooper (Gerrit)

unread,
May 29, 2026, 3:13:49 PM (4 days ago) May 29
to Brandon Jones, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones

Alexander Cooper voted and added 1 comment

Votes added by Alexander Cooper

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Alexander Cooper . resolved

Brandon PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Jones
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9f762e7d9b95b18a11d40f49938d2f902c83c8b2
Gerrit-Change-Number: 7885633
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Brandon Jones <baj...@chromium.org>
Gerrit-Comment-Date: Fri, 29 May 2026 19:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brandon Jones (Gerrit)

unread,
Jun 1, 2026, 6:37:41 PM (yesterday) Jun 1
to Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper

Brandon Jones voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9f762e7d9b95b18a11d40f49938d2f902c83c8b2
    Gerrit-Change-Number: 7885633
    Gerrit-PatchSet: 3
    Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 22:37:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 1, 2026, 7:48:55 PM (yesterday) Jun 1
    to Alexander Cooper, Brandon Jones, chromium...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [WebXR] Gate Image Tracking feature support behind kWebXRIncubations

    Ensures that the ArCoreDevice only advertises support for the
    experimental IMAGE_TRACKING WebXR session feature when the
    base::FeatureList check for features::kWebXRIncubations is enabled,
    rather than advertising it unconditionally.
    Fixed: 516606322
    Change-Id: I9f762e7d9b95b18a11d40f49938d2f902c83c8b2
    Commit-Queue: Brandon Jones <baj...@chromium.org>
    Auto-Submit: Alexander Cooper <alco...@chromium.org>
    Reviewed-by: Brandon Jones <baj...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1639780}
    Files:
    • M device/vr/android/arcore/arcore_device.cc
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brandon Jones
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9f762e7d9b95b18a11d40f49938d2f902c83c8b2
    Gerrit-Change-Number: 7885633
    Gerrit-PatchSet: 4
    Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages