[ImmersivePlayback] Fix crash when exiting immersive playback [chromium/src : main]

0 views
Skip to first unread message

Gurmeet Kalra (Gerrit)

unread,
May 28, 2026, 8:02:51 PM (5 days ago) May 28
to Oleh Desiatyrikov (xWF), Chromium LUCI CQ, Nick Mondello, chromium...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org
Attention needed from Nick Mondello and Oleh Desiatyrikov (xWF)

Gurmeet Kalra voted and added 1 comment

Votes added by Gurmeet Kalra

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Gurmeet Kalra . resolved

LGTM. Thanks for using `dispose` as it is more fitting than `dismiss` or `destroy` in this context due to clarity of intent and consistency in lifecycle mgmt during full teardown.

Open in Gerrit

Related details

Attention is currently required from:
  • Nick Mondello
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1a3c989ed8c92b6c0afac45dc10d96e70271e801
Gerrit-Change-Number: 7882272
Gerrit-PatchSet: 1
Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
Gerrit-Reviewer: Nick Mondello <mond...@google.com>
Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Attention: Nick Mondello <mond...@google.com>
Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Comment-Date: Fri, 29 May 2026 00:02:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nick Mondello (Gerrit)

unread,
May 28, 2026, 8:05:07 PM (5 days ago) May 28
to Oleh Desiatyrikov (xWF), Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org
Attention needed from Oleh Desiatyrikov (xWF)

Nick Mondello voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1a3c989ed8c92b6c0afac45dc10d96e70271e801
    Gerrit-Change-Number: 7882272
    Gerrit-PatchSet: 1
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Comment-Date: Fri, 29 May 2026 00:04:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Oleh Desiatyrikov (xWF) (Gerrit)

    unread,
    May 28, 2026, 9:09:34 PM (5 days ago) May 28
    to Nick Mondello, Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org

    Oleh Desiatyrikov (xWF) voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1a3c989ed8c92b6c0afac45dc10d96e70271e801
    Gerrit-Change-Number: 7882272
    Gerrit-PatchSet: 1
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Comment-Date: Fri, 29 May 2026 01:09:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 28, 2026, 9:13:16 PM (5 days ago) May 28
    to Oleh Desiatyrikov (xWF), Nick Mondello, Gurmeet Kalra, chromium...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [ImmersivePlayback] Fix crash when exiting immersive playback

    During immersive playback teardown, hiding the control panel triggers
    a synchronous hover-exit event that re-posts the auto-hide timer task.
    This runnable subsequently attempts to access a disposed SurfaceEntity
    on the player panel, throwing a DisposedException and crashing the app.

    To fix this:
    - Rearrange the dismiss() implementations to unregister hover listeners
      before modifying visibility/disabling the entity.
    - Standardize cleanup/lifecycle methods to dispose() and ensure all child
      coordinators dismiss and dispose their spatial holders.
    - Update the JUnit test suite to verify the new disposal logic.
    Bug: 516864911
    Change-Id: I1a3c989ed8c92b6c0afac45dc10d96e70271e801
    Commit-Queue: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Reviewed-by: Gurmeet Kalra <gurm...@google.com>
    Reviewed-by: Nick Mondello <mond...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1638137}
    Files:
    • M chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/media/immersive_playback/ImmersiveVideoPlaybackActivity.java
    • M chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/media/immersive_playback/ImmersiveVideoPlaybackCoordinator.java
    • M chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/media/immersive_playback/components/ImmersiveVideoControlCoordinator.java
    • M chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/media/immersive_playback/components/ImmersiveVideoFormatCoordinator.java
    • M chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/media/immersive_playback/components/ImmersiveVideoPlayerCoordinator.java
    • M chrome/android/modules/xr/internal/junit/src/org/chromium/chrome/browser/media/immersive_playback/ImmersiveVideoPlaybackCoordinatorTest.java
    • M chrome/android/modules/xr/internal/junit/src/org/chromium/chrome/browser/media/immersive_playback/components/ImmersiveVideoControlCoordinatorTest.java
    • M chrome/android/modules/xr/internal/junit/src/org/chromium/chrome/browser/media/immersive_playback/components/ImmersiveVideoFormatCoordinatorTest.java
    • M chrome/android/modules/xr/internal/junit/src/org/chromium/chrome/browser/media/immersive_playback/components/ImmersiveVideoPlayerCoordinatorTest.java
    Change size: M
    Delta: 9 files changed, 54 insertions(+), 15 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Gurmeet Kalra, +1 by Nick Mondello
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1a3c989ed8c92b6c0afac45dc10d96e70271e801
    Gerrit-Change-Number: 7882272
    Gerrit-PatchSet: 2
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages