[WebXR] Inspect frame subtree for cross-origin content in DOM Overlay [chromium/src : main]

0 views
Skip to first unread message

Alexander Cooper (Gerrit)

unread,
May 29, 2026, 5:08:44 PM (4 days ago) May 29
to Brandon Jones, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones

Alexander Cooper voted and added 1 comment

Votes added by Alexander Cooper

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alexander Cooper . resolved

Brandon PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Jones
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1d09f5d76c7e88570ab3a5164511cdea81cbf60d
Gerrit-Change-Number: 7886118
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Brandon Jones <baj...@chromium.org>
Gerrit-Comment-Date: Fri, 29 May 2026 21:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brandon Jones (Gerrit)

unread,
Jun 1, 2026, 6:42:01 PM (yesterday) Jun 1
to Alexander Cooper, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper

Brandon Jones voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1d09f5d76c7e88570ab3a5164511cdea81cbf60d
    Gerrit-Change-Number: 7886118
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 22:41:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 1, 2026, 8:37:30 PM (24 hours ago) Jun 1
    to Alexander Cooper, Brandon Jones, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [WebXR] Inspect frame subtree for cross-origin content in DOM Overlay

    Ensures that same-origin wrapper iframes cannot bypass input
    suppression in WebXR DOM overlays. When processing overlay hit
    test results, walk the entire frame subtree rooted at the hit
    frame to verify if any descendant frame is remote or cross-origin
    with the session.
    Fixed: 517628043
    Change-Id: I1d09f5d76c7e88570ab3a5164511cdea81cbf60d
    Reviewed-by: Brandon Jones <baj...@chromium.org>
    Auto-Submit: Alexander Cooper <alco...@chromium.org>
    Commit-Queue: Brandon Jones <baj...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1639815}
    Files:
    • M third_party/blink/renderer/modules/xr/xr_input_source.cc
    Change size: S
    Delta: 1 file changed, 17 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brandon Jones
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1d09f5d76c7e88570ab3a5164511cdea81cbf60d
    Gerrit-Change-Number: 7886118
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages