Revert "[xr] Move GpuFence creation into ClientSharedImage for OpenXR" [chromium/src : main]

0 views
Skip to first unread message

Tommy Nyquist (Gerrit)

unread,
May 28, 2026, 7:44:08 PM (5 days ago) May 28
to rubber-...@appspot.gserviceaccount.com, Mingjing Zhang, Chromium LUCI CQ, Alexander Cooper, Vasiliy Telezhnikov, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Attention needed from Alexander Cooper, Mingjing Zhang, Tommy Nyquist and Vasiliy Telezhnikov

Tommy Nyquist voted

Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
  • Mingjing Zhang
  • Tommy Nyquist
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6427d05b810bfb349b47b84aa2b79045f454648
Gerrit-Change-Number: 7882495
Gerrit-PatchSet: 1
Gerrit-Owner: Tommy Nyquist <nyq...@chromium.org>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Tommy Nyquist <nyq...@chromium.org>
Gerrit-Attention: Mingjing Zhang <mjz...@chromium.org>
Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Thu, 28 May 2026 23:43:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
May 28, 2026, 7:44:17 PM (5 days ago) May 28
to Tommy Nyquist, Mingjing Zhang, Chromium LUCI CQ, Alexander Cooper, Vasiliy Telezhnikov, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Attention needed from Alexander Cooper, Mingjing Zhang, Tommy Nyquist and Vasiliy Telezhnikov

Related details

Attention is currently required from:
  • Alexander Cooper
  • Mingjing Zhang
  • Tommy Nyquist
  • Vasiliy Telezhnikov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If6427d05b810bfb349b47b84aa2b79045f454648
    Gerrit-Change-Number: 7882495
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tommy Nyquist <nyq...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Reviewer: Tommy Nyquist <nyq...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Attention: Tommy Nyquist <nyq...@chromium.org>
    Gerrit-Attention: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
    Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-Comment-Date: Thu, 28 May 2026 23:44:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 28, 2026, 7:44:59 PM (5 days ago) May 28
    to Tommy Nyquist, rubber-...@appspot.gserviceaccount.com, Mingjing Zhang, Alexander Cooper, Vasiliy Telezhnikov, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "[xr] Move GpuFence creation into ClientSharedImage for OpenXR"

    This reverts commit 39b2d5ddfe1aabea931b7f72325c44a4c473c718.

    Reason for revert: Consistently fails multiple bots:
    android-14-arm64-rel
    android-14-tablet-landscape-arm64-rel

    First failing builds:
    https://ci.chromium.org/ui/p/chromium/builders/ci/android-14-arm64-rel/17170/overview
    https://ci.chromium.org/ui/p/chromium/builders/ci/android-14-tablet-landscape-arm64-rel/9859/overview

    Original change's description:
    > [xr] Move GpuFence creation into ClientSharedImage for OpenXR
    >
    > As part of the effort of moving SyncToken management in
    > ClientSharedImage, this CL moves the GpuFence creation in OpenXR into
    > ClientSharedImage::CreateGpuFenceForSyncTokens(). To support this
    > change, we also added a GetSharedImages() member in
    > OpenXrGraphicsBinding to retrieve ClientSharedImages for layers, and
    > changed the GpuFence destruction timing to match the model used by
    > Cardboard in ClientSharedImage::CreateGpuFenceForSyncTokens().
    >
    > Change-Id: Id9891c9a343b40df4ed687d7bfe34df10c81598c
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7866522
    > Commit-Queue: Mingjing Zhang <mjz...@chromium.org>
    > Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
    > Reviewed-by: Alexander Cooper <alco...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1637809}
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: If6427d05b810bfb349b47b84aa2b79045f454648
    Auto-Submit: Tommy Nyquist <nyq...@chromium.org>
    Owners-Override: Tommy Nyquist <nyq...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1638052}
    Files:
    • M device/vr/openxr/openxr_graphics_binding.cc
    • M device/vr/openxr/openxr_graphics_binding.h
    • M device/vr/openxr/openxr_render_loop.cc
    • M device/vr/openxr/openxr_render_loop.h
    Change size: M
    Delta: 4 files changed, 17 insertions(+), 41 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If6427d05b810bfb349b47b84aa2b79045f454648
    Gerrit-Change-Number: 7882495
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages