Disable GL_RASTERIZER_DISCARD when clearing XR swapchains [chromium/src : main]

0 views
Skip to first unread message

Brandon Jones (Gerrit)

unread,
3:09 PM (5 hours ago) 3:09 PM
to Alexander Cooper, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper

Brandon Jones voted and added 1 comment

Votes added by Brandon Jones

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Brandon Jones . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib1e910ee5a9630a66ea202d5868b91349842a3c3
Gerrit-Change-Number: 7897301
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Jones <baj...@chromium.org>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jun 2026 19:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Cooper (Gerrit)

unread,
3:53 PM (5 hours ago) 3:53 PM
to Brandon Jones, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones

Alexander Cooper voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Jones
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib1e910ee5a9630a66ea202d5868b91349842a3c3
    Gerrit-Change-Number: 7897301
    Gerrit-PatchSet: 1
    Gerrit-Owner: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Attention: Brandon Jones <baj...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Jun 2026 19:53:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    5:10 PM (3 hours ago) 5:10 PM
    to Brandon Jones, Alexander Cooper, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Disable GL_RASTERIZER_DISCARD when clearing XR swapchains

    Ensures that GL_RASTERIZER_DISCARD is disabled when clearing WebXR
    swapchains produced by the system. Prevents a scenario where
    uninitialized content may be exposed to the page.
    Fixed: 518337516
    Change-Id: Ib1e910ee5a9630a66ea202d5868b91349842a3c3
    Commit-Queue: Brandon Jones <baj...@chromium.org>
    Auto-Submit: Brandon Jones <baj...@chromium.org>
    Commit-Queue: Alexander Cooper <alco...@chromium.org>
    Reviewed-by: Alexander Cooper <alco...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1640452}
    Files:
    • M third_party/blink/renderer/modules/xr/xr_webgl_cubemap_swap_chain.cc
    • M third_party/blink/renderer/modules/xr/xr_webgl_texture_array_swap_chain.cc
    Change size: S
    Delta: 2 files changed, 11 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alexander Cooper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib1e910ee5a9630a66ea202d5868b91349842a3c3
    Gerrit-Change-Number: 7897301
    Gerrit-PatchSet: 2
    Gerrit-Owner: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages