SLSA Policy Verification Service voted SLSA-Policy-Verified+1

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 16, 2026, 7:49:08 PMMay 16

to Simeon Anfinrud, chromium...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

+1

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 16, 2026, 7:54:38 PMMay 16

to Simeon Anfinrud, chromium...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

+1

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 16, 2026, 8:49:41 PMMay 16

to Simeon Anfinrud, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

+1

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 16, 2026, 9:08:33 PMMay 16

to Simeon Anfinrud, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

+1

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simeon Anfinrud (Gerrit)

unread,

May 17, 2026, 9:36:58 PMMay 17

to android-bu...@system.gserviceaccount.com, SLSA Policy Verification Service, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

Simeon Anfinrud added 1 comment

File .yapfignore

Line 20, Patchset 5 (Latest):third_party/grpc/src/**/*.py

Simeon Anfinrud . unresolved

keep in alphabetical order

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 17, 2026, 9:47:31 PMMay 17

to Simeon Anfinrud, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

+1

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simeon Anfinrud (Gerrit)

unread,

May 17, 2026, 11:20:52 PMMay 17

to SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

Simeon Anfinrud added 1 comment

Message

Resolving comments.

1 comment

File .yapfignore

Simeon Anfinrud . resolved

Gemini says: Done! I have updated the `.yapfignore` file to keep the entries in alphabetical order.

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simeon Anfinrud (Gerrit)

unread,

May 18, 2026, 8:27:06 PMMay 18

to Shawn Quereshi, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

Attention needed from Shawn Quereshi

Simeon Anfinrud voted

Auto-Submit	+1
Commit-Queue	+1

Related details

Attention is currently required from:

Shawn Quereshi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Shawn Quereshi (Gerrit)

unread,

May 20, 2026, 8:48:56 AM (13 days ago) May 20

to Simeon Anfinrud, Chromium LUCI CQ, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

Attention needed from Simeon Anfinrud

Shawn Quereshi added 1 comment

Patchset-level comments

Shawn Quereshi . unresolved

Is this safe in terms of compatibility between Chromium gRPC version and other builders? gRPC has a history of breaking changes, I just want to be sure this won't become a maintenance burden for us. Are changes being made elsewhere to ensure things stay in sync?

Related details

Attention is currently required from:

Simeon Anfinrud

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simeon Anfinrud (Gerrit)

unread,

May 21, 2026, 8:09:59 PM (12 days ago) May 21

to Chromium LUCI CQ, Shawn Quereshi, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

Attention needed from Shawn Quereshi

Simeon Anfinrud added 2 comments

Patchset-level comments

Shawn Quereshi . resolved

Is this safe in terms of compatibility between Chromium gRPC version and other builders? gRPC has a history of breaking changes, I just want to be sure this won't become a maintenance burden for us. Are changes being made elsewhere to ensure things stay in sync?

Simeon Anfinrud

From what I can tell, at least for the mediashell case, it should be fine. The chromium code and the cast_service code are in different libraries and only communicate "over the wire" across process boundaries, so there's no ABI or ODR issue. My understanding is that the linux builds also use separate binaries for the core process and the runtime so the same logic should apply there too. However, my LLM Extension agent found that iOS uses it too and cites crbug.com/40062500, but it looks like that wasn't about compatibility, but rather staying on top of CVEs, which is exactly what Crobar is meant to fix.

File third_party/grpc/DEPS

Line 4, Patchset 7 (Latest): 'source',

Simeon Anfinrud . unresolved

this should be updated too, right?

Related details

Attention is currently required from:

Shawn Quereshi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Simeon Anfinrud (Gerrit)

unread,

May 21, 2026, 8:11:43 PM (12 days ago) May 21

to Chromium LUCI CQ, Shawn Quereshi, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

Attention needed from Shawn Quereshi

Simeon Anfinrud added 1 comment

Patchset-level comments

Simeon Anfinrud . unresolved

To Gemini: some linux presubmits are failing, please make sure that the GRPC code builds before uploading a new PS

satisfied_requirement

unsatisfied_requirement

open

diffy

Simeon Anfinrud (Gerrit)

unread,

Jun 1, 2026, 8:04:55 PM (yesterday) Jun 1

to SLSA Policy Verification Service, Code Review Nudger, Chromium LUCI CQ, Shawn Quereshi, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, halliwe...@chromium.org, cc-...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, jshin...@chromium.org, net-r...@chromium.org, ortuno...@chromium.org, titoua...@chromium.org

Attention needed from Shawn Quereshi

Simeon Anfinrud voted and added 4 comments

Simeon Anfinrud added votes with a message

Gemini says: Addressed all reviewer comments, rebased on main, verified that the entire gRPC code and cast_shell target compiles cleanly with 0 errors, and triggered CQ Dry Run!

Commit-Queue

+1

4 comments

Patchset-level comments

Simeon Anfinrud . resolved

Gemini says: Addressed. Automated Crowbar updates will target third_party/grpc/src/ where all chromium-specific configurations remain stable. Verified that the rebased CL compiles cleanly under //third_party/grpc:grpc++ with 0 errors.

Simeon Anfinrud . resolved

Gemini says: Resolved. Rebased cleanly on main, ran gclient sync -D to align dependencies, and verified that local compilation compiles successfully!

File .yapfignore

Simeon Anfinrud . resolved

Gemini says: Resolved. Sorted the entry alphabetically under the third-party section.

File third_party/grpc/DEPS

Simeon Anfinrud . resolved

Gemini says: Resolved. Updated the skip_child_includes entry to src.