[M138-LTS][WebXR] Update detached matrix handling [chromium/src : refs/branch-heads/7204]
0 views
Skip to first unread message
Roger Felipe Zanoni da Silva (xWF) (Gerrit)
Dec 22, 2025, 12:52:15 PM12/22/25
to Alexander Cooper, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Message from Roger Felipe Zanoni da Silva (xWF)![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Dec 22, 2025, 12:56:51 PM12/22/25
to Alexander Cooper, Roger Felipe Zanoni da Silva (xWF), Andrey Kosyakov, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Andrey Kosyakov and Roger Felipe Zanoni da Silva (xWF)
Brandon Jones voted Code-Review+1![]( "Open in Gerrit")
- Roger Felipe Zanoni da Silva (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Dec 22, 2025, 2:15:31 PM12/22/25
to Alexander Cooper, Roger Felipe Zanoni da Silva (xWF), Brandon Jones, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Roger Felipe Zanoni da Silva (xWF)
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Roger Felipe Zanoni da Silva (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Dec 22, 2025, 11:38:54 PM12/22/25
to Alexander Cooper, Brandon Jones, Mohamed Omar, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper, Brandon Jones and Mohamed Omar
Gyuyoung Kim (xWF) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Gyuyoung Kim (xWF) . resolved
The bug was approved to merge to M138 LTS. PTAL.
Related details
Attention is currently required from:
- Alexander Cooper
- Brandon Jones
- Mohamed Omar
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Dec 23, 2025, 12:04:30 AM12/23/25
to Alexander Cooper, Brandon Jones, Mohamed Omar, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper, Brandon Jones, Gyuyoung Kim (xWF) and Mohamed Omar
Gyuyoung Kim (xWF) removed a vote from this change![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Cooper
- Brandon Jones
- Gyuyoung Kim (xWF)
- Mohamed Omar
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mohamed Omar (Gerrit)
Dec 23, 2025, 3:20:10 AM12/23/25
to Gyuyoung Kim (xWF), Alexander Cooper, Brandon Jones, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper, Brandon Jones and Gyuyoung Kim (xWF)
Mohamed Omar voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Alexander Cooper
- Brandon Jones
- Gyuyoung Kim (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Dec 23, 2025, 10:54:16 AM12/23/25
to Gyuyoung Kim (xWF), Alexander Cooper, Jeremy Roman, Mohamed Omar, Brandon Jones, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper, Brandon Jones and Gyuyoung Kim (xWF)
Jeremy Roman voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alexander Cooper
- Brandon Jones
- Gyuyoung Kim (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Dec 23, 2025, 10:55:57 AM12/23/25
to Alexander Cooper, Jeremy Roman, Mohamed Omar, Brandon Jones, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper and Brandon Jones
Gyuyoung Kim (xWF) voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Alexander Cooper
- Brandon Jones
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 23, 2025, 11:00:57 AM12/23/25
to Gyuyoung Kim (xWF), Alexander Cooper, Jeremy Roman, Mohamed Omar, Brandon Jones, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M138-LTS][WebXR] Update detached matrix handling
Updates a few places that handle an array representation of a matrix
being detached by returning a 0-length array to simply recompute the
array that should be present, based on the presence of other data. This
more closely matches the spec, which for both of these cases essentially
state that if the value is not null to check if it's detached, and if it
is not detached to return the value. The steps following both of these
checks then recompute the matrix, so technically our current impl is
not spec-compliant to that.
Further, we remove one unused array to transform conversion helper and
update another to a CHECK from a DCHECK to match best practices for
invariants.
(cherry picked from commit 6c5963ad6b4541f5fa0812607fd36a979c48c0f1)
Fixed: 452071845
Change-Id: Idf765fe5717d59ae63c71e8253784ff4473dea5f
Commit-Queue: Alexander Cooper <alco...@chromium.org>
Reviewed-by: Brandon Jones <baj...@chromium.org>
Auto-Submit: Alexander Cooper <alco...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1530947}
Commit-Queue: Jeremy Roman <jbr...@chromium.org>
Reviewed-by: Mohamed Omar <mohame...@google.com>
Owners-Override: Mohamed Omar <mohame...@google.com>
Reviewed-by: Jeremy Roman <jbr...@chromium.org>
Commit-Queue: Gyuyoung Kim (xWF) <qk...@google.com>
Cr-Commit-Position: refs/branch-heads/7204@{#3469}
Cr-Branched-From: d5de512dc9dc8ddfe4e6d71b0637578bb6158683-refs/heads/main@{#1465706}
Files:
- M third_party/blink/renderer/modules/xr/xr_rigid_transform.cc
- M third_party/blink/renderer/modules/xr/xr_utils.cc
- M third_party/blink/renderer/modules/xr/xr_utils.h
- M third_party/blink/renderer/modules/xr/xr_view.cc
- M third_party/blink/renderer/modules/xr/xr_view.h
Change size: S
Delta: 5 files changed, 8 insertions(+), 18 deletions(-)
Branch: refs/branch-heads/7204
Submit Requirements:
Code-Review: +1 by Mohamed Omar, +1 by Jeremy Roman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Roger Felipe Zanoni da Silva (xWF) (Gerrit)
Feb 11, 2026, 11:30:06 AM (4 days ago) Feb 11
to Alexander Cooper, Andrey Kosyakov, Brandon Jones, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Roger Felipe Zanoni da Silva (xWF) abandoned this change.
Abandoned
Already merged on https://crrev.com/c/7077799
Roger Felipe Zanoni da Silva (xWF) abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages