[WebXR] Check buffer detachment in XRFrame::fillPoses [chromium/src : main]
0 views
Skip to first unread message
Alexander Cooper (Gerrit)
May 22, 2026, 6:13:49 PM (11 days ago) May 22
to Brandon Jones, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones
Alexander Cooper voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Cooper
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Brandon Jones
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
May 26, 2026, 4:44:08 PM (7 days ago) May 26
to Alexander Cooper, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper
Brandon Jones voted![]( "Open in Gerrit")
Attention is currently required from:
- Alexander Cooper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 26, 2026, 4:47:32 PM (7 days ago) May 26
to Alexander Cooper, Brandon Jones, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[WebXR] Check buffer detachment in XRFrame::fillPoses
During XRFrame::fillPoses, calling XRSpace::getPose() can synchronously
execute script event handlers (e.g., reset events). This script may
detach the passed-in Float32Array transforms buffer. This change validates
that the array buffer is not detached prior to writing pose matrices.
Fixed: 513774197
Change-Id: Iac568599933c366e88e56659b783eff92f67948c
Reviewed-by: Brandon Jones <baj...@chromium.org>
Commit-Queue: Brandon Jones <baj...@chromium.org>
Auto-Submit: Alexander Cooper <alco...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1636464}
Files:
- M third_party/blink/renderer/modules/xr/xr_frame.cc
Change size: S
Delta: 1 file changed, 13 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brandon Jones
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages