[WebXR] Check buffer detachment in XRFrame::fillPoses [chromium/src : main]

0 views
Skip to first unread message

Alexander Cooper (Gerrit)

unread,
May 22, 2026, 6:13:49 PM (11 days ago) May 22
to Brandon Jones, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones

Alexander Cooper voted and added 1 comment

Votes added by Alexander Cooper

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alexander Cooper . resolved

Brandon PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Jones
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iac568599933c366e88e56659b783eff92f67948c
Gerrit-Change-Number: 7872178
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Brandon Jones <baj...@chromium.org>
Gerrit-Comment-Date: Fri, 22 May 2026 22:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brandon Jones (Gerrit)

unread,
May 26, 2026, 4:44:08 PM (7 days ago) May 26
to Alexander Cooper, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper

Brandon Jones voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Cooper
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iac568599933c366e88e56659b783eff92f67948c
    Gerrit-Change-Number: 7872178
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Attention: Alexander Cooper <alco...@chromium.org>
    Gerrit-Comment-Date: Tue, 26 May 2026 20:43:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 26, 2026, 4:47:32 PM (7 days ago) May 26
    to Alexander Cooper, Brandon Jones, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [WebXR] Check buffer detachment in XRFrame::fillPoses

    During XRFrame::fillPoses, calling XRSpace::getPose() can synchronously
    execute script event handlers (e.g., reset events). This script may
    detach the passed-in Float32Array transforms buffer. This change validates
    that the array buffer is not detached prior to writing pose matrices.
    Fixed: 513774197
    Change-Id: Iac568599933c366e88e56659b783eff92f67948c
    Reviewed-by: Brandon Jones <baj...@chromium.org>
    Commit-Queue: Brandon Jones <baj...@chromium.org>
    Auto-Submit: Alexander Cooper <alco...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1636464}
    Files:
    • M third_party/blink/renderer/modules/xr/xr_frame.cc
    Change size: S
    Delta: 1 file changed, 13 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brandon Jones
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iac568599933c366e88e56659b783eff92f67948c
    Gerrit-Change-Number: 7872178
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages