Add WPT and browser tests for XR media layers [chromium/src : main]

0 views
Skip to first unread message

Alexander Cooper (Gerrit)

unread,
May 26, 2026, 7:35:48 PM (7 days ago) May 26
to Yong Li (xWF), Brandon Jones, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones and Yong Li (xWF)

Alexander Cooper added 2 comments

File chrome/test/data/xr/e2e_test_files/html/test_openxr_media_layers.html
Line 52, Patchset 3 (Latest):
// Fallback: set videoReady to true after 1 second to avoid timeout
setTimeout(() => {
console.log("Setting videoReady to true via timeout fallback");
videoReady = true;
}, 1000);
Alexander Cooper . unresolved

Should clarify when we might see this fallback and why, otherwise it seems like something we probably shouldn't be doing as something else could be wrong? (e.g. video isn't pumping frames)

Line 60, Patchset 3 (Latest): console.log("onRequestSession overridden");
Alexander Cooper . unresolved

Should probably remove most of these console.log's

Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Jones
  • Yong Li (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I688408ed4fe9bdf0fb4f63034843af8aedfc3b40
Gerrit-Change-Number: 7860206
Gerrit-PatchSet: 3
Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
Gerrit-Attention: Brandon Jones <baj...@chromium.org>
Gerrit-Comment-Date: Tue, 26 May 2026 23:35:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages