Revert "spanification: spanify PaintCanvasVideoRenderer::ConvertVideoFrameToRGBPixels." [chromium/src : main]

0 views
Skip to first unread message

Viktor Semeniuk (Gerrit)

unread,
6:16 AM (4 hours ago) 6:16 AM
to Rubber Stamper, Stephen Nusko, Xiaoqian Dai, Chromium LUCI CQ, Colin Blundell, Thomas Guilbert, Weidong Liu, AyeAye, Stephen Chenney, chromium...@chromium.org, Dirk Schulze, oshima...@chromium.org, feature-me...@chromium.org
Attention needed from Colin Blundell, Stephen Nusko, Thomas Guilbert, Weidong Liu and Xiaoqian Dai

Viktor Semeniuk voted

Auto-Submit+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Stephen Nusko
  • Thomas Guilbert
  • Weidong Liu
  • Xiaoqian Dai
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaca94f3a8fcff4e7867abb3b9f71abe7f8658005
Gerrit-Change-Number: 7510883
Gerrit-PatchSet: 1
Gerrit-Owner: Viktor Semeniuk <vsem...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-Reviewer: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Reviewer: Viktor Semeniuk <vsem...@google.com>
Gerrit-Reviewer: Weidong Liu <weido...@chromium.org>
Gerrit-Reviewer: Xiaoqian Dai <xd...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
Gerrit-Attention: Xiaoqian Dai <xd...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Thomas Guilbert <tgui...@chromium.org>
Gerrit-Attention: Weidong Liu <weido...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Jan 2026 11:15:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
6:16 AM (4 hours ago) 6:16 AM
to Viktor Semeniuk, Stephen Nusko, Xiaoqian Dai, Chromium LUCI CQ, Colin Blundell, Thomas Guilbert, Weidong Liu, AyeAye, Stephen Chenney, chromium...@chromium.org, Dirk Schulze, oshima...@chromium.org, feature-me...@chromium.org
Attention needed from Colin Blundell, Stephen Nusko, Thomas Guilbert, Weidong Liu and Xiaoqian Dai

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Stephen Nusko
  • Thomas Guilbert
  • Weidong Liu
  • Xiaoqian Dai
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Comment-Date: Thu, 22 Jan 2026 11:16:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    6:17 AM (4 hours ago) 6:17 AM
    to Viktor Semeniuk, Rubber Stamper, Stephen Nusko, Xiaoqian Dai, Colin Blundell, Thomas Guilbert, Weidong Liu, AyeAye, Stephen Chenney, chromium...@chromium.org, Dirk Schulze, oshima...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "spanification: spanify PaintCanvasVideoRenderer::ConvertVideoFrameToRGBPixels."

    This reverts commit 70695a5f4f93425f85738f6c8cf44e69ba2122a2.

    Reason for revert: Breaks MSAN builders with "Uninitialized value was created by an allocation of 'row_bytes' in the stack frame in media::PaintCanvasVideoRenderer::Paint" 

    First failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/61332/overview

    Original change's description:
    > spanification: spanify PaintCanvasVideoRenderer::ConvertVideoFrameToRGBPixels.
    >
    > Bug: 40284755
    > Change-Id: I01e76e424e27800bdf595781f799bdedb6b8dd7a
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7264088
    > Reviewed-by: Stephen Nusko <nus...@chromium.org>
    > Reviewed-by: Thomas Guilbert <tgui...@chromium.org>
    > Commit-Queue: Weidong Liu <weido...@chromium.org>
    > Reviewed-by: Xiaoqian Dai <xd...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1572768}
    Bug: 40284755
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: Iaca94f3a8fcff4e7867abb3b9f71abe7f8658005
    Auto-Submit: Viktor Semeniuk <vsem...@google.com>
    Owners-Override: Viktor Semeniuk <vsem...@google.com>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1572855}
    Files:
    • M base/containers/auto_spanification_helper.h
    • M chromeos/ash/services/recording/recording_service.cc
    • M media/renderers/paint_canvas_video_renderer.cc
    • M media/renderers/paint_canvas_video_renderer.h
    • M media/renderers/paint_canvas_video_renderer_unittest.cc
    • M media/renderers/video_resource_updater.cc
    Change size: L
    Delta: 6 files changed, 154 insertions(+), 207 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaca94f3a8fcff4e7867abb3b9f71abe7f8658005
    Gerrit-Change-Number: 7510883
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages