Di Wu (Gerrit)

unread,

Jul 17, 2026, 2:24:18 AMJul 17

to Timothy Loh, SLSA Policy Verification Service, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Timothy Loh

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Di Wu . unresolved

Hi @tim...@chromium.org, please help review this cleanup. Many thanks!

Open in Gerrit

Related details

Attention is currently required from:

Timothy Loh

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Timothy Loh (Gerrit)

unread,

Jul 17, 2026, 3:34:25 AMJul 17

to Di Wu, SLSA Policy Verification Service, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu

Timothy Loh voted and added 3 comments

Votes added by Timothy Loh

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Di Wu . resolved

Hi @tim...@chromium.org, please help review this cleanup. Many thanks!

Timothy Loh

thanks for doing this!

File chrome/browser/ui/ash/shelf/app_service/exo_app_type_resolver.cc

Line 83, Patchset 10 (Parent): // GuestOS VMs

Timothy Loh . unresolved

Could probably leave this comment, I assume it was meant to be for the code below too

File chromeos/chromeos_strings.grd

Line 5203, Patchset 10 (Parent): Pluginvm

Timothy Loh . unresolved

I think we can probably remove this (looks like it gets plumbed through to webui but neither I nor jetski could find where that gets used anyway)

Open in Gerrit

Related details

Attention is currently required from:

Di Wu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 21, 2026, 12:24:38 AMJul 21

to SLSA Policy Verification Service, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Timothy Loh

Di Wu added 2 comments

File chrome/browser/ui/ash/shelf/app_service/exo_app_type_resolver.cc

Line 83, Patchset 10 (Parent): // GuestOS VMs

Timothy Loh . resolved

Could probably leave this comment, I assume it was meant to be for the code below too

Di Wu

Done

File chromeos/chromeos_strings.grd

Line 5203, Patchset 10 (Parent): Pluginvm

Timothy Loh . resolved

I think we can probably remove this (looks like it gets plumbed through to webui but neither I nor jetski could find where that gets used anyway)

Di Wu

Done

Open in Gerrit

Related details

Attention is currently required from:

Timothy Loh

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 21, 2026, 12:26:55 AMJul 21

to SLSA Policy Verification Service, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Timothy Loh

Di Wu added 1 comment

File chrome/browser/prefs/browser_prefs.cc

Line 1014, Patchset 12 (Latest):

// Deprecated 07/2026.
constexpr char kMetricsReportingMigrationDone[] =
    "user_experience_metrics.consent_migration_done";
constexpr char kMetricsConsentRestructureFeatureState[] =
    "user_experience_metrics.consent_restructure_feature_state";

Di Wu . resolved

This comes from rebase.

satisfied_requirement

unsatisfied_requirement

open

diffy

Timothy Loh (Gerrit)

unread,

Jul 21, 2026, 12:28:45 AMJul 21

to Di Wu, SLSA Policy Verification Service, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu

Timothy Loh voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Di Wu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 21, 2026, 2:38:33 AMJul 21

to Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, SLSA Policy Verification Service, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Alexander Bolodurin and Alexander Bolodurin

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Di Wu . unresolved

Hi @ale...@chromium.org (cc @ale...@google.com), need your help reviewing this dead code cleanup cl. Specifically, the following files. Many thanks!

```
ui/file_manager/file_manager/background/js/ crostini.ts
ui/file_manager/file_manager/background/js/ crostini_unittest.ts
ui/file_manager/file_manager/ BUILD.gn
ui/file_manager/file_manager/common/js/ entry_utils.ts
ui/file_manager/file_manager/common/js/ file_type.ts
ui/file_manager/file_manager/common/js/ flags.ts
ui/file_manager/file_manager/common/js/ translations.ts
ui/file_manager/file_manager/definitions/ file_manager_private.d.ts
ui/file_manager/file_manager/foreground/css/ file_types.css
ui/file_manager/file_manager/foreground/images/volumes/ plugin_vm_ng.svg
ui/file_manager/file_manager/foreground/js/ banner_controller.ts
ui/file_manager/file_manager/foreground/js/ command_handler.ts
ui/file_manager/file_manager/foreground/js/ constants.ts
ui/file_manager/file_manager/foreground/js/ crostini_controller.ts
ui/file_manager/file_manager/foreground/js/ dialog_action_controller_unittest.ts
ui/file_manager/file_manager/foreground/js/ directory_contents.ts
ui/file_manager/file_manager/foreground/js/ directory_contents_unittest.ts
ui/file_manager/file_manager/foreground/js/ directory_model_unittest.ts
ui/file_manager/file_manager/foreground/js/ file_manager.ts
ui/file_manager/file_manager/foreground/js/ file_manager_commands.ts
ui/file_manager/file_manager/foreground/js/ file_tasks.ts
ui/file_manager/file_manager/foreground/js/ file_tasks_unittest.ts
ui/file_manager/file_manager/foreground/js/ path_component.ts
ui/file_manager/file_manager/foreground/js/ path_component_unittest.ts
ui/file_manager/file_manager/foreground/js/ task_controller.ts
ui/file_manager/file_manager/foreground/js/ui/banners/ shared_with_crostini_banner.html
ui/file_manager/file_manager/foreground/js/ui/banners/ shared_with_crostini_banner.ts
ui/file_manager/file_manager/foreground/js/ui/banners/ shared_with_crostini_pluginvm_banner.html
ui/file_manager/file_manager/foreground/js/ui/banners/ shared_with_crostini_pluginvm_banner.ts
ui/file_manager/file_manager/foreground/js/ui/ file_manager_ui.ts
ui/file_manager/file_manager/ main.html
ui/file_manager/file_manager/state/ state.ts
ui/file_manager/file_manager/widgets/ xf_icon.ts
ui/file_manager/ file_names.gni
ui/file_manager/integration_tests/file_manager/ crostini.ts
ui/file_manager/integration_tests/ test_util.ts
```

Open in Gerrit

Related details

Attention is currently required from:

Alexander Bolodurin
Alexander Bolodurin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 21, 2026, 9:54:27 PMJul 21

to SLSA Policy Verification Service, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Alexander Bolodurin and Alexander Bolodurin

Di Wu added 1 comment

File chrome/browser/ash/guest_os/guest_os_share_path_unittest.cc

Line 45, Patchset 13 (Latest):#include "chromeos/ash/components/install_attributes/stub_install_attributes.h"

Di Wu . unresolved

introduced due to rebase

Open in Gerrit

Related details

Attention is currently required from:

Alexander Bolodurin
Alexander Bolodurin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexander Bolodurin (Gerrit)

unread,

Jul 21, 2026, 10:09:24 PMJul 21

to Di Wu, SLSA Policy Verification Service, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Alexander Bolodurin and Di Wu

Alexander Bolodurin voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexander Bolodurin
Di Wu

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 22, 2026, 10:45:47 PM (13 days ago) Jul 22

to Ahmed Fakhry, SLSA Policy Verification Service, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Ahmed Fakhry and Alexander Bolodurin

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Di Wu . unresolved

Hi @afa...@chromium.org, this is a dumb mechanical clean up of the now deprecated Plugin VM feature. Need your help reviewing the following code revomals. Many thanks!

```
chromeos/ui/base/ window_properties.h
chromeos/ui/base/ window_properties.cc

chrome/browser/ui/ash/shelf/app_service/ app_service_app_window_crostini_tracker.cc
chrome/browser/ui/ash/shelf/app_service/ app_service_app_window_shelf_controller.cc
chrome/browser/ui/ash/shelf/app_service/ app_service_shelf_context_menu.cc
chrome/browser/ui/ash/shelf/app_service/ BUILD.gn
chrome/browser/ui/ash/shelf/app_service/ exo_app_type_resolver.cc
chrome/browser/ui/ash/shelf/ BUILD.gn
chrome/browser/ui/ash/shelf/ chrome_shelf_controller_util.cc

chrome/browser/ash/printing/ BUILD.gn

chrome/browser/ash/policy/status_collector/ app_info_generator_unittest.cc
chrome/browser/ash/policy/status_collector/ device_status_collector_unittest.cc

chrome/browser/ash/policy/dlp/dialogs/ files_policy_warn_dialog.cc

chrome/browser/ash/policy/core/ device_policy_decoder.cc
chrome/browser/ash/policy/handlers/ BUILD.gn
chrome/browser/ash/policy/handlers/ lock_to_single_user_manager.h
chrome/browser/ash/policy/handlers/ lock_to_single_user_manager.cc
chrome/browser/ash/policy/handlers/ lock_to_single_user_manager_unittest.cc
chrome/browser/ash/settings/ device_settings_provider.cc
chrome/browser/ash/settings/ device_settings_provider_unittest.cc

chrome/browser/ash/login/ chrome_restart_request.cc
chrome/browser/ash/login/session/ BUILD.gn
chrome/browser/ash/login/session/ user_session_initializer.cc

chrome/browser/ash/keyed_service/ browser_context_keyed_service_factories.cc
chrome/browser/ash/keyed_service/ BUILD.gn

chrome/browser/ash/extensions/autotest_private/ autotest_private_api.h
chrome/browser/ash/extensions/autotest_private/ autotest_private_api.cc
chrome/browser/ash/extensions/autotest_private/ BUILD.gn

chrome/browser/ash/exo/ BUILD.gn
chrome/browser/ash/exo/ chrome_data_exchange_delegate.cc
chrome/browser/ash/exo/ chrome_data_exchange_delegate_unittest.cc
chrome/browser/ash/exo/ chrome_security_delegate.cc
chrome/browser/ash/exo/ chrome_security_delegate_unittest.cc

chrome/browser/ash/dbus/ ash_dbus_helper.cc
chrome/browser/ash/dbus/ BUILD.gn
chrome/browser/ash/dbus/ chrome_features_service_provider.h
chrome/browser/ash/dbus/ chrome_features_service_provider.cc

chrome/browser/ash/concierge_helper/ concierge_helper_service.h
chrome/browser/ash/concierge_helper/ concierge_helper_service.cc
chrome/browser/ash/concierge_helper/ concierge_helper_service_unittest.cc
chrome/browser/ash/main_parts/ chrome_browser_main_parts_ash.cc
chrome/browser/ash/video_conference/ BUILD.gn
chrome/browser/ash/video_conference/ video_conference_ash_feature_client.h
chrome/browser/ash/video_conference/ video_conference_ash_feature_client.cc
chrome/browser/ash/video_conference/ video_conference_ash_feature_client_browsertest.cc

chrome/browser/ash/app_list/search/ app_service_app_result.cc

chrome/browser/ash/app_list/app_service/ app_service_app_item.cc
chrome/browser/ash/app_list/app_service/ app_service_app_model_builder_unittest.cc
chrome/browser/ash/app_list/app_service/ app_service_context_menu.cc
chrome/browser/ash/app_list/app_service/ BUILD.gn

ash/webui/network_ui/ traffic_counters_resource_provider.cc

ash/system/video_conference/bubble/ bubble_view_pixeltest.cc
ash/system/video_conference/ video_conference_common.h

ash/resources/vector_icons/ BUILD.gn
ash/resources/vector_icons/ notification_plugin_vm.icon

ash/public/cpp/app_list/ app_list_metrics.h
```

Open in Gerrit

Related details

Attention is currently required from:

Ahmed Fakhry
Alexander Bolodurin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 22, 2026, 11:04:15 PM (13 days ago) Jul 22

to Kyle Horimoto, Ahmed Fakhry, SLSA Policy Verification Service, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Ahmed Fakhry, Alexander Bolodurin and Kyle Horimoto

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Di Wu . unresolved

Hi @khor...@chromium.org , this is a dumb mechanical cleanup of the now sunsetted Plugin VM feature. Need your help reviewing the following dead code removals. Many thanks!

```
ash/public/cpp/app_list/ app_list_metrics.h

chrome/browser/apps/app_service/ BUILD.gn
chrome/browser/apps/app_service/metrics/ app_service_metrics.cc
chrome/browser/apps/app_service/publishers/ BUILD.gn
chrome/browser/apps/app_service/publishers/ OWNERS
chrome/browser/apps/app_service/publishers/ publisher_host_impl.h
chrome/browser/apps/app_service/publishers/ publisher_host_impl.cc

chrome/browser/ash/app_list/app_service/ DEPS
chrome/browser/ash/app_list/ DEPS

chrome/browser/ash/dbus/ DEPS

chrome/browser/ash/exo/ DEPS

chrome/browser/ash/extensions/autotest_private/ DEPS

chrome/browser/ash/keyed_service/ DEPS

chrome/browser/ash/login/session/ DEPS

chrome/browser/ash/policy/handlers/ DEPS

chrome/browser/ash/printing/ DEPS

chrome/browser/ash/video_conference/ DEPS

chrome/browser/download/ background_download_service_factory.cc
chrome/browser/download/ BUILD.gn

chrome/browser/extensions/api/processes/ processes_api.cc

chrome/browser/extensions/api/settings_private/ prefs_util.cc

chrome/browser/extensions/ BUILD.gn

chrome/browser/policy/annotations/ annotation_control_provider.cc
chrome/browser/policy/annotations/ annotation_control_provider_unittest.cc

chrome/browser/policy/ BUILD.gn
chrome/browser/policy/ configuration_policy_handler_list_factory.cc
chrome/browser/policy/ restricted_mgs_policy_provider.cc
chrome/browser/policy/ restricted_mgs_policy_provider_ash_browsertest.cc
chrome/browser/policy/ restricted_mgs_policy_provider_ash_unittest.cc

chrome/browser/prefs/ browser_prefs.cc
chrome/browser/prefs/ BUILD.gn

chrome/browser/task_manager/ BUILD.gn
chrome/browser/task_manager/providers/ task.h
chrome/browser/task_manager/providers/vm/ plugin_vm_process_task.h
chrome/browser/task_manager/providers/vm/ plugin_vm_process_task.cc
chrome/browser/task_manager/providers/vm/ vm_process_task_provider.cc

chrome/browser/ui/ash/shelf/app_service/ DEPS

chrome/browser/ui/views/apps/app_dialog/ app_uninstall_dialog_view.cc

chrome/browser/ui/webui/ash/settings/pages/apps/ DEPS

chromeos/ash/components/audio/ cras_audio_handler.h

chromeos/ash/components/dbus/ BUILD.gn
chromeos/ash/components/dbus/debug_daemon/ debug_daemon_client.h
chromeos/ash/components/dbus/debug_daemon/ debug_daemon_client.cc
chromeos/ash/components/dbus/debug_daemon/ fake_debug_daemon_client.h
chromeos/ash/components/dbus/debug_daemon/ fake_debug_daemon_client.cc
chromeos/ash/experiences/settings_ui/ settings_app_manager.h

chromeos/ash/components/settings/ cros_settings_names.h

tools/metrics/histograms/metadata/chromeos/ enums.xml
```

Open in Gerrit

Related details

Attention is currently required from:

Ahmed Fakhry
Alexander Bolodurin
Kyle Horimoto

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ahmed Fakhry (Gerrit)

unread,

Jul 24, 2026, 12:42:37 PM (12 days ago) Jul 24

to Di Wu, Kyle Horimoto, SLSA Policy Verification Service, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Alexander Bolodurin, Di Wu and Kyle Horimoto

Ahmed Fakhry voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexander Bolodurin
Di Wu
Kyle Horimoto

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kyle Horimoto (Gerrit)

unread,

Jul 29, 2026, 11:18:16 AM (7 days ago) Jul 29

to Di Wu, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Alexander Bolodurin and Di Wu

Kyle Horimoto voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexander Bolodurin
Di Wu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 29, 2026, 9:21:55 PM (6 days ago) Jul 29

to John Admanski, Toni Barzic, Daniel Cheng, Sergey Poromov, Victor Gabriel Savu, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Alexander Bolodurin, Daniel Cheng, John Admanski, Sergey Poromov, Toni Barzic and Victor Gabriel Savu

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Di Wu . unresolved

Hi @tba...@chromium.org, need your help reviewing the following plain dead code remove code chunks. Thanks!

```
ash/constants/ notifier_catalogs.h

chrome/common/extensions/api/ autotest_private.webidl
extensions/browser/ extension_function_histogram_value.h
```

Hello @jadm...@chromium.org, need your help reviewing the following plain dead code removals. Thanks!

```
chrome/browser/ash/dbus/vm/ org.chromium.PluginVmService.conf
```

Hello @dch...@chromium.org, need your help reviewing the following plain dead code deletion chunks. Thanks!

```
components/services/app_service/public/protos/ app_types.proto
components/services/app_service/public/cpp/ app_types.h
```

Hello @por...@chromium.org, need your help reviewing the following dead code removals. Thanks!

```
ui/base/data_transfer_policy/ data_transfer_endpoint.h
components/enterprise/data_controls/core/browser/ component.h
```

Hi @vs...@google.com, need your help reviewing the following dead code removing changes. Thanks!

```
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmAllowed.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmDataCollectionAllowed.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmImage.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmRequiredFreeDiskSpace.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmUserId.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ UserPluginVmAllowed.yaml
components/policy/test/data/pref_mapping/ PluginVmAllowed.json
components/policy/test/data/pref_mapping/ PluginVmDataCollectionAllowed.json
components/policy/test/data/pref_mapping/ PluginVmImage.json
components/policy/test/data/pref_mapping/ PluginVmRequiredFreeDiskSpace.json
components/policy/test/data/pref_mapping/ PluginVmUserId.json
components/policy/test/data/pref_mapping/ UserPluginVmAllowed.json
```

Open in Gerrit

Related details

Attention is currently required from:

Alexander Bolodurin
Daniel Cheng
John Admanski
Sergey Poromov
Toni Barzic
Victor Gabriel Savu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 29, 2026, 9:31:01 PM (6 days ago) Jul 29

to John Admanski, Toni Barzic, Daniel Cheng, Sergey Poromov, Victor Gabriel Savu, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Daniel Cheng, John Admanski, Sergey Poromov, Toni Barzic and Victor Gabriel Savu

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Di Wu . unresolved

Hi @dch...@chromium.org, in addition to

```
components/services/app_service/public/protos/ app_types.proto
components/services/app_service/public/cpp/ app_types.h
```

I need your help reviewing the following mojom changes too. Thanks!

```
ui/webui/resources/cr_components/app_management/app_management.mojom
media/capture/video/chromeos/mojom/cros_camera_service.mojom
chrome/browser/ui/webui/ash/settings/search/mojom/search_result_icon.mojom
ash/webui/settings/public/constants/routes.mojom
```

Open in Gerrit

Related details

Attention is currently required from:

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jul 29, 2026, 9:40:22 PM (6 days ago) Jul 29

to Di Wu, Daniel Cheng, John Admanski, Toni Barzic, Sergey Poromov, Victor Gabriel Savu, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu, John Admanski, Sergey Poromov, Toni Barzic and Victor Gabriel Savu

Daniel Cheng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Di Wu

satisfied_requirement

unsatisfied_requirement

open

diffy

John Admanski (Gerrit)

unread,

Jul 29, 2026, 10:47:03 PM (6 days ago) Jul 29

to Di Wu, Daniel Cheng, Toni Barzic, Sergey Poromov, Victor Gabriel Savu, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu, Sergey Poromov, Toni Barzic and Victor Gabriel Savu

John Admanski voted and added 1 comment

Votes added by John Admanski

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Di Wu . unresolved

Hi @tba...@chromium.org, need your help reviewing the following plain dead code remove code chunks. Thanks!

John Admanski

I have no strong opinions about the removal as a whole but from an api-security-review perspective obviously removing the PluignVmService conf is fine.

Open in Gerrit

Related details

Attention is currently required from:

Di Wu

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Gabriel Savu (Gerrit)

unread,

Jul 30, 2026, 4:25:46 AM (6 days ago) Jul 30

to Di Wu, John Admanski, Daniel Cheng, Toni Barzic, Sergey Poromov, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu, Sergey Poromov and Toni Barzic

Victor Gabriel Savu added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Victor Gabriel Savu . resolved

My review doesn't seem to be required

Open in Gerrit

Related details

Attention is currently required from:

Di Wu
Sergey Poromov
Toni Barzic

satisfied_requirement

unsatisfied_requirement

open

diffy

Sergey Poromov (Gerrit)

unread,

Jul 30, 2026, 10:31:03 AM (6 days ago) Jul 30

to Di Wu, John Admanski, Daniel Cheng, Toni Barzic, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu and Toni Barzic

Sergey Poromov voted and added 1 comment

Votes added by Sergey Poromov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Sergey Poromov . resolved

lgtm for:
```
ui/base/data_transfer_policy/ data_transfer_endpoint.h
components/enterprise/data_controls/core/browser/ component.h
```

Open in Gerrit

Related details

Attention is currently required from:

Di Wu
Toni Barzic

satisfied_requirement

unsatisfied_requirement

open

diffy

Toni Barzic (Gerrit)

unread,

Jul 30, 2026, 9:41:12 PM (5 days ago) Jul 30

to Di Wu, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu

Toni Barzic voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Di Wu

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 30, 2026, 10:45:29 PM (5 days ago) Jul 30

to Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Thomas Lukaszewicz

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Di Wu . unresolved

Hi @tl...@chromium.org need your help take a look at one file only,

```
ui/views/bubble/bubble_dialog_delegate_view.h
```

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Lukaszewicz (Gerrit)

unread,

Jul 30, 2026, 10:56:08 PM (5 days ago) Jul 30

to Di Wu, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Thomas Lukaszewicz . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Di Wu

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 30, 2026, 11:11:27 PM (5 days ago) Jul 30

to Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Jimmy Gong

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Di Wu . unresolved

Hi @jimmy...@chromium.org, need your help review a single file. Thanks!

```
tools/metrics/histograms/metadata/ash/enums.xml
```

Open in Gerrit

Related details

Attention is currently required from:

Jimmy Gong

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 30, 2026, 11:27:21 PM (5 days ago) Jul 30

to Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Christian Dullweber and Jimmy Gong

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Di Wu . unresolved

Hi @dull...@chromium.org, need your help reviewing the following dead code clean-up changes. Thanks!

```
components/management_strings.grdp
components/management_strings_grdp/IDS_MANAGEMENT_REPORT_PLUGIN_VM.png.sha1
tools/traffic_annotation/summary/annotations.xml
tools/traffic_annotation/summary/grouping.xml
```

Open in Gerrit

Related details

Attention is currently required from:

Christian Dullweber
Jimmy Gong

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 31, 2026, 1:47:06 AM (5 days ago) Jul 31

to Kramer Ge, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Christian Dullweber, Jimmy Gong and Kramer Ge

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Di Wu . unresolved

Hi @fang...@chromium.org, need your help reviewing the following dead code removal changes. Thanks!

```
components/exo/README.md
components/exo/ui_lock_controller.h
components/exo/ui_lock_controller.cc
components/exo/ui_lock_controller_unittest.cc
```

Some context to bring you up to speed for the review.

The Cros feature Plugin VM is the only production user of `chromeos::kEscHoldToExitFullscreen`.
This property enables a large block in `components/exo/ui_lock_controller.cc` for holding escape key to exit fullscreen and showing the top-edge exit button.
The 10 deleted tests exclusively test that removed behavior.

Open in Gerrit

Related details

Attention is currently required from:

Christian Dullweber
Jimmy Gong
Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Jul 31, 2026, 1:48:20 AM (5 days ago) Jul 31

to Kramer Ge, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Christian Dullweber, Jimmy Gong and Kramer Ge

Di Wu added 7 comments

Patchset-level comments

File-level comment, Patchset 12:

Di Wu . resolved

Di Wu

Done

File-level comment, Patchset 14:

Di Wu . resolved

Di Wu

Done

File-level comment, Patchset 14:

Di Wu . resolved

Hi @afa...@chromium.org, this is a dumb mechanical clean up of the now deprecated Plugin VM feature. Need your help reviewing the following code revomals. Many thanks!

Di Wu

Done

File-level comment, Patchset 15 (Latest):

Di Wu . resolved

Hi @tl...@chromium.org need your help take a look at one file only,
```
ui/views/bubble/bubble_dialog_delegate_view.h
```
Thanks!

Di Wu

Done

File-level comment, Patchset 15 (Latest):

Di Wu . resolved

Di Wu

Done

File-level comment, Patchset 15 (Latest):

Di Wu . resolved

Hi @dch...@chromium.org, in addition to
```
components/services/app_service/public/protos/ app_types.proto
components/services/app_service/public/cpp/ app_types.h
```
I need your help reviewing the following mojom changes too. Thanks!
```
ui/webui/resources/cr_components/app_management/app_management.mojom
media/capture/video/chromeos/mojom/cros_camera_service.mojom
chrome/browser/ui/webui/ash/settings/search/mojom/search_result_icon.mojom
ash/webui/settings/public/constants/routes.mojom
```

Di Wu

Done

File chrome/browser/ash/guest_os/guest_os_share_path_unittest.cc

Line 45, Patchset 13:#include "chromeos/ash/components/install_attributes/stub_install_attributes.h"

Di Wu . resolved

introduced due to rebase

Di Wu

Done

satisfied_requirement

unsatisfied_requirement

open

diffy

Christian Dullweber (Gerrit)

unread,

Jul 31, 2026, 4:58:38 AM (5 days ago) Jul 31

to Di Wu, Kramer Ge, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu, Jimmy Gong and Kramer Ge

Christian Dullweber voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Di Wu
Jimmy Gong
Kramer Ge

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Jul 31, 2026, 12:46:32 PM (5 days ago) Jul 31

to Di Wu, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, SLSA Policy Verification Service, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu and Jimmy Gong

Kramer Ge voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Di Wu
Jimmy Gong

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Aug 4, 2026, 3:23:10 AM (yesterday) Aug 4

to Takashi Toyoshima, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Jimmy Gong and Takashi Toyoshima

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @toyo...@chromium.org, need your help reviewing the following files, many thanks!

```
tools/metrics/histograms/metadata/extensions/ enums.xml
```

Open in Gerrit

Related details

Attention is currently required from:

Jimmy Gong
Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Aug 4, 2026, 3:25:56 AM (yesterday) Aug 4

to Ryan Sultanem, Takashi Toyoshima, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Jimmy Gong, Ryan Sultanem and Takashi Toyoshima

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @rs...@google.com, need your help reviewing the following file, thanks a lot!

```
tools/metrics/histograms/metadata/signin/ enums.xml
```

Open in Gerrit

Related details

Attention is currently required from:

Jimmy Gong
Ryan Sultanem
Takashi Toyoshima

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Aug 4, 2026, 3:32:09 AM (yesterday) Aug 4

to Ramin Halavati, Ryan Sultanem, Takashi Toyoshima, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Jimmy Gong, Ramin Halavati, Ryan Sultanem and Takashi Toyoshima

Di Wu added 2 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @rhal...@chromium.org, need your help reviewing the following file, thanks!

```
tools/traffic_annotation/ safe_list.txt
```

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @rs...@google.com, need your help reviewing the following file, thanks a lot!
```
tools/metrics/histograms/metadata/signin/ enums.xml
```

Di Wu

Hi @rs...@google.com, in addition to

```
tools/metrics/histograms/metadata/signin/ enums.xml
```

Can you also review the following file, thanks!

```
components/signin/public/base/oauth_consumer_id.h
```

Open in Gerrit

Related details

Attention is currently required from:

Jimmy Gong
Ramin Halavati
Ryan Sultanem
Takashi Toyoshima

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Aug 4, 2026, 3:35:37 AM (yesterday) Aug 4

to Caitlin Fischer, Ramin Halavati, Ryan Sultanem, Takashi Toyoshima, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Jimmy Gong, Ramin Halavati, Ryan Sultanem and Takashi Toyoshima

Di Wu added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @caitlin...@google.com, can you help reviewing the following files, thanks!

```
components/metrics/net/ net_metrics_log_uploader.cc
```

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer

Jimmy Gong
Ramin Halavati
Ryan Sultanem
Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Aug 4, 2026, 3:42:00 AM (yesterday) Aug 4

to Min Qin, Caitlin Fischer, Ramin Halavati, Ryan Sultanem, Takashi Toyoshima, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Jimmy Gong, Min Qin, Ramin Halavati, Ryan Sultanem and Takashi Toyoshima

Di Wu added 2 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @caitlin...@google.com, can you help reviewing the following files, thanks!
```
components/metrics/net/ net_metrics_log_uploader.cc
```

Di Wu

Hi @caitlin...@google.com, if you can help reviewing the following additional files, that would be very helpful too, thanks!

```
tools/metrics/histograms/metadata/ash/enums.xml
tools/metrics/histograms/metadata/extensions/enums.xml
tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS
tools/metrics/histograms/metadata/signin/enums.xml
```

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @qin...@chromium.org, need your help reviewing the following files, thanks!

```
components/download/internal/background_service/proto/ entry.proto
components/download/public/background_service/ clients.h
```

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer
Jimmy Gong
Min Qin

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

Aug 4, 2026, 3:42:57 AM (yesterday) Aug 4

to Min Qin, Caitlin Fischer, Ramin Halavati, Ryan Sultanem, Takashi Toyoshima, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Jimmy Gong, Min Qin, Ramin Halavati, Ryan Sultanem and Takashi Toyoshima

Di Wu added 2 comments

Patchset-level comments

File-level comment, Patchset 15:

Di Wu . resolved

Hi @dull...@chromium.org, need your help reviewing the following dead code clean-up changes. Thanks!
```
components/management_strings.grdp
components/management_strings_grdp/IDS_MANAGEMENT_REPORT_PLUGIN_VM.png.sha1
tools/traffic_annotation/summary/annotations.xml
tools/traffic_annotation/summary/grouping.xml
```

Di Wu

Done

File-level comment, Patchset 15:

Di Wu . resolved

Hi @fang...@chromium.org, need your help reviewing the following dead code removal changes. Thanks!

```
components/exo/README.md
components/exo/ui_lock_controller.h
components/exo/ui_lock_controller.cc
components/exo/ui_lock_controller_unittest.cc
```
Some context to bring you up to speed for the review.
The Cros feature Plugin VM is the only production user of `chromeos::kEscHoldToExitFullscreen`.
This property enables a large block in `components/exo/ui_lock_controller.cc` for holding escape key to exit fullscreen and showing the top-edge exit button.
The 10 deleted tests exclusively test that removed behavior.

Di Wu

Done

satisfied_requirement

unsatisfied_requirement

open

diffy

Takashi Toyoshima (Gerrit)

unread,

Aug 4, 2026, 3:50:14 AM (yesterday) Aug 4

to Di Wu, Min Qin, Caitlin Fischer, Ramin Halavati, Ryan Sultanem, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Di Wu, Jimmy Gong, Min Qin, Ramin Halavati and Ryan Sultanem

Takashi Toyoshima voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer
Di Wu

Jimmy Gong
Min Qin
Ramin Halavati
Ryan Sultanem

satisfied_requirement

unsatisfied_requirement

open

diffy

Ramin Halavati (Gerrit)

unread,

Aug 4, 2026, 4:20:12 AM (yesterday) Aug 4

to Di Wu, Takashi Toyoshima, Min Qin, Caitlin Fischer, Ramin Halavati, Ryan Sultanem, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Di Wu, Jimmy Gong, Min Qin and Ryan Sultanem

Ramin Halavati added 2 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Ramin Halavati . resolved

Do I own any file here?

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @rhal...@chromium.org, need your help reviewing the following file, thanks!
```
tools/traffic_annotation/ safe_list.txt
```

Ramin Halavati

I don't see any change in tools/traffic_annotation.

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer
Di Wu
Jimmy Gong
Min Qin

Ryan Sultanem

satisfied_requirement

unsatisfied_requirement

open

diffy

Sergey Poromov (Gerrit)

unread,

Aug 4, 2026, 4:24:10 AM (yesterday) Aug 4

to Di Wu, Takashi Toyoshima, Min Qin, Caitlin Fischer, Ramin Halavati, Ryan Sultanem, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Di Wu, Jimmy Gong, Min Qin and Ryan Sultanem

Sergey Poromov voted and added 1 comment

Votes added by Sergey Poromov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Di Wu . unresolved

Hi @rhal...@chromium.org, need your help reviewing the following file, thanks!
```
tools/traffic_annotation/ safe_list.txt
```

Ramin Halavati

I don't see any change in tools/traffic_annotation.

Sergey Poromov

https://crrev.com/c/8086815/17/tools/traffic_annotation/safe_list.txt

satisfied_requirement

unsatisfied_requirement

open

diffy

Ramin Halavati (Gerrit)

unread,

Aug 4, 2026, 4:26:50 AM (yesterday) Aug 4

to Di Wu, Ramin Halavati, Takashi Toyoshima, Min Qin, Caitlin Fischer, Ryan Sultanem, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Di Wu, Jimmy Gong, Min Qin and Ryan Sultanem

Ramin Halavati voted and added 2 comments

Votes added by Ramin Halavati

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Ramin Halavati . resolved

traffic_annotation/* LGTM

File-level comment, Patchset 17 (Latest):

Di Wu . resolved

Hi @rhal...@chromium.org, need your help reviewing the following file, thanks!
```
tools/traffic_annotation/ safe_list.txt
```

Ramin Halavati

I don't see any change in tools/traffic_annotation.

Sergey Poromov

https://crrev.com/c/8086815/17/tools/traffic_annotation/safe_list.txt

Ramin Halavati

Thanks, didn't see the additional 200+ files.

satisfied_requirement

unsatisfied_requirement

open

diffy

Sergey Poromov (Gerrit)

unread,

Aug 4, 2026, 4:29:56 AM (yesterday) Aug 4

to Victor Gabriel Savu, Ramin Halavati, Takashi Toyoshima, Min Qin, Caitlin Fischer, Ryan Sultanem, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Jimmy Gong, Min Qin, Ryan Sultanem and Victor Gabriel Savu

Sergey Poromov added 3 comments

Patchset-level comments

File-level comment, Patchset 15:

Victor Gabriel Savu . resolved

My review doesn't seem to be required

Sergey Poromov

In a comment above you were added for the following files:

```
Hi
Victor Gabriel Savu

, need your help reviewing the following dead code removing changes. Thanks!

components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmAllowed.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmDataCollectionAllowed.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmImage.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmRequiredFreeDiskSpace.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ PluginVmUserId.yaml
components/policy/resources/templates/policy_definitions/PluginVm/ UserPluginVmAllowed.yaml
components/policy/test/data/pref_mapping/ PluginVmAllowed.json
components/policy/test/data/pref_mapping/ PluginVmDataCollectionAllowed.json
components/policy/test/data/pref_mapping/ PluginVmImage.json
components/policy/test/data/pref_mapping/ PluginVmRequiredFreeDiskSpace.json
components/policy/test/data/pref_mapping/ PluginVmUserId.json
components/policy/test/data/pref_mapping/ UserPluginVmAllowed.json
```

However, it seems that my ownership covered them too, but I need to re-review them then.

File components/policy/resources/templates/policy_definitions/PluginVm/PluginVmAllowed.yaml

Line 1, Patchset 17 (Latest):caption: Allow devices to use a <ph name="PLUGIN_VM_NAME">PluginVm</ph> on <ph name="PRODUCT_OS_NAME">$2<ex>Google

Sergey Poromov . unresolved

Just realized that I accidentally approved these files in components/policy too, while in the comment they were assigned to @vs...@google.com, so taking another look.

Line 24, Patchset 17 (Latest):- chrome_os:72-151

Sergey Poromov . unresolved

IIUC it should be 152 (as we are past branch). And in the following `/policy_definitions/` files.

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer

Jimmy Gong
Min Qin
Ryan Sultanem

Victor Gabriel Savu

satisfied_requirement

unsatisfied_requirement

open

diffy

Ryan Sultanem (Gerrit)

unread,

Aug 4, 2026, 6:46:57 AM (yesterday) Aug 4

to Di Wu, Victor Gabriel Savu, Ramin Halavati, Takashi Toyoshima, Min Qin, Caitlin Fischer, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Di Wu, Jimmy Gong, Min Qin and Victor Gabriel Savu

Ryan Sultanem added 2 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Di Wu . resolved

Hi @rs...@google.com, need your help reviewing the following file, thanks a lot!
```
tools/metrics/histograms/metadata/signin/ enums.xml
```

Di Wu

Hi @rs...@google.com, in addition to
```
tools/metrics/histograms/metadata/signin/ enums.xml
```
Can you also review the following file, thanks!
```
components/signin/public/base/oauth_consumer_id.h
```

Ryan Sultanem

LGTM for both % small nit.

File components/signin/public/base/oauth_consumer_id.h

Line 87, Patchset 17 (Latest): kPluginVmLicenseChecker = 58, // Deprecated. Do not reuse.

Ryan Sultanem . unresolved

nit: Can you please comment out the line? So that you ensure that the value is not used anymore. You can keep the name, similar to what is done above in `kLauncherItemSuggest = 12` Line 40.

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer

Di Wu
Jimmy Gong
Min Qin

Victor Gabriel Savu

satisfied_requirement

unsatisfied_requirement

open

diffy

Ryan Sultanem (Gerrit)

unread,

Aug 4, 2026, 6:49:50 AM (yesterday) Aug 4

to Di Wu, Victor Gabriel Savu, Ramin Halavati, Takashi Toyoshima, Min Qin, Caitlin Fischer, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Di Wu, Jimmy Gong, Min Qin and Victor Gabriel Savu

Ryan Sultanem voted Code-Review+1

Code-Review

+1

satisfied_requirement

unsatisfied_requirement

open

diffy

Min Qin (Gerrit)

unread,

Aug 4, 2026, 12:23:44 PM (19 hours ago) Aug 4

to Di Wu, Ryan Sultanem, Victor Gabriel Savu, Ramin Halavati, Takashi Toyoshima, Caitlin Fischer, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer, Di Wu, Jimmy Gong and Victor Gabriel Savu

Min Qin voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer
Di Wu
Jimmy Gong

Victor Gabriel Savu

satisfied_requirement

unsatisfied_requirement

open

diffy

Caitlin Fischer (Gerrit)

unread,

Aug 4, 2026, 12:59:55 PM (18 hours ago) Aug 4

to Di Wu, Min Qin, Ryan Sultanem, Victor Gabriel Savu, Ramin Halavati, Takashi Toyoshima, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu, Jimmy Gong and Victor Gabriel Savu

Caitlin Fischer voted Code-Review+0

Code-Review

+0

Open in Gerrit

Related details

Attention is currently required from:

satisfied_requirement

unsatisfied_requirement

open

diffy

Caitlin Fischer (Gerrit)

unread,

Aug 4, 2026, 12:59:58 PM (18 hours ago) Aug 4

to Di Wu, Min Qin, Ryan Sultanem, Victor Gabriel Savu, Ramin Halavati, Takashi Toyoshima, SLSA Policy Verification Service, Christian Dullweber, Jimmy Gong, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu, Jimmy Gong and Victor Gabriel Savu

Caitlin Fischer voted and added 1 comment

Votes added by Caitlin Fischer

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Di Wu . resolved

Hi @caitlin...@google.com, can you help reviewing the following files, thanks!
```
components/metrics/net/ net_metrics_log_uploader.cc
```

Di Wu

Hi @caitlin...@google.com, if you can help reviewing the following additional files, that would be very helpful too, thanks!
```
tools/metrics/histograms/metadata/ash/enums.xml
tools/metrics/histograms/metadata/extensions/enums.xml
tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS
tools/metrics/histograms/metadata/signin/enums.xml
```

Caitlin Fischer

lgtm

satisfied_requirement

unsatisfied_requirement

open

diffy

Jimmy Gong (Gerrit)

unread,

2:31 AM (5 hours ago) 2:31 AM

to Di Wu, SLSA Policy Verification Service, Caitlin Fischer, Min Qin, Ryan Sultanem, Victor Gabriel Savu, Ramin Halavati, Takashi Toyoshima, Christian Dullweber, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Di Wu and Victor Gabriel Savu

Jimmy Gong voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Di Wu
Victor Gabriel Savu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Di Wu (Gerrit)

unread,

2:51 AM (5 hours ago) 2:51 AM

to Jimmy Gong, SLSA Policy Verification Service, Caitlin Fischer, Min Qin, Ryan Sultanem, Victor Gabriel Savu, Ramin Halavati, Takashi Toyoshima, Christian Dullweber, Thomas Lukaszewicz, Toni Barzic, Sergey Poromov, John Admanski, Daniel Cheng, Kyle Horimoto, Ahmed Fakhry, Alexander Bolodurin, Alexander Bolodurin, Timothy Loh, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Enterprise Policy Reviews, Rijubrata Bhaumik, asvitki...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crmulli...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-report...@google.com, cros-reporti...@google.com, cros-setti...@google.com, crostin...@chromium.org, crost...@chromium.org, dmurph+wat...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ffred...@chromium.org, filesapp...@chromium.org, hashimo...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, jorgel...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, net-r...@chromium.org, nicolas...@chromium.org, odejesu...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, ramyagopa...@google.com, rginda...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, srahim...@chromium.org, tbarzi...@chromium.org, tluk+...@chromium.org, vshenv...@google.com, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Caitlin Fischer

Di Wu added 8 comments

Patchset-level comments

File-level comment, Patchset 15:

Di Wu . resolved

Hi @jimmy...@chromium.org, need your help review a single file. Thanks!
```
tools/metrics/histograms/metadata/ash/enums.xml
```

Di Wu

Done

File-level comment, Patchset 17:

Di Wu . resolved

Hi @rhal...@chromium.org, need your help reviewing the following file, thanks!
```
tools/traffic_annotation/ safe_list.txt
```

Ramin Halavati

I don't see any change in tools/traffic_annotation.

Sergey Poromov

https://crrev.com/c/8086815/17/tools/traffic_annotation/safe_list.txt

Ramin Halavati

Thanks, didn't see the additional 200+ files.

Di Wu

Thank you both!

File-level comment, Patchset 17:

Di Wu . resolved

Hi @toyo...@chromium.org, need your help reviewing the following files, many thanks!
```
tools/metrics/histograms/metadata/extensions/ enums.xml
```

Di Wu

Done

File-level comment, Patchset 17:

Di Wu . resolved

Hi @qin...@chromium.org, need your help reviewing the following files, thanks!
```
components/download/internal/background_service/proto/ entry.proto
components/download/public/background_service/ clients.h
```

Di Wu

Done

File-level comment, Patchset 18 (Latest):

Di Wu . unresolved

Hi @caitlin...@google.com, need your help again CR+1 the following files. Your +1 was reset yesterday for some reason. A piece of good news is that the transient CQ error is gone. Someone fixed the complaining `tools/traffic_annotation/summary/annotations.xml` and by merely rebasing, my latest patchset is now CQ-green again. Thanks!

```
components/metrics/net/net_metrics_log_uploader.cc
tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS
```

File components/policy/resources/templates/policy_definitions/PluginVm/PluginVmAllowed.yaml

Line 1, Patchset 17:caption: Allow devices to use a <ph name="PLUGIN_VM_NAME">PluginVm</ph> on <ph name="PRODUCT_OS_NAME">$2<ex>Google

Sergey Poromov . resolved

Just realized that I accidentally approved these files in components/policy too, while in the comment they were assigned to @vs...@google.com, so taking another look.

Di Wu

Done

Line 24, Patchset 17:- chrome_os:72-151

Sergey Poromov . resolved

IIUC it should be 152 (as we are past branch). And in the following `/policy_definitions/` files.

Di Wu

This is very sharp finding! I'll draft a follow-up as soon as this one lands. Keeping this one as-is to avoid any CR+1 get out-voted. Thanks!

File components/signin/public/base/oauth_consumer_id.h

Line 87, Patchset 17: kPluginVmLicenseChecker = 58, // Deprecated. Do not reuse.

Ryan Sultanem . resolved

nit: Can you please comment out the line? So that you ensure that the value is not used anymore. You can keep the name, similar to what is done above in `kLauncherItemSuggest = 12` Line 40.

Di Wu

Thanks for the spotting this one! I'll draft a follow-up as soon as this one lands. Keeping this one as-is to avoid any CR+1 get out-voted. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Ash: Remove Plugin VM [chromium/src : main]

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Timothy Loh (Gerrit)

Timothy Loh voted and added 3 comments

Votes added by Timothy Loh

3 comments

Related details

Di Wu (Gerrit)

Di Wu added 2 comments

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Timothy Loh (Gerrit)

Timothy Loh voted Code-Review+1

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Alexander Bolodurin (Gerrit)

Alexander Bolodurin voted Code-Review+1

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Ahmed Fakhry (Gerrit)

Ahmed Fakhry voted Code-Review+1

Related details

Kyle Horimoto (Gerrit)

Kyle Horimoto voted Code-Review+1

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted Code-Review+1

Related details

John Admanski (Gerrit)

John Admanski voted and added 1 comment

Votes added by John Admanski

1 comment

Related details

Victor Gabriel Savu (Gerrit)

Victor Gabriel Savu added 1 comment

Related details

Sergey Poromov (Gerrit)

Sergey Poromov voted and added 1 comment

Votes added by Sergey Poromov

1 comment

Related details

Toni Barzic (Gerrit)

Toni Barzic voted Code-Review+1

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Thomas Lukaszewicz (Gerrit)

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

1 comment

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details

Di Wu (Gerrit)

Di Wu added 1 comment

Related details