ash: Remove magic_boost crosapi [chromium/src : main]

0 views

Skip to first unread message

Georg Neis (Gerrit)

unread,

Dec 25, 2025, 1:00:39 AM (3 days ago) Dec 25

to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, feature-me...@chromium.org, ffred...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, tluk+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Attention needed from Hidehiko Abe

Georg Neis voted and added 3 comments

Votes added by Georg Neis

Commit-Queue

3 comments

File ash/system/magic_boost/magic_boost_constants.h

Line 30, Patchset 4:

Georg Neis . unresolved

I found that there's also chrome/browser/ui/ash/magic_boost/magic_boost_constants.h which defines namespace chromeos::magic_boost.

How about merging them, or at least stick to a single namespace, in a followup CL?

File chrome/browser/ash/magic_boost/magic_boost_controller_ash.h

Line 54, Patchset 1: views::Widget* disclaimer_widget_for_test() {

Georg Neis . unresolved

In a followup-CL I'll want to make this private or delete it or remove the MagicBoostControllerAshTest friend declaration.

Line 37, Patchset 1:class MagicBoostControllerAsh {

Georg Neis . unresolved

In a followup-CL I want to drop the Ash suffix from the name.

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

Dec 26, 2025, 2:21:30 AM (yesterday) Dec 26

to Georg Neis, Chromium LUCI CQ, chromium...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, feature-me...@chromium.org, ffred...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shuche...@chromium.org, tluk+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

Attention needed from Georg Neis

Hidehiko Abe added 4 comments

File ash/system/magic_boost/magic_boost_constants.h

Line 30, Patchset 4:

Georg Neis . unresolved

I found that there's also chrome/browser/ui/ash/magic_boost/magic_boost_constants.h which defines namespace chromeos::magic_boost.
How about merging them, or at least stick to a single namespace, in a followup CL?

Hidehiko Abe

sgtm

File chrome/browser/ash/magic_boost/magic_boost_controller_ash.h

Line 54, Patchset 1: views::Widget* disclaimer_widget_for_test() {

Georg Neis . resolved

In a followup-CL I'll want to make this private or delete it or remove the MagicBoostControllerAshTest friend declaration.

Hidehiko Abe

Acknowledged

Line 37, Patchset 1:class MagicBoostControllerAsh {

Georg Neis . resolved

In a followup-CL I want to drop the Ash suffix from the name.

Hidehiko Abe

Acknowledged

File chrome/browser/ui/ash/magic_boost/test/mock_magic_boost_controller.h

Line 13, Patchset 6 (Latest):class MockMagicBoostController : public ash::MagicBoostControllerAsh {

Hidehiko Abe . unresolved

inheriting concrete class for Mock often has problematic behavior.
Can we keep separating interface and concrete class?

Open in Gerrit

Related details

Attention is currently required from:

Georg Neis

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages