Split text and image test cases in insert media request unit test [chromium/src : main]
0 views
Skip to first unread message
Michael Cui (Gerrit)
Jul 4, 2024, 1:46:51 AMJul 4
to Michael Cui, Darren Shen, AyeAye, feature-me...@chromium.org
Attention needed from Darren Shen
Michael Cui voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Darren Shen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darren Shen (Gerrit)
Jul 4, 2024, 6:49:29 PMJul 4
to Michael Cui, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org
Attention needed from Michael Cui
Darren Shen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darren Shen
| Code-Review | +1 |
1 comment
File ash/picker/picker_insert_media_request_unittest.cc
Line 169, Patchset 3 (Latest):
const TestCaseCallback kTextTestCases[] = {Darren Shen . unresolved
can these be constexpr?
Related details
Attention is currently required from:
- Michael Cui
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Cui (Gerrit)
Jul 7, 2024, 9:48:57 PMJul 7
to Michael Cui, Darren Shen, Chromium LUCI CQ, AyeAye, feature-me...@chromium.org
Michael Cui added 1 comment![]( "Open in Gerrit")
File ash/picker/picker_insert_media_request_unittest.cc
Line 169, Patchset 3:
const TestCaseCallback kTextTestCases[] = {Darren Shen . resolved
Michael Cuican these be constexpr?
Unfortunately not:
Constexpr function's return type 'TestCaseCallback' (aka 'RepeatingCallback<std::unique_ptr<TestCase> ()>') is not a literal
'RepeatingCallback<std::unique_ptr<ash::(anonymous namespace)::TestCase> ()>' is not literal because it has data member 'holder_' of non-literal type 'internal::BindStateHolder'
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 7, 2024, 10:18:09 PMJul 7
to Michael Cui, Darren Shen, AyeAye, feature-me...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Split text and image test cases in insert media request unit test
This will allow to parameterise the "unsupported image" tests in a
future CL.
Bug: None
Change-Id: I6a6a2100c846332f6121c6b3eeaa514b22a7fc4d
Commit-Queue: Michael Cui <ml...@google.com>
Reviewed-by: Darren Shen <sh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1324003}
Files:
- M ash/picker/picker_insert_media_request_unittest.cc
Change size: M
Delta: 1 file changed, 38 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darren Shen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages