Remove TODO from `GetApplicationAudioCaptureIdForProcess` [chromium/src : main]

0 views
Skip to first unread message

Olga Sharonova (Gerrit)

unread,
5:08 AM (5 hours ago) 5:08 AM
to Olov Brändström, Tove Petersson, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Olov Brändström and Tove Petersson

Olga Sharonova voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Olov Brändström
  • Tove Petersson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95e8817e766190fea7940d0328ea4a8d3ecb6bb3
Gerrit-Change-Number: 7843055
Gerrit-PatchSet: 3
Gerrit-Owner: Olov Brändström <brand...@chromium.org>
Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
Gerrit-Reviewer: Tove Petersson <to...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Olov Brändström <brand...@chromium.org>
Gerrit-Attention: Tove Petersson <to...@chromium.org>
Gerrit-Comment-Date: Mon, 18 May 2026 09:08:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tove Petersson (Gerrit)

unread,
5:55 AM (4 hours ago) 5:55 AM
to Olov Brändström, Olga Sharonova, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Olov Brändström

Tove Petersson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Olov Brändström
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I95e8817e766190fea7940d0328ea4a8d3ecb6bb3
    Gerrit-Change-Number: 7843055
    Gerrit-PatchSet: 3
    Gerrit-Owner: Olov Brändström <brand...@chromium.org>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Tove Petersson <to...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Olov Brändström <brand...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 May 2026 09:54:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Olov Brändström (Gerrit)

    unread,
    6:43 AM (4 hours ago) 6:43 AM
    to Tove Petersson, Olga Sharonova, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org

    Olov Brändström voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I95e8817e766190fea7940d0328ea4a8d3ecb6bb3
    Gerrit-Change-Number: 7843055
    Gerrit-PatchSet: 3
    Gerrit-Owner: Olov Brändström <brand...@chromium.org>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Olov Brändström <brand...@chromium.org>
    Gerrit-Reviewer: Tove Petersson <to...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Comment-Date: Mon, 18 May 2026 10:43:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    7:11 AM (3 hours ago) 7:11 AM
    to Olov Brändström, Tove Petersson, Olga Sharonova, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove TODO from `GetApplicationAudioCaptureIdForProcess`

    RTC logs where added in
    https://crrev.com/c/7837560

    UMA diagrams where added in
    https://crrev.com/c/7810900
    Bug: 507803904
    Change-Id: I95e8817e766190fea7940d0328ea4a8d3ecb6bb3
    Reviewed-by: Olga Sharonova <ol...@chromium.org>
    Reviewed-by: Tove Petersson <to...@chromium.org>
    Commit-Queue: Olov Brändström <brand...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1632071}
    Files:
    • M content/browser/media/capture/desktop_capture_util_mac.h
    Change size: XS
    Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Olga Sharonova, +1 by Tove Petersson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I95e8817e766190fea7940d0328ea4a8d3ecb6bb3
    Gerrit-Change-Number: 7843055
    Gerrit-PatchSet: 4
    Gerrit-Owner: Olov Brändström <brand...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages