[ios] Cleanup usages of SceneController API [chromium/src : main]
0 views
Skip to first unread message
Sylvain Defresne (Gerrit)
Aug 3, 2026, 5:52:39 AM (2 days ago) Aug 3
to Federica Germinario, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, eic+...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Federica Germinario
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Federica Germinario
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Federica Germinario (Gerrit)
Aug 3, 2026, 6:21:43 AM (2 days ago) Aug 3
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, eic+...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne
Federica Germinario voted and added 1 comment![]( "Open in Gerrit")
Votes added by Federica Germinario
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
6:06 AM (1 hour ago) 6:06 AM
to Federica Germinario, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, eic+...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Sylvain Defresne voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:59 AM (24 minutes ago) 6:59 AM
to Sylvain Defresne, Federica Germinario, chromium...@chromium.org, Enterprise Policy Reviews, eic+...@google.com, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[ios] Cleanup usages of SceneController API
Ensure scene_controller_testing.h is imported by scene_controller.mm
in order for the compiler to complain about API mismatch and delete
the declaration of -presentSignInAccountsViewControllerIfNecessary
which is not implemented (hopefully it is never called).
Remove unused imports of scene_controller.h header.
Bug: none
Change-Id: I9d81da1f88b7b7a2d823a26c1885ad553225a576
Reviewed-by: Federica Germinario <fede...@google.com>
Commit-Queue: Sylvain Defresne <sdef...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1674024}
Files:
- M ios/chrome/app/main_application_delegate.mm
- M ios/chrome/app/profile/identity_confirmation_profile_agent.mm
- M ios/chrome/app/profile/synced_set_up_profile_agent.mm
- M ios/chrome/app/tab_opener_unittest.mm
- M ios/chrome/browser/authentication/test/signin_earl_grey_app_interface.h
- M ios/chrome/browser/authentication/test/signin_earl_grey_app_interface.mm
- M ios/chrome/browser/authentication/ui_bundled/authentication_flow/authentication_flow_in_profile_performer.mm
- M ios/chrome/browser/authentication/ui_bundled/authentication_flow/authentication_flow_performer.mm
- M ios/chrome/browser/authentication/ui_bundled/authentication_flow/authentication_flow_performer_base.mm
- M ios/chrome/browser/authentication/ui_bundled/change_profile/change_profile_authentication_continuation.mm
- M ios/chrome/browser/policy/ui_bundled/signin_policy_scene_agent.mm
- M ios/chrome/browser/shared/coordinator/scene/BUILD.gn
- M ios/chrome/browser/shared/coordinator/scene/scene_controller.mm
- M ios/chrome/browser/shared/coordinator/scene/scene_controller_testing.h
- M ios/chrome/browser/tab_switcher/tab_grid/base_grid/coordinator/base_grid_mediator.mm
- M ios/chrome/test/app/chrome_test_util.mm
- M ios/chrome/test/app/tab_test_util.mm
Change size: S
Delta: 17 files changed, 8 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Federica Germinario
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages