Erik Chen (Gerrit)

unread,

May 13, 2026, 4:04:21 PM (5 days ago) May 13

to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Chromium LUCI CQ, eme-r...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Thomas Lukaszewicz

Erik Chen added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Erik Chen . unresolved

still running through mega-CQ to make sure there aren't issues

Open in Gerrit

Related details

Attention is currently required from:

Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Lukaszewicz (Gerrit)

unread,

May 13, 2026, 5:51:48 PM (5 days ago) May 13

to Erik Chen, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Chromium LUCI CQ, eme-r...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Erik Chen

Thomas Lukaszewicz voted and added 4 comments

Votes added by Thomas Lukaszewicz

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Thomas Lukaszewicz . resolved

lgtm

File chrome/browser/BUILD.gn

Line 399, Patchset 5 (Latest):source_set("certificate_viewer") {

Thomas Lukaszewicz . unresolved

nit: This was `!is_android` previously, should we move it into the corresponding block below?

Line 473, Patchset 5 (Latest):

source_set("fullscreen") {
  public = [ "fullscreen.h" ]
}

Thomas Lukaszewicz . unresolved

nit: Similarly this was previously only included for `!is_chromeos`, so perhaps we should move it to a corresponding block below

Line 572, Patchset 5 (Latest): source_set("chrome_process_singleton") {

Thomas Lukaszewicz . unresolved

nit: Could we merge this into the `!is_android` block above?

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

May 15, 2026, 12:55:28 PM (3 days ago) May 15

to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Chromium LUCI CQ, eme-r...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Thomas Lukaszewicz

Erik Chen voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

May 15, 2026, 2:13:44 PM (3 days ago) May 15

to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Chromium LUCI CQ, eme-r...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Thomas Lukaszewicz

Erik Chen voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Lukaszewicz (Gerrit)

unread,

May 17, 2026, 2:39:47 PM (19 hours ago) May 17

to Erik Chen, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Chromium LUCI CQ, eme-r...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Erik Chen

Thomas Lukaszewicz voted and added 6 comments

Votes added by Thomas Lukaszewicz

Code-Review

+1

6 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Thomas Lukaszewicz . resolved

still lgtm % nits

File chrome/browser/BUILD.gn

Line 399, Patchset 5:source_set("certificate_viewer") {

Thomas Lukaszewicz . resolved

nit: This was `!is_android` previously, should we move it into the corresponding block below?

Thomas Lukaszewicz

Done

Line 473, Patchset 5:

source_set("fullscreen") {
  public = [ "fullscreen.h" ]
}

Thomas Lukaszewicz . resolved

nit: Similarly this was previously only included for `!is_chromeos`, so perhaps we should move it to a corresponding block below

Thomas Lukaszewicz

Done

Line 572, Patchset 5: source_set("chrome_process_singleton") {

Thomas Lukaszewicz . resolved

nit: Could we merge this into the `!is_android` block above?

Thomas Lukaszewicz

Done

File chrome/browser/safe_browsing/BUILD.gn

Line 309, Patchset 8 (Latest):

    if (!is_chromeos && !is_android) {
      deps += [ "//chrome/browser/download/bubble" ]
    }

Thomas Lukaszewicz . unresolved

nit: We should be able to remove this (it looks like we have 
```
      if (!is_android && !is_chromeos) {
        deps += [ "//chrome/browser/download/bubble" ]
      }
```
below at like 581

File chrome/browser/sessions/BUILD.gn

Line 133, Patchset 8 (Latest):


    if (is_mac) {
      deps += [ "//chrome/browser:app_controller_mac" ]
    }

Thomas Lukaszewicz . unresolved

nit: Could we move this `deps` block below to where we list the other conditional deps?

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

May 17, 2026, 9:20:04 PM (12 hours ago) May 17

to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Chromium LUCI CQ, eme-r...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Erik Chen added 5 comments

File chrome/browser/BUILD.gn

Line 399, Patchset 5:source_set("certificate_viewer") {

Thomas Lukaszewicz . resolved

nit: This was `!is_android` previously, should we move it into the corresponding block below?

Erik Chen

Done

Line 473, Patchset 5:

source_set("fullscreen") {
  public = [ "fullscreen.h" ]
}

Thomas Lukaszewicz . resolved

nit: Similarly this was previously only included for `!is_chromeos`, so perhaps we should move it to a corresponding block below

Erik Chen

Done

Line 572, Patchset 5: source_set("chrome_process_singleton") {

Thomas Lukaszewicz . resolved

nit: Could we merge this into the `!is_android` block above?

Erik Chen

Done

File chrome/browser/safe_browsing/BUILD.gn

Line 309, Patchset 8:

    if (!is_chromeos && !is_android) {
      deps += [ "//chrome/browser/download/bubble" ]
    }

Thomas Lukaszewicz . resolved

nit: We should be able to remove this (it looks like we have 
```
      if (!is_android && !is_chromeos) {
        deps += [ "//chrome/browser/download/bubble" ]
      }
```
below at like 581

Erik Chen

Done

File chrome/browser/sessions/BUILD.gn

Line 133, Patchset 8:


    if (is_mac) {
      deps += [ "//chrome/browser:app_controller_mac" ]
    }

Thomas Lukaszewicz . resolved

nit: Could we move this `deps` block below to where we list the other conditional deps?

Erik Chen

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

2:05 AM (7 hours ago) 2:05 AM

to Daniel Cheng, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Chromium LUCI CQ, eme-r...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Daniel Cheng, Erik Chen and Thomas Lukaszewicz

Erik Chen voted and added 1 comment

Votes added by Erik Chen

Commit-Queue	+1
Mega-CQ	+1

1 comment

Patchset-level comments

File-level comment, Patchset 10:

Erik Chen . resolved

dcheng: PTAL chrome/browser/chrome_browser_interface_binders.cc

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Erik Chen
Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Lukaszewicz (Gerrit)

unread,

2:33 AM (7 hours ago) 2:33 AM

to Erik Chen, Daniel Cheng, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Chromium LUCI CQ, eme-r...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Daniel Cheng and Erik Chen

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review

+1

1 comment

File chrome/browser/BUILD.gn

Line 464, Patchset 11 (Latest):source_set("certificate_viewer") {

Thomas Lukaszewicz . unresolved

Both `certificate_viewer` and `fullscreen` headers only have implementations under `!is_android` and `!is_chromeos` respectively (these headers were previously only available under these build configurations also).

I assume there's a reason why it's necessary to expose these as not platform guarded - it might be helpful to leave a comment on why this is necessary.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Remove circular dependencies from //chrome/browser:browser [chromium/src : main]

Erik Chen (Gerrit)

Erik Chen added 1 comment

Related details

Thomas Lukaszewicz (Gerrit)

Thomas Lukaszewicz voted and added 4 comments

Votes added by Thomas Lukaszewicz

4 comments

Related details

Erik Chen (Gerrit)

Erik Chen voted Commit-Queue+1

Related details

Erik Chen (Gerrit)

Erik Chen voted Commit-Queue+1

Related details

Thomas Lukaszewicz (Gerrit)

Thomas Lukaszewicz voted and added 6 comments

Votes added by Thomas Lukaszewicz

6 comments

Related details

Erik Chen (Gerrit)

Erik Chen added 5 comments

Related details

Erik Chen (Gerrit)

Erik Chen voted and added 1 comment

Votes added by Erik Chen

1 comment

Related details

Thomas Lukaszewicz (Gerrit)

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

1 comment

Related details