Fix CalledOnValidSequence crash in TabResumptionMediator [chromium/src : main]
0 views
Skip to first unread message
Chris Lu (Gerrit)
Nov 12, 2025, 3:14:01 PMNov 12
to David Maunder, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from David Maunder
Chris Lu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- David Maunder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Maunder (Gerrit)
Nov 12, 2025, 4:11:37 PMNov 12
to Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
David Maunder voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2025, 6:34:57 PMNov 12
to David Maunder, Chris Lu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix CalledOnValidSequence crash in TabResumptionMediator
From the crash stack it looks like the FaviconLoader
is returning from a background thread and then
CanApplyOptimizationOnDemand is being called downstream
on the same thread. Guarantee CanApplyOptimizationOnDemand
is called from the UI thread as the method expects
mutual exclusion.
Bug: 456459255
Change-Id: Ia58b488a93cc524837dc0be5c9ca3120c2e3081c
Reviewed-by: Chris Lu <thegre...@chromium.org>
Commit-Queue: David Maunder <dav...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544008}
Files:
- M ios/chrome/browser/content_suggestions/ui_bundled/tab_resumption/tab_resumption_mediator.mm
Change size: XS
Delta: 1 file changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Lu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages