Fix CalledOnValidSequence crash in TabResumptionMediator [chromium/src : main]

0 views
Skip to first unread message

Chris Lu (Gerrit)

unread,
Nov 12, 2025, 3:14:01 PMNov 12
to David Maunder, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from David Maunder

Chris Lu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Maunder
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia58b488a93cc524837dc0be5c9ca3120c2e3081c
Gerrit-Change-Number: 7148325
Gerrit-PatchSet: 2
Gerrit-Owner: David Maunder <dav...@chromium.org>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: David Maunder <dav...@chromium.org>
Gerrit-Attention: David Maunder <dav...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 20:13:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

David Maunder (Gerrit)

unread,
Nov 12, 2025, 4:11:37 PMNov 12
to Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

David Maunder voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia58b488a93cc524837dc0be5c9ca3120c2e3081c
Gerrit-Change-Number: 7148325
Gerrit-PatchSet: 2
Gerrit-Owner: David Maunder <dav...@chromium.org>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: David Maunder <dav...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 21:11:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 12, 2025, 6:34:57 PMNov 12
to David Maunder, Chris Lu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix CalledOnValidSequence crash in TabResumptionMediator

From the crash stack it looks like the FaviconLoader
is returning from a background thread and then
CanApplyOptimizationOnDemand is being called downstream
on the same thread. Guarantee CanApplyOptimizationOnDemand
is called from the UI thread as the method expects
mutual exclusion.
Bug: 456459255
Change-Id: Ia58b488a93cc524837dc0be5c9ca3120c2e3081c
Reviewed-by: Chris Lu <thegre...@chromium.org>
Commit-Queue: David Maunder <dav...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544008}
Files:
Change size: XS
Delta: 1 file changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Chris Lu
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia58b488a93cc524837dc0be5c9ca3120c2e3081c
Gerrit-Change-Number: 7148325
Gerrit-PatchSet: 3
Gerrit-Owner: David Maunder <dav...@chromium.org>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Maunder <dav...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages