media/gpu/v4l2: Follow v4l2 stateless spec at initialization [chromium/src : main]

0 views
Skip to first unread message

Nathan Hebert (Gerrit)

unread,
Dec 18, 2025, 2:16:23 AM (10 days ago) Dec 18
to Jianfeng Liu, Fritz Koenig, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Fritz Koenig and Jianfeng Liu

Nathan Hebert added 4 comments

Commit Message
Line 23, Patchset 1 (Latest):Also limit call of VIDIOC_STREAMON to stateful decoder so there is no
such call before driver initializes the correct video size.
Nathan Hebert . unresolved

Can you split this into a separate commit since it is a separate change?

Line 26, Patchset 1 (Latest):Tested with H264/H265/VP8/AV1 v4l2 stateless decoder found on RK3588,
Nathan Hebert . resolved

I'm in PST. Tomorrow, I can do some testing on Mediatek and Qualcomm devices with your changes.

File media/gpu/v4l2/v4l2_video_decoder.h
Line 138, Patchset 1 (Latest): // Sends the EXT_CTRLS ioctl for 10-bit video at the specified |size|. This
// will enable retrieving the proper format from the CAPTURE queue. |size| is
// needed so that we are passing in all the information that might be needed
// by the driver to know what the format is.
Nathan Hebert . unresolved
Nit: please update the method documentation
```suggestion
  // Sends the EXT_CTRLS ioctl with the specified |size| and |bit_depth|. This
  // is required by the V4L2 stateless decoder spec at 4.5.3.2. Initialization.
```
File media/gpu/v4l2/v4l2_video_decoder.cc
Line 649, Patchset 1 (Latest): VLOGF(1) << "Need to set EXT_CTRLS at initialization";
Nathan Hebert . unresolved

This log does not seem necessary since it happens regardless of bit depth. Can you remove it, or drop the level?

Open in Gerrit

Related details

Attention is currently required from:
  • Fritz Koenig
  • Jianfeng Liu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
Gerrit-Change-Number: 7272427
Gerrit-PatchSet: 1
Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 07:16:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jianfeng Liu (Gerrit)

unread,
Dec 18, 2025, 3:57:44 AM (10 days ago) Dec 18
to Nathan Hebert, Fritz Koenig, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Fritz Koenig and Nathan Hebert

Jianfeng Liu added 1 comment

Commit Message
Line 23, Patchset 1 (Latest):Also limit call of VIDIOC_STREAMON to stateful decoder so there is no
such call before driver initializes the correct video size.
Nathan Hebert . unresolved

Can you split this into a separate commit since it is a separate change?

Jianfeng Liu

Sure, I will create a separate cl for this.

Open in Gerrit

Related details

Attention is currently required from:
  • Fritz Koenig
  • Nathan Hebert
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
Gerrit-Change-Number: 7272427
Gerrit-PatchSet: 1
Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
Gerrit-Attention: Nathan Hebert <nhe...@chromium.org>
Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 08:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nathan Hebert <nhe...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Jianfeng Liu (Gerrit)

unread,
Dec 18, 2025, 6:46:35 AM (10 days ago) Dec 18
to Nathan Hebert, Fritz Koenig, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Fritz Koenig and Nathan Hebert

Jianfeng Liu added 1 comment

File media/gpu/v4l2/v4l2_video_decoder.h
Line 138, Patchset 1 (Latest): // Sends the EXT_CTRLS ioctl for 10-bit video at the specified |size|. This
// will enable retrieving the proper format from the CAPTURE queue. |size| is
// needed so that we are passing in all the information that might be needed
// by the driver to know what the format is.
Nathan Hebert . resolved
Nit: please update the method documentation
```suggestion
  // Sends the EXT_CTRLS ioctl with the specified |size| and |bit_depth|. This
  // is required by the V4L2 stateless decoder spec at 4.5.3.2. Initialization.
```
Jianfeng Liu

Fix applied.

Gerrit-Comment-Date: Thu, 18 Dec 2025 11:46:04 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Jianfeng Liu (Gerrit)

unread,
Dec 18, 2025, 9:16:58 AM (10 days ago) Dec 18
to Nathan Hebert, Fritz Koenig, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Fritz Koenig and Nathan Hebert

Jianfeng Liu added 1 comment

File media/gpu/v4l2/v4l2_video_decoder.cc
Line 649, Patchset 1: VLOGF(1) << "Need to set EXT_CTRLS at initialization";
Nathan Hebert . resolved

This log does not seem necessary since it happens regardless of bit depth. Can you remove it, or drop the level?

Jianfeng Liu

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Fritz Koenig
  • Nathan Hebert
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
Gerrit-Change-Number: 7272427
Gerrit-PatchSet: 5
Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
Gerrit-Attention: Nathan Hebert <nhe...@chromium.org>
Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 14:16:26 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Jianfeng Liu (Gerrit)

unread,
Dec 18, 2025, 9:20:01 AM (10 days ago) Dec 18
to Nathan Hebert, Fritz Koenig, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Fritz Koenig and Nathan Hebert

Jianfeng Liu added 1 comment

Commit Message
Line 23, Patchset 1:Also limit call of VIDIOC_STREAMON to stateful decoder so there is no

such call before driver initializes the correct video size.
Nathan Hebert . resolved

Can you split this into a separate commit since it is a separate change?

Jianfeng Liu

Sure, I will create a separate cl for this.

Jianfeng Liu

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Fritz Koenig
  • Nathan Hebert
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
    Gerrit-Change-Number: 7272427
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
    Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
    Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
    Gerrit-Attention: Nathan Hebert <nhe...@chromium.org>
    Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 14:19:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jianfeng Liu <liujian...@gmail.com>
    Comment-In-Reply-To: Nathan Hebert <nhe...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Fritz Koenig (Gerrit)

    unread,
    Dec 18, 2025, 10:07:27 AM (9 days ago) Dec 18
    to Jianfeng Liu, Nathan Hebert, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
    Attention needed from Jianfeng Liu and Nathan Hebert

    Fritz Koenig added 1 comment

    File media/gpu/v4l2/v4l2_video_decoder.cc
    Line 812, Patchset 6 (Parent):#if BUILDFLAG(IS_CHROMEOS)
    Fritz Koenig . unresolved

    As discussed in crrev.com/c/6632634, AV1 can't be enabled by default. This needs to be
    ```
    #if BUILDFLAG(USE_AV1_HW_DECODER)
    ```

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jianfeng Liu
    • Nathan Hebert
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
      Gerrit-Change-Number: 7272427
      Gerrit-PatchSet: 6
      Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
      Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
      Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
      Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
      Gerrit-Attention: Nathan Hebert <nhe...@chromium.org>
      Gerrit-Comment-Date: Thu, 18 Dec 2025 15:07:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nathan Hebert (Gerrit)

      unread,
      Dec 19, 2025, 4:15:28 PM (8 days ago) Dec 19
      to Jianfeng Liu, Chromium LUCI CQ, Fritz Koenig, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
      Attention needed from Jianfeng Liu

      Nathan Hebert voted and added 2 comments

      Votes added by Nathan Hebert

      Code-Review+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 8 (Latest):
      Nathan Hebert . resolved

      I did some playback testing with 10-bit and 8-bit and the changes worked well on Mediatek (which uses stateless).

      Thanks for the change! I have one nit-pick request which I am sorry that I didn't notice during my first read through.

      File media/gpu/v4l2/v4l2_video_decoder.cc
      Line 851, Patchset 8 (Latest): // TODO(b/): Add other codecs
      Nathan Hebert . unresolved

      Nit: I think it is fine to drop this comment. There is no ticket for adding any other codec that we need to link. Thanks!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jianfeng Liu
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
      Gerrit-Change-Number: 7272427
      Gerrit-PatchSet: 8
      Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
      Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
      Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
      Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
      Gerrit-Comment-Date: Fri, 19 Dec 2025 21:15:12 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Fritz Koenig (Gerrit)

      unread,
      Dec 19, 2025, 4:21:06 PM (8 days ago) Dec 19
      to Jianfeng Liu, Nathan Hebert, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
      Attention needed from Jianfeng Liu

      Fritz Koenig voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jianfeng Liu
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
        Gerrit-Change-Number: 7272427
        Gerrit-PatchSet: 8
        Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
        Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
        Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
        Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
        Gerrit-Comment-Date: Fri, 19 Dec 2025 21:20:51 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Jianfeng Liu (Gerrit)

        unread,
        Dec 19, 2025, 9:38:32 PM (8 days ago) Dec 19
        to Fritz Koenig, Nathan Hebert, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
        Attention needed from Fritz Koenig and Nathan Hebert

        Jianfeng Liu added 1 comment

        File media/gpu/v4l2/v4l2_video_decoder.cc
        Line 851, Patchset 8: // TODO(b/): Add other codecs
        Nathan Hebert . resolved

        Nit: I think it is fine to drop this comment. There is no ticket for adding any other codec that we need to link. Thanks!

        Jianfeng Liu

        Done

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Fritz Koenig
        • Nathan Hebert
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
          Gerrit-Change-Number: 7272427
          Gerrit-PatchSet: 9
          Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
          Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
          Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
          Gerrit-Attention: Nathan Hebert <nhe...@chromium.org>
          Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
          Gerrit-Comment-Date: Sat, 20 Dec 2025 02:37:53 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Nathan Hebert <nhe...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Jianfeng Liu (Gerrit)

          unread,
          Dec 21, 2025, 5:00:30 AM (7 days ago) Dec 21
          to Fritz Koenig, Nathan Hebert, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
          Attention needed from Fritz Koenig and Nathan Hebert

          Jianfeng Liu added 1 comment

          Patchset-level comments
          File-level comment, Patchset 10 (Latest):
          Jianfeng Liu . resolved

          I just notice that mainline kernel is also checking flags in ctrl for av1 since v6.19: https://github.com/torvalds/linux/commit/2ce45197befbdc60f72288346c67930db3a4489e. So I add the necessary flags `V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_X | V4L2_AV1_SEQUENCE_FLAG_SUBSAMPLING_Y` for profile 0 with subsampling 4:2:0.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Fritz Koenig
          • Nathan Hebert
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
          Gerrit-Change-Number: 7272427
          Gerrit-PatchSet: 10
          Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
          Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
          Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
          Gerrit-Attention: Nathan Hebert <nhe...@chromium.org>
          Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
          Gerrit-Comment-Date: Sun, 21 Dec 2025 09:59:48 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Nathan Hebert (Gerrit)

          unread,
          Dec 22, 2025, 11:57:18 AM (5 days ago) Dec 22
          to Jianfeng Liu, Fritz Koenig, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
          Attention needed from Fritz Koenig and Jianfeng Liu

          Nathan Hebert added 1 comment

          File media/gpu/v4l2/v4l2_video_decoder.cc
          Line 851, Patchset 8: // TODO(b/): Add other codecs
          Nathan Hebert . resolved

          Nit: I think it is fine to drop this comment. There is no ticket for adding any other codec that we need to link. Thanks!

          Jianfeng Liu

          Done

          Nathan Hebert

          Sorry for the late response. Can you re-add the return path, but leave out the code comment?

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Fritz Koenig
          • Jianfeng Liu
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
          Gerrit-Change-Number: 7272427
          Gerrit-PatchSet: 10
          Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
          Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
          Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
          Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
          Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
          Gerrit-Comment-Date: Mon, 22 Dec 2025 16:57:09 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Nathan Hebert (Gerrit)

          unread,
          Dec 22, 2025, 11:57:33 AM (5 days ago) Dec 22
          to Jianfeng Liu, Fritz Koenig, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
          Attention needed from Fritz Koenig and Jianfeng Liu

          Nathan Hebert added 1 comment

          File media/gpu/v4l2/v4l2_video_decoder.cc
          Line 851, Patchset 8: // TODO(b/): Add other codecs
          Nathan Hebert . unresolved

          Nit: I think it is fine to drop this comment. There is no ticket for adding any other codec that we need to link. Thanks!

          Jianfeng Liu

          Done

          Nathan Hebert

          Sorry for the late response. Can you re-add the return path, but leave out the code comment?

          Nathan Hebert

          Marked as unresolved.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Fritz Koenig
          • Jianfeng Liu
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedNo-Unresolved-Comments
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
            Gerrit-Change-Number: 7272427
            Gerrit-PatchSet: 10
            Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
            Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
            Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
            Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
            Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
            Gerrit-Comment-Date: Mon, 22 Dec 2025 16:57:25 +0000
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Jianfeng Liu (Gerrit)

            unread,
            Dec 22, 2025, 8:04:54 PM (5 days ago) Dec 22
            to Fritz Koenig, Nathan Hebert, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
            Attention needed from Fritz Koenig and Nathan Hebert

            Jianfeng Liu added 1 comment

            File media/gpu/v4l2/v4l2_video_decoder.cc
            Line 851, Patchset 8: // TODO(b/): Add other codecs
            Nathan Hebert . resolved

            Nit: I think it is fine to drop this comment. There is no ticket for adding any other codec that we need to link. Thanks!

            Jianfeng Liu

            Done

            Nathan Hebert

            Sorry for the late response. Can you re-add the return path, but leave out the code comment?

            Nathan Hebert

            Marked as unresolved.

            Jianfeng Liu

            Done

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Fritz Koenig
            • Nathan Hebert
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
              Gerrit-Change-Number: 7272427
              Gerrit-PatchSet: 11
              Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
              Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
              Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
              Gerrit-Attention: Nathan Hebert <nhe...@chromium.org>
              Gerrit-Attention: Fritz Koenig <frko...@chromium.org>
              Gerrit-Comment-Date: Tue, 23 Dec 2025 01:04:20 +0000
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Fritz Koenig (Gerrit)

              unread,
              Dec 23, 2025, 10:10:17 AM (4 days ago) Dec 23
              to Jianfeng Liu, Nathan Hebert, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
              Attention needed from Jianfeng Liu and Nathan Hebert

              Fritz Koenig voted Code-Review+1

              Code-Review+1
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Jianfeng Liu
              • Nathan Hebert
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
              Gerrit-Change-Number: 7272427
              Gerrit-PatchSet: 11
              Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
              Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
              Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
              Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
              Gerrit-Attention: Nathan Hebert <nhe...@chromium.org>
              Gerrit-Comment-Date: Tue, 23 Dec 2025 15:09:59 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Nathan Hebert (Gerrit)

              unread,
              Dec 23, 2025, 12:46:00 PM (4 days ago) Dec 23
              to Jianfeng Liu, Fritz Koenig, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
              Attention needed from Jianfeng Liu

              Nathan Hebert voted

              Code-Review+1
              Commit-Queue+2
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Jianfeng Liu
              Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
                Gerrit-Change-Number: 7272427
                Gerrit-PatchSet: 11
                Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
                Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
                Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
                Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
                Gerrit-Comment-Date: Tue, 23 Dec 2025 17:45:48 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy

                Nathan Hebert (Gerrit)

                unread,
                Dec 23, 2025, 12:46:16 PM (4 days ago) Dec 23
                to Jianfeng Liu, Fritz Koenig, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
                Attention needed from Jianfeng Liu

                Nathan Hebert added 1 comment

                Patchset-level comments
                File-level comment, Patchset 11 (Latest):
                Nathan Hebert . resolved

                Thanks!

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Jianfeng Liu
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
                Gerrit-Change-Number: 7272427
                Gerrit-PatchSet: 11
                Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
                Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
                Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
                Gerrit-Attention: Jianfeng Liu <liujian...@gmail.com>
                Gerrit-Comment-Date: Tue, 23 Dec 2025 17:46:01 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: No
                satisfied_requirement
                open
                diffy

                Chromium LUCI CQ (Gerrit)

                unread,
                Dec 23, 2025, 12:58:13 PM (4 days ago) Dec 23
                to Jianfeng Liu, Nathan Hebert, Fritz Koenig, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org

                Chromium LUCI CQ submitted the change

                Change information

                Commit message:
                media/gpu/v4l2: Follow v4l2 stateless spec at initialization

                According to v4l2 stateless decoder spec at 4.5.3.2. Initialization [1],
                Userspace should send EXT_CTRLS ioctl before CAPTURE format negotiation.
                But now it is only sent when decoding 10bit videos. Some kernel driver
                like rkvdec has to initialize image format of CAPTURE queue from
                VIDIOC_S_EXT_CTRLS before CAPTURE queue buffers are allocated.

                Remove the limitation of sending EXT_CTRLS only for 10 bit videos so that
                this ioctl is always sent after calling VIDIOC_S_FMT to OUTPUT queue.


                Tested with H264/H265/VP8/AV1 v4l2 stateless decoder found on RK3588,
                VP9 v4l2 stateless decoder found on RK3399, and H264/VP8/VP9/AV1 v4l2
                stateful decoder found on Cix P1 SoC.

                [1] https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/dev-stateless-decoder.html#initialization
                Bug: 469219456
                Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
                Commit-Queue: Nathan Hebert <nhe...@chromium.org>
                Reviewed-by: Nathan Hebert <nhe...@chromium.org>
                Reviewed-by: Fritz Koenig <frko...@chromium.org>
                Cr-Commit-Position: refs/heads/main@{#1562229}
                Files:
                • M media/gpu/v4l2/v4l2_video_decoder.cc
                • M media/gpu/v4l2/v4l2_video_decoder.h
                Change size: M
                Delta: 2 files changed, 61 insertions(+), 37 deletions(-)
                Branch: refs/heads/main
                Submit Requirements:
                • requirement satisfiedCode-Review: +1 by Fritz Koenig, +1 by Nathan Hebert
                Open in Gerrit
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: merged
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I1c96dd3443f407050fcc7a5fbde98a6502c66977
                Gerrit-Change-Number: 7272427
                Gerrit-PatchSet: 12
                Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
                Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                Gerrit-Reviewer: Fritz Koenig <frko...@chromium.org>
                Gerrit-Reviewer: Nathan Hebert <nhe...@chromium.org>
                open
                diffy
                satisfied_requirement

                Jianfeng Liu (Gerrit)

                unread,
                Dec 24, 2025, 1:13:39 AM (4 days ago) Dec 24
                to AyeAye, feature-me...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com

                Jianfeng Liu abandoned this change

                Related details

                Attention set is empty
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement is not satisfiedCode-Review
                • requirement is not satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: abandon
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I16edbec31d874f55dcd209a633cc2b9269d993c1
                Gerrit-Change-Number: 7272904
                Gerrit-PatchSet: 1
                Gerrit-Owner: Jianfeng Liu <liujian...@gmail.com>
                satisfied_requirement
                unsatisfied_requirement
                open
                diffy

                Jianfeng Liu (Gerrit)

                unread,
                Dec 24, 2025, 12:07:34 PM (3 days ago) Dec 24
                to AyeAye, media-cro...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org

                Jianfeng Liu abandoned this change

                Related details

                Attention set is empty
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement is not satisfiedCode-Review
                • requirement is not satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: abandon
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I912bb43ad08358fb5801544dbb42110be5b401e7
                Gerrit-Change-Number: 7272029
                satisfied_requirement
                unsatisfied_requirement
                open
                diffy
                Reply all
                Reply to author
                Forward
                0 new messages