Update AudioDecoderConfig media/ usage to provide a ChannelLayoutConfig [chromium/src : main]

0 views

Skip to first unread message

Syed AbuTalib (Gerrit)

unread,

Feb 11, 2026, 7:56:22 PM (8 hours ago) Feb 11

to Thomas Guilbert, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, feature-me...@chromium.org

Syed AbuTalib voted and added 2 comments

Votes added by Syed AbuTalib

Commit-Queue

2 comments

Commit Message

Line 6, Patchset 4:


Update AudioDecoderConfig usage in media/ to provide a ChannelLayoutConfig

Thomas Guilbert . resolved

The title should be shortened so it at least fits in 80 char, ideally less.

Syed AbuTalib

Done

File media/formats/mpeg/mpeg_audio_stream_parser_base.cc

Line 289, Patchset 4: {channel_layout, ChannelLayoutToChannelCount(channel_layout)},

Thomas Guilbert . resolved

This pattern occurs a lot. We could potentially add a non templated `FromLayout(ChannelLayout layout)` static helper which does exactly this.

Syed AbuTalib

Done in https://chromium-review.googlesource.com/c/chromium/src/+/7569128. Marking as resolved.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Thomas Guilbert (Gerrit)

unread,

2:47 AM (1 hour ago) 2:47 AM

to Syed AbuTalib, Thomas Guilbert, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, feature-me...@chromium.org

Attention needed from Syed AbuTalib

Thomas Guilbert voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Syed AbuTalib

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages