Add kSearchAIModeBubble access point [chromium/src : main]

[Anthi Orfanou (Gerrit)]

Attention needed from Ryan Sultanem

Anthi Orfanou voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Ryan Sultanem

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3a993a7e305b7578728325f23357d9989e6cc4f8

Gerrit-Change-Number: 7616929

Gerrit-PatchSet: 8

Gerrit-Owner: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ryan Sultanem <rs...@google.com>

Gerrit-Comment-Date: Fri, 27 Feb 2026 13:57:10 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ryan Sultanem (Gerrit)]

Attention needed from Anthi Orfanou

Ryan Sultanem added 2 comments

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Ryan Sultanem . resolved

Thanks!

File chrome/browser/signin/signin_promo_util.cc

Line 313, Patchset 9 (Latest): .GetAutofillSigninPromoDismissCount(gaia_id);

Ryan Sultanem . unresolved

I think that this is an important consideration that could impact the design decision (for next CL).

Should the new promo have the same limiting rate as the existing autofill promos? Autofill is actually not very accurate here as it also considers Extensions and Bookmarks.

Maybe it is not worth blocking this CL though.

Open in Gerrit

Related details

Attention is currently required from:

• Anthi Orfanou

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3a993a7e305b7578728325f23357d9989e6cc4f8

Gerrit-Change-Number: 7616929

Gerrit-PatchSet: 9

Gerrit-Owner: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Anthi Orfanou <ant...@google.com>

Gerrit-Comment-Date: Fri, 27 Feb 2026 18:25:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Anthi Orfanou (Gerrit)]

Attention needed from Ryan Sultanem

Anthi Orfanou added 1 comment

File chrome/browser/signin/signin_promo_util.cc

Line 313, Patchset 9 (Latest): .GetAutofillSigninPromoDismissCount(gaia_id);

Ryan Sultanem . unresolved

I think that this is an important consideration that could impact the design decision (for next CL).

Should the new promo have the same limiting rate as the existing autofill promos? Autofill is actually not very accurate here as it also considers Extensions and Bookmarks.

Maybe it is not worth blocking this CL though.

Anthi Orfanou

No, this promo should have it's own rate limit logic.
However I has to touch the switch statements that refer to the updated enum (and added the TODOs as a reminder).
I think we can ignore them for now, as all these points will be revised/moved around as soon as we implement the rate limit CL.

Open in Gerrit

Related details

Attention is currently required from:

• Ryan Sultanem

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3a993a7e305b7578728325f23357d9989e6cc4f8

Gerrit-Change-Number: 7616929

Gerrit-PatchSet: 9

Gerrit-Owner: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ryan Sultanem <rs...@google.com>

Gerrit-Comment-Date: Wed, 04 Mar 2026 16:28:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ryan Sultanem <rs...@google.com>

[Anthi Orfanou (Gerrit)]

Attention needed from Ryan Sultanem

Anthi Orfanou added 1 comment

File chrome/browser/signin/signin_promo_util.cc

Line 313, Patchset 9: .GetAutofillSigninPromoDismissCount(gaia_id);

Ryan Sultanem . resolved

I think that this is an important consideration that could impact the design decision (for next CL).

Should the new promo have the same limiting rate as the existing autofill promos? Autofill is actually not very accurate here as it also considers Extensions and Bookmarks.

Maybe it is not worth blocking this CL though.

Anthi Orfanou

No, this promo should have it's own rate limit logic.
However I has to touch the switch statements that refer to the updated enum (and added the TODOs as a reminder).
I think we can ignore them for now, as all these points will be revised/moved around as soon as we implement the rate limit CL.

Anthi Orfanou

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Ryan Sultanem

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3a993a7e305b7578728325f23357d9989e6cc4f8

Gerrit-Change-Number: 7616929

Gerrit-PatchSet: 10

Gerrit-Owner: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ryan Sultanem <rs...@google.com>

Gerrit-Comment-Date: Wed, 04 Mar 2026 16:28:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ryan Sultanem <rs...@google.com>

Comment-In-Reply-To: Anthi Orfanou <ant...@google.com>

[Anthi Orfanou (Gerrit)]

Attention needed from Menghan Yang and Ryan Sultanem

Anthi Orfanou added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Anthi Orfanou . resolved

+Menghan for owner's review of ios/chrome/browser/authentication/ui_bundled/*.

Open in Gerrit

Related details

Attention is currently required from:

• Menghan Yang
• Ryan Sultanem

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I3a993a7e305b7578728325f23357d9989e6cc4f8

Gerrit-Change-Number: 7616929

Gerrit-PatchSet: 11

Gerrit-Owner: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Anthi Orfanou <ant...@google.com>

Gerrit-Reviewer: Menghan Yang <my...@google.com>

Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Menghan Yang <my...@google.com>

Gerrit-Attention: Ryan Sultanem <rs...@google.com>

Gerrit-Comment-Date: Thu, 05 Mar 2026 15:52:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No