media: Increase expiry for GMC histograms [chromium/src : main]
0 views
Skip to first unread message
Evan Liu (Gerrit)
Aug 4, 2026, 6:45:46 PM (13 hours ago) Aug 4
to Vikram Pasupathy, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, feature-me...@chromium.org
Attention needed from Vikram Pasupathy
Evan Liu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Evan Liu
| Code-Review | +1 |
1 comment
File tools/metrics/histograms/metadata/media/histograms.xml
Line 5305, Patchset 2 (Latest):
<histogram name="Media.GlobalMediaControls.RepeatUsage" enum="BooleanIsRepeat"Evan Liu . unresolved
nit: might be useful to add a comment like “Warning: this histogram was expired from DATE to DATE; data may be missing.”
Related details
Attention is currently required from:
- Vikram Pasupathy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Aug 4, 2026, 6:57:14 PM (12 hours ago) Aug 4
to Evan Liu, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, feature-me...@chromium.org
Vikram Pasupathy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vikram Pasupathy
| Commit-Queue | +2 |
1 comment
File tools/metrics/histograms/metadata/media/histograms.xml
Line 5305, Patchset 2:
<histogram name="Media.GlobalMediaControls.RepeatUsage" enum="BooleanIsRepeat"Evan Liu . resolved
nit: might be useful to add a comment like “Warning: this histogram was expired from DATE to DATE; data may be missing.”
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Aug 4, 2026, 7:49:52 PM (12 hours ago) Aug 4
to chromium...@chromium.org, Chromium LUCI CQ, Evan Liu, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, feature-me...@chromium.org
Vikram Pasupathy voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 4, 2026, 9:49:13 PM (10 hours ago) Aug 4
to Vikram Pasupathy, chromium...@chromium.org, Evan Liu, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, asvitkine...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: tools/metrics/histograms/metadata/media/histograms.xml
Insertions: 4, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
media: Increase expiry for GMC histograms
Also add note for data loss.
Change-Id: I5cbe6237d71acb487e1db0ea58b36b4329723e08
Reviewed-by: Evan Liu <ev...@google.com>
Commit-Queue: Vikram Pasupathy <vpasu...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1673843}
Files:
- M tools/metrics/histograms/metadata/media/histograms.xml
Change size: XS
Delta: 1 file changed, 6 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Evan Liu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages