[bedrock] Remove Browser* from current_tab_desktop_media_list_unittest [chromium/src : main]

0 views
Skip to first unread message

Daniel Rubery (Gerrit)

unread,
Apr 21, 2026, 4:57:30 PM (2 days ago) Apr 21
to chromium-bedrock-reviews, Chromium LUCI CQ, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, chfreme...@chromium.org
Attention needed from chromium-bedrock-reviews

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • chromium-bedrock-reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5f4e5a5a57fe1b5088ebfd16e4d89a86a6a6964
Gerrit-Change-Number: 7782886
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 20:57:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Apr 21, 2026, 5:05:12 PM (2 days ago) Apr 21
to Daniel Rubery, chromium-bedrock-reviews, Darryl James, Chromium LUCI CQ, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, chfreme...@chromium.org
Attention needed from Darryl James

Message from gwsq

Reviewer source(s):
dlj...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Darryl James
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5f4e5a5a57fe1b5088ebfd16e4d89a86a6a6964
Gerrit-Change-Number: 7782886
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Darryl James <dlj...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 21:05:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Darryl James (Gerrit)

unread,
1:15 PM (2 hours ago) 1:15 PM
to Daniel Rubery, chromium-bedrock-reviews, Chromium LUCI CQ, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, chfreme...@chromium.org
Attention needed from Daniel Rubery

Darryl James voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Rubery
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5f4e5a5a57fe1b5088ebfd16e4d89a86a6a6964
Gerrit-Change-Number: 7782886
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Daniel Rubery <dru...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Apr 2026 17:15:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniel Rubery (Gerrit)

unread,
1:28 PM (2 hours ago) 1:28 PM
to Darryl James, chromium-bedrock-reviews, Chromium LUCI CQ, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, chfreme...@chromium.org

Daniel Rubery voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5f4e5a5a57fe1b5088ebfd16e4d89a86a6a6964
Gerrit-Change-Number: 7782886
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: chromium-bedrock-reviews <chromium-bed...@google.com>
Gerrit-CC: gwsq
Gerrit-Comment-Date: Thu, 23 Apr 2026 17:27:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
2:32 PM (1 hour ago) 2:32 PM
to Daniel Rubery, Darryl James, chromium-bedrock-reviews, Simon Hangl, Rijubrata Bhaumik, Andrew Rayskiy, android-bu...@system.gserviceaccount.com, feature-me...@chromium.org, chfreme...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[bedrock] Remove Browser* from current_tab_desktop_media_list_unittest

This fixture only uses a Browser as a holder for manually-created
WebContents. Use a vector instead.
Bug: 505068940
Reviewed-by: Darryl James <dlj...@chromium.org>
Commit-Queue: Daniel Rubery <dru...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1619644}
Files:
  • M chrome/browser/media/webrtc/current_tab_desktop_media_list_unittest.cc
Change size: S
Delta: 1 file changed, 13 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darryl James
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5f4e5a5a57fe1b5088ebfd16e4d89a86a6a6964
Gerrit-Change-Number: 7782886
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Rubery <dru...@chromium.org>
Gerrit-Reviewer: Darryl James <dlj...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages