Add an optional filter to GetAppById() & expand the set of IWA filters [chromium/src : main]

0 views
Skip to first unread message

Andrew Rayskiy (Gerrit)

unread,
Jan 15, 2026, 1:54:22 PM (3 days ago) Jan 15
to Dibyajyoti Pal, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Dibyajyoti Pal

Andrew Rayskiy added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Andrew Rayskiy . resolved

Hey Dibya, PTAL 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Dibyajyoti Pal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d56fe530b6fd6395149348e20e53ba445e6d973
Gerrit-Change-Number: 7452282
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Dibyajyoti Pal <diby...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 18:54:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dibyajyoti Pal (Gerrit)

unread,
Jan 15, 2026, 4:23:47 PM (3 days ago) Jan 15
to Andrew Rayskiy, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
Attention needed from Andrew Rayskiy

Dibyajyoti Pal voted and added 3 comments

Votes added by Dibyajyoti Pal

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Dibyajyoti Pal . resolved

LGTM, this looks reasonable, thanks for doing this! 😄

One good thing here is that we can now also use the `matches` logic to clump multiple filters together and have `WebAppFilter` be some sort of a builder pattern, so that we can use multiple WebAppFilters while trying to fetch a single app. Nice!

File chrome/browser/web_applications/web_app_registrar.cc
Line 1044, Patchset 6 (Latest): if (const auto& iwa_filter = filter.isolated_app_filter_) {
Dibyajyoti Pal . unresolved

Interesting, I wonder how this works? Isn't `iwa_filter` a `std::optional<>`? In that case, won't this conditional always be true? Or does it reference to a value under the hood, and returns a nullptr if it's `std::nullopt`?

Line 1358, Patchset 6 (Parent): {proto::InstallState::SUGGESTED_FROM_ANOTHER_DEVICE,
Dibyajyoti Pal . unresolved

This is a subtle behavior change, as apps coming in via sync (`SUGGESTED_FROM_ANOTHER_DEVICE`) will no longer be considered as valid for this function. I think it's fine, because IWAs aren't synced (afaik!), right?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6d56fe530b6fd6395149348e20e53ba445e6d973
    Gerrit-Change-Number: 7452282
    Gerrit-PatchSet: 6
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 21:23:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dibyajyoti Pal (Gerrit)

    unread,
    Jan 15, 2026, 4:29:45 PM (3 days ago) Jan 15
    to Andrew Rayskiy, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
    Attention needed from Andrew Rayskiy

    Dibyajyoti Pal added 1 comment

    File chrome/browser/web_applications/isolated_web_apps/isolated_web_app_throttle.h
    Line 48, Patchset 6 (Parent): raw_ptr<IwaPermissionsPolicyCache> cache_;
    Dibyajyoti Pal . resolved

    Hidden change here, of the `cache_` being removed :p, and instead obtaining the permissions policy factory from the profile!

    Totally fine for the time being since we're removing a raw_ptr (yay!), but if this CL breaks things and needs to be reverted, this logic will need to be re-added again.

    Gerrit-Comment-Date: Thu, 15 Jan 2026 21:29:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Jan 16, 2026, 8:05:19 AM (2 days ago) Jan 16
    to Danil Somsikov, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
    Attention needed from Danil Somsikov

    Andrew Rayskiy added 3 comments

    Patchset-level comments
    File-level comment, Patchset 6:
    Andrew Rayskiy . resolved

    + Danil for devtools

    File chrome/browser/web_applications/web_app_registrar.cc
    Line 1044, Patchset 6: if (const auto& iwa_filter = filter.isolated_app_filter_) {
    Dibyajyoti Pal . resolved

    Interesting, I wonder how this works? Isn't `iwa_filter` a `std::optional<>`? In that case, won't this conditional always be true? Or does it reference to a value under the hood, and returns a nullptr if it's `std::nullopt`?

    Andrew Rayskiy
    `if (<decl> var = func()) { ... }` is equal to
    ```
    {
      <decl> var = func();
      if (var) {
        ...
      }
    }
    ```

    So it will behave like a normal optional!

    Line 1358, Patchset 6 (Parent): {proto::InstallState::SUGGESTED_FROM_ANOTHER_DEVICE,
    Dibyajyoti Pal . resolved

    This is a subtle behavior change, as apps coming in via sync (`SUGGESTED_FROM_ANOTHER_DEVICE`) will no longer be considered as valid for this function. I think it's fine, because IWAs aren't synced (afaik!), right?

    Andrew Rayskiy

    They're not; this code looks like a remnant from some other age where people weren't sure about anything IWA-related!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danil Somsikov
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6d56fe530b6fd6395149348e20e53ba445e6d973
      Gerrit-Change-Number: 7452282
      Gerrit-PatchSet: 6
      Gerrit-Owner: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Danil Somsikov <d...@chromium.org>
      Gerrit-Comment-Date: Fri, 16 Jan 2026 13:05:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dibyajyoti Pal <diby...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Simon Hangl (Gerrit)

      unread,
      Jan 16, 2026, 11:24:48 AM (2 days ago) Jan 16
      to Andrew Rayskiy, Danil Somsikov, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
      Attention needed from Andrew Rayskiy and Danil Somsikov

      Simon Hangl voted and added 1 comment

      Votes added by Simon Hangl

      Code-Review+1

      1 comment

      Patchset-level comments
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Rayskiy
      • Danil Somsikov
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6d56fe530b6fd6395149348e20e53ba445e6d973
      Gerrit-Change-Number: 7452282
      Gerrit-PatchSet: 7
      Gerrit-Owner: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
      Gerrit-Reviewer: Simon Hangl <sim...@google.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-Attention: Andrew Rayskiy <green...@google.com>
      Gerrit-Attention: Danil Somsikov <d...@chromium.org>
      Gerrit-Comment-Date: Fri, 16 Jan 2026 16:24:31 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dibyajyoti Pal (Gerrit)

      unread,
      Jan 16, 2026, 12:27:53 PM (2 days ago) Jan 16
      to Andrew Rayskiy, Simon Hangl, Danil Somsikov, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
      Attention needed from Andrew Rayskiy, Danil Somsikov and Simon Hangl

      Dibyajyoti Pal voted and added 1 comment

      Votes added by Dibyajyoti Pal

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 8 (Latest):
      Dibyajyoti Pal . resolved

      LGTM % pending test failures!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Rayskiy
      • Danil Somsikov
      • Simon Hangl
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6d56fe530b6fd6395149348e20e53ba445e6d973
      Gerrit-Change-Number: 7452282
      Gerrit-PatchSet: 8
      Gerrit-Owner: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
      Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
      Gerrit-Reviewer: Simon Hangl <sim...@google.com>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-Attention: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Andrew Rayskiy <green...@google.com>
      Gerrit-Attention: Danil Somsikov <d...@chromium.org>
      Gerrit-Comment-Date: Fri, 16 Jan 2026 17:27:38 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Andrew Rayskiy (Gerrit)

      unread,
      Jan 16, 2026, 2:56:10 PM (2 days ago) Jan 16
      to Dibyajyoti Pal, Simon Hangl, Danil Somsikov, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
      Attention needed from Danil Somsikov, Dibyajyoti Pal and Simon Hangl

      Andrew Rayskiy added 1 comment

      File chrome/browser/web_applications/web_app_registrar_unittest.cc
      Line 974, Patchset 11 (Parent):TEST_F(
      Andrew Rayskiy . unresolved

      I'm sometimes honestly shocked by how many ad-hoc tests we have that rely on some customly crafted conditions (incl. modifying the registrar directly) instead of actually testing the prod flows!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Danil Somsikov
      • Dibyajyoti Pal
      • Simon Hangl
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I6d56fe530b6fd6395149348e20e53ba445e6d973
        Gerrit-Change-Number: 7452282
        Gerrit-PatchSet: 11
        Gerrit-Owner: Andrew Rayskiy <green...@google.com>
        Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
        Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
        Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
        Gerrit-Reviewer: Simon Hangl <sim...@google.com>
        Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
        Gerrit-Attention: Dibyajyoti Pal <diby...@chromium.org>
        Gerrit-Attention: Simon Hangl <sim...@google.com>
        Gerrit-Attention: Danil Somsikov <d...@chromium.org>
        Gerrit-Comment-Date: Fri, 16 Jan 2026 19:55:57 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Dibyajyoti Pal (Gerrit)

        unread,
        Jan 16, 2026, 3:00:23 PM (2 days ago) Jan 16
        to Andrew Rayskiy, Simon Hangl, Danil Somsikov, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
        Attention needed from Andrew Rayskiy, Danil Somsikov and Simon Hangl

        Dibyajyoti Pal voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Andrew Rayskiy
        • Danil Somsikov
        • Simon Hangl
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I6d56fe530b6fd6395149348e20e53ba445e6d973
          Gerrit-Change-Number: 7452282
          Gerrit-PatchSet: 11
          Gerrit-Owner: Andrew Rayskiy <green...@google.com>
          Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
          Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
          Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
          Gerrit-Reviewer: Simon Hangl <sim...@google.com>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-Attention: Simon Hangl <sim...@google.com>
          Gerrit-Attention: Andrew Rayskiy <green...@google.com>
          Gerrit-Attention: Danil Somsikov <d...@chromium.org>
          Gerrit-Comment-Date: Fri, 16 Jan 2026 20:00:16 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Danil Somsikov (Gerrit)

          unread,
          Jan 16, 2026, 4:20:18 PM (2 days ago) Jan 16
          to Andrew Rayskiy, Simon Hangl, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, mek+w...@chromium.org, aixba+wat...@chromium.org, japhet+...@chromium.org, chfreme...@chromium.org, feature-me...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, rmcelra...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org
          Attention needed from Andrew Rayskiy and Simon Hangl

          Danil Somsikov voted and added 1 comment

          Votes added by Danil Somsikov

          Code-Review+1

          1 comment

          Patchset-level comments
          File-level comment, Patchset 11 (Latest):
          Danil Somsikov . resolved

          for DevTools

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Andrew Rayskiy
          • Simon Hangl
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I6d56fe530b6fd6395149348e20e53ba445e6d973
          Gerrit-Change-Number: 7452282
          Gerrit-PatchSet: 11
          Gerrit-Owner: Andrew Rayskiy <green...@google.com>
          Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
          Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
          Gerrit-Reviewer: Dibyajyoti Pal <diby...@chromium.org>
          Gerrit-Reviewer: Simon Hangl <sim...@google.com>
          Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
          Gerrit-Attention: Simon Hangl <sim...@google.com>
          Gerrit-Attention: Andrew Rayskiy <green...@google.com>
          Gerrit-Comment-Date: Fri, 16 Jan 2026 21:19:57 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages