[ios] Inject SessionRestorationService in TabGroupLocalUpdateObserver [chromium/src : main]
0 views
Skip to first unread message
Sylvain Defresne (Gerrit)
Oct 16, 2025, 8:37:28 AMOct 16
to Ewann Pellé, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ewann Pellé
Sylvain Defresne voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sylvain Defresne
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
Oct 16, 2025, 8:43:45 AMOct 16
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne
Ewann Pellé voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ewann Pellé
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
Nov 6, 2025, 5:15:09 AM (7 days ago) Nov 6
to Ewann Pellé, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Sylvain Defresne voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
Nov 6, 2025, 5:19:44 AM (7 days ago) Nov 6
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne
Ewann Pellé voted Code-Review+0![]( "Open in Gerrit")
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
Nov 6, 2025, 5:19:48 AM (7 days ago) Nov 6
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne
Ewann Pellé voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
Nov 6, 2025, 5:19:59 AM (7 days ago) Nov 6
to Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne
Ewann Pellé voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
4:59 AM (13 hours ago) 4:59 AM
to Ewann Pellé, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Sylvain Defresne voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:05 AM (12 hours ago) 6:05 AM
to Sylvain Defresne, Ewann Pellé, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[ios] Inject SessionRestorationService in TabGroupLocalUpdateObserver
As the storage migration code has been removed, it is now safe to
inject it in TabGroupLocalUpdateObserver constructor (previously
it could cause the service to be created before the data storage
migration completed).
Fixed: 350885825
Change-Id: Icfa276c9f4ca33ad0d6cad020f25298cc0981823
Reviewed-by: Ewann Pellé <ewa...@chromium.org>
Commit-Queue: Sylvain Defresne <sdef...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1543628}
Files:
- M ios/chrome/browser/saved_tab_groups/model/ios_tab_group_sync_delegate_unittest.mm
- M ios/chrome/browser/saved_tab_groups/model/ios_tab_group_sync_util_unittest.mm
- M ios/chrome/browser/saved_tab_groups/model/tab_group_local_update_observer.h
- M ios/chrome/browser/saved_tab_groups/model/tab_group_local_update_observer.mm
- M ios/chrome/browser/saved_tab_groups/model/tab_group_local_update_observer_unittest.mm
- M ios/chrome/browser/saved_tab_groups/model/tab_group_sync_service_factory.mm
- M ios/chrome/browser/tab_switcher/tab_strip/coordinator/BUILD.gn
- M ios/chrome/browser/tab_switcher/tab_strip/coordinator/tab_strip_mediator_utils_unittest.mm
- M ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/grid/grid_mediator_test.mm
- M ios/chrome/test/earl_grey/BUILD.gn
- M ios/chrome/test/earl_grey/eg_tests_hook.mm
Change size: M
Delta: 11 files changed, 35 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ewann Pellé
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages