John Powers (Gerrit)

unread,

12:13 AM (18 hours ago) 12:13 AM

to Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Dibyajyoti Pal, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from Dibyajyoti Pal and John Powers

Message from John Powers

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Dibyajyoti Pal
John Powers

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

John Powers (Gerrit)

unread,

12:14 AM (18 hours ago) 12:14 AM

to Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Dibyajyoti Pal, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from Dibyajyoti Pal

John Powers voted and added 1 comment

Votes added by John Powers

Commit-Queue

+1

1 comment

File chrome/browser/ui/web_applications/web_app_browsertest.cc

Line 556, Patchset 1: content::BackgroundColorChangeWaiter waiter(web_contents);

Dibyajyoti Pal . resolved

While this works, ideally, we would do it by:
1. Creating a new `content::BackgroundColorChangeWaiter` overload that also takes in a `expected_color` parameter.
2. If the `expected_color` matches the current web contents' background color, the waiter exits early.
3. Else the waiter waits for the background color to match the expected color does its thing till the background color changes.
Can we implement that instead? That seems like a more holistic fix instead of guarding it by conditionals here. Wdyt?

John Powers

I think that's a great proposal! I went ahead and made the changes, please let me know if you have any edits! Thanks for the review!

Open in Gerrit

Related details

Attention is currently required from:

Dibyajyoti Pal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dibyajyoti Pal (Gerrit)

unread,

12:12 PM (6 hours ago) 12:12 PM

to John Powers, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from John Powers

Dibyajyoti Pal voted and added 1 comment

Votes added by Dibyajyoti Pal

Code-Review

+1

1 comment

File content/public/test/background_color_change_waiter.h

Line 22, Patchset 6 (Latest): explicit BackgroundColorChangeWaiter(content::WebContents* web_contents);

Dibyajyoti Pal . unresolved

nit: We could have one ctor instead of 2 here, and have the input be an `optional` value that is default initialized, like:

```
BackgroundColorChangeWaiter(content::WebContents* web_contents, std::optional<SkColor> expected_background_color = std::nullopt);
```

The default initialization prevents having to update all the callsites. Imo this impl is a little bit simpler, but the current one is fine too. Will defer to you if you want to change or keep it this way 😊.

Open in Gerrit

Related details

Attention is currently required from:

John Powers

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dibyajyoti Pal (Gerrit)

unread,

12:12 PM (6 hours ago) 12:12 PM

to John Powers, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from John Powers

Dibyajyoti Pal added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Dibyajyoti Pal . resolved

Thanks for finding the race condition here, proposed an alternate solution.

Dibyajyoti Pal

LGTM, thanks for the quick fix!

satisfied_requirement

unsatisfied_requirement

open

diffy

John Powers (Gerrit)

unread,

2:57 PM (3 hours ago) 2:57 PM

to Dibyajyoti Pal, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from Dibyajyoti Pal

John Powers voted and added 1 comment

Votes added by John Powers

Auto-Submit	+1
Commit-Queue	+2

1 comment

File content/public/test/background_color_change_waiter.h

Line 22, Patchset 6: explicit BackgroundColorChangeWaiter(content::WebContents* web_contents);

Dibyajyoti Pal . unresolved

nit: We could have one ctor instead of 2 here, and have the input be an `optional` value that is default initialized, like:
```
BackgroundColorChangeWaiter(content::WebContents* web_contents, std::optional<SkColor> expected_background_color = std::nullopt);
```
The default initialization prevents having to update all the callsites. Imo this impl is a little bit simpler, but the current one is fine too. Will defer to you if you want to change or keep it this way 😊.

John Powers

Fixed! Thanks for the feedback!

Open in Gerrit

Related details

Attention is currently required from:

Dibyajyoti Pal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dibyajyoti Pal (Gerrit)

unread,

3:02 PM (3 hours ago) 3:02 PM

to John Powers, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from John Powers

Dibyajyoti Pal voted and added 3 comments

Votes added by Dibyajyoti Pal

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Dibyajyoti Pal . resolved

LGTM, can we also assign to some of the content/ folks for review?

File content/public/test/background_color_change_waiter.h

Line 22, Patchset 7 (Latest): explicit BackgroundColorChangeWaiter(

Dibyajyoti Pal . unresolved

We probably also do not need the `explicit` keyword here, as per [1].

[1] https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

Line 22, Patchset 6: explicit BackgroundColorChangeWaiter(content::WebContents* web_contents);

Dibyajyoti Pal . resolved

nit: We could have one ctor instead of 2 here, and have the input be an `optional` value that is default initialized, like:
```
BackgroundColorChangeWaiter(content::WebContents* web_contents, std::optional<SkColor> expected_background_color = std::nullopt);
```
The default initialization prevents having to update all the callsites. Imo this impl is a little bit simpler, but the current one is fine too. Will defer to you if you want to change or keep it this way 😊.

John Powers

Fixed! Thanks for the feedback!

Dibyajyoti Pal

Done

Open in Gerrit

Related details

Attention is currently required from:

John Powers

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

John Powers (Gerrit)

unread,

4:12 PM (2 hours ago) 4:12 PM

to Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from Nasko Oskov

John Powers added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

John Powers . resolved

Hi there! Could I please get a review over the content/ area, if not can you please reassign to someone who could? Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

John Powers (Gerrit)

unread,

4:17 PM (2 hours ago) 4:17 PM

to Dibyajyoti Pal, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from Dibyajyoti Pal and Nasko Oskov

John Powers voted and added 1 comment

Votes added by John Powers

Auto-Submit	+1
Commit-Queue	+1

1 comment

File content/public/test/background_color_change_waiter.h

Line 22, Patchset 7: explicit BackgroundColorChangeWaiter(

Dibyajyoti Pal . resolved

We probably also do not need the `explicit` keyword here, as per [1].
[1] https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

John Powers

fixed!

Open in Gerrit

Related details

Attention is currently required from:

Dibyajyoti Pal
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Marijn Kruisselbrink (Gerrit)

unread,

4:27 PM (2 hours ago) 4:27 PM

to John Powers, Marijn Kruisselbrink, Dibyajyoti Pal, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from Dibyajyoti Pal, John Powers and Nasko Oskov

Marijn Kruisselbrink added 1 comment

File content/public/test/background_color_change_waiter.h

Line 22, Patchset 7: explicit BackgroundColorChangeWaiter(

Dibyajyoti Pal . unresolved

We probably also do not need the `explicit` keyword here, as per [1].
[1] https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

John Powers

fixed!

Marijn Kruisselbrink

Why not? This is a constructor that can be called with a single argument, so per that linked style guide should have the explicit keyword?

Open in Gerrit

Related details

Attention is currently required from:

Dibyajyoti Pal
John Powers
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

John Powers (Gerrit)

unread,

4:40 PM (2 hours ago) 4:40 PM

to Marijn Kruisselbrink, Dibyajyoti Pal, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from Dibyajyoti Pal, Marijn Kruisselbrink and Nasko Oskov

John Powers voted and added 1 comment

Votes added by John Powers

Auto-Submit	+1
Commit-Queue	+1

1 comment

File content/public/test/background_color_change_waiter.h

Line 22, Patchset 7: explicit BackgroundColorChangeWaiter(

Dibyajyoti Pal . resolved

We probably also do not need the `explicit` keyword here, as per [1].
[1] https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

John Powers

fixed!

Marijn Kruisselbrink

Why not? This is a constructor that can be called with a single argument, so per that linked style guide should have the explicit keyword?

John Powers

Looking again, I actually agree that it should stay explicit based on what Marijn said- Dibya if you feel differently please feel free to reopen this 😊

Open in Gerrit

Related details

Attention is currently required from:

Dibyajyoti Pal
Marijn Kruisselbrink
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dibyajyoti Pal (Gerrit)

unread,

5:00 PM (1 hour ago) 5:00 PM

to John Powers, Marijn Kruisselbrink, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from John Powers, Marijn Kruisselbrink and Nasko Oskov

Dibyajyoti Pal voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

John Powers
Marijn Kruisselbrink
Nasko Oskov

satisfied_requirement

unsatisfied_requirement

open

diffy

Dibyajyoti Pal (Gerrit)

unread,

5:02 PM (1 hour ago) 5:02 PM

to John Powers, Marijn Kruisselbrink, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from John Powers, Marijn Kruisselbrink and Nasko Oskov

Dibyajyoti Pal added 1 comment

File content/public/test/background_color_change_waiter.h

Line 22, Patchset 7: explicit BackgroundColorChangeWaiter(

Dibyajyoti Pal . resolved

We probably also do not need the `explicit` keyword here, as per [1].
[1] https://google.github.io/styleguide/cppguide.html#Implicit_Conversions

John Powers

fixed!

Marijn Kruisselbrink

Why not? This is a constructor that can be called with a single argument, so per that linked style guide should have the explicit keyword?

John Powers

Looking again, I actually agree that it should stay explicit based on what Marijn said- Dibya if you feel differently please feel free to reopen this 😊

Dibyajyoti Pal

Oh yes, missed that. This is fine!

satisfied_requirement

unsatisfied_requirement

open

diffy

Dibyajyoti Pal (Gerrit)

unread,

5:49 PM (1 hour ago) 5:49 PM

to John Powers, Marijn Kruisselbrink, Jerome Jiang, Mirko Bonadei, Chromium LUCI CQ, Stanley Hon, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, chrome-intelligence-te...@google.com, mar...@chromium.org, cblume...@chromium.org, eme-r...@chromium.org, grt+...@chromium.org, net-r...@chromium.org, jshin...@chromium.org, feature-me...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, zelin+watch-we...@chromium.org, japhet+...@chromium.org, dibyapal+wa...@chromium.org, mgiuca...@chromium.org, mek+w...@chromium.org, loyso...@chromium.org, philli...@chromium.org, kuragin+web-ap...@chromium.org, aixba+wat...@chromium.org, webap...@microsoft.com, dmurph+watc...@chromium.org

Attention needed from John Powers, Marijn Kruisselbrink and Nasko Oskov

Dibyajyoti Pal voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

John Powers
Marijn Kruisselbrink
Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Fix race in WebAppBrowserTest.BackgroundColorChange [chromium/src : main]

John Powers (Gerrit)

Message from John Powers

Related details

John Powers (Gerrit)

John Powers voted and added 1 comment

Votes added by John Powers

1 comment

Related details

Dibyajyoti Pal (Gerrit)

Dibyajyoti Pal voted and added 1 comment

Votes added by Dibyajyoti Pal

1 comment

Related details

Dibyajyoti Pal (Gerrit)

Dibyajyoti Pal added 1 comment

John Powers (Gerrit)

John Powers voted and added 1 comment

Votes added by John Powers

1 comment

Related details

Dibyajyoti Pal (Gerrit)

Dibyajyoti Pal voted and added 3 comments

Votes added by Dibyajyoti Pal

3 comments

Related details

John Powers (Gerrit)

John Powers added 1 comment

Related details

John Powers (Gerrit)

John Powers voted and added 1 comment

Votes added by John Powers

1 comment

Related details

Marijn Kruisselbrink (Gerrit)

Marijn Kruisselbrink added 1 comment

Related details

John Powers (Gerrit)

John Powers voted and added 1 comment

Votes added by John Powers

1 comment

Related details

Dibyajyoti Pal (Gerrit)

Dibyajyoti Pal voted Code-Review+1

Related details

Dibyajyoti Pal (Gerrit)

Dibyajyoti Pal added 1 comment

Dibyajyoti Pal (Gerrit)

Dibyajyoti Pal voted Code-Review+1

Related details