Stabilize LocationBarSteadyViewMediatorTest.DisableShareForOverlays [chromium/src : main]
0 views
Skip to first unread message
Sebastien S-G (Gerrit)
Apr 20, 2026, 2:39:23 PM (3 days ago) Apr 20
to Stepan Khapugin, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Stepan Khapugin
Sebastien S-G voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sebastien S-G
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sebastien S-G . resolved
Hi! I hit a flake on this a couple times recently in the CQ. Can you PTAL? Thanks!
Related details
Attention is currently required from:
- Stepan Khapugin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stepan Khapugin (Gerrit)
8:27 AM (10 hours ago) 8:27 AM
to Sebastien S-G, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sebastien S-G
Stepan Khapugin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Sebastien S-G
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sebastien S-G (Gerrit)
10:37 AM (8 hours ago) 10:37 AM
to Stepan Khapugin, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Sebastien S-G voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:13 AM (7 hours ago) 11:13 AM
to Sebastien S-G, Stepan Khapugin, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Stabilize LocationBarSteadyViewMediatorTest.DisableShareForOverlays
Refactor the test to use base::test::TestFuture instead of relying on
synchronous execution or RunUntilIdle(). This ensures the test waits for
the asynchronous overlay presentation signals before asserting on the
consumer state, avoiding flakiness.
- Added `onUpdateLocationShareable` property to
`FakeLocationBarSteadyViewConsumer` to allow tests to observe state
changes.
- Refactored `DisableShareForOverlays` to use `TestFuture` and
Objective-C blocks to wait for property updates.
Change-Id: I6b50b65916ad438ca7079a19621ee47190959297
Reviewed-by: Stepan Khapugin <stkha...@chromium.org>
Commit-Queue: Sebastien S-G <se...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1619529}
Files:
- M ios/chrome/browser/location_bar/ui_bundled/location_bar_steady_view_mediator_unittest.mm
- M ios/chrome/browser/location_bar/ui_bundled/test/fake_location_bar_steady_view_consumer.h
- M ios/chrome/browser/location_bar/ui_bundled/test/fake_location_bar_steady_view_consumer.mm
Change size: S
Delta: 3 files changed, 24 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Stepan Khapugin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages