[Media Router] Revamp internals dashboard and add chunked Perfetto tracing [chromium/src : main]
0 views
Skip to first unread message
Jordan Bayles (Gerrit)
Apr 1, 2026, 8:02:51 PM (24 hours ago) Apr 1
to Muyao Xu, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Mark Foltz and Muyao Xu
Jordan Bayles added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Jordan Bayles . resolved
This is somewhat ambitious but will hopefully make debugging significantly easier.
PTAL.
Related details
Attention is currently required from:
- Mark Foltz
- Muyao Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Foltz (Gerrit)
2:03 PM (5 hours ago) 2:03 PM
to Jordan Bayles, Muyao Xu, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Jordan Bayles and Muyao Xu
Mark Foltz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Jordan Bayles
- Muyao Xu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Muyao Xu (Gerrit)
2:52 PM (5 hours ago) 2:52 PM
to Jordan Bayles, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, jasonrobe...@google.com, jophba...@chromium.org, jshin...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Jordan Bayles
Muyao Xu voted and added 5 comments![]( "Open in Gerrit")
Votes added by Muyao Xu
| Code-Review | +1 |
5 comments
Patchset-level comments
Muyao Xu . resolved
Overall LGTM. The new UI looks amazing!!
File chrome/browser/resources/media_router/internals/media_router_internals.html
Line 25, Patchset 7 (Latest):
<div slot="tab">Mirroring Stats</div>Muyao Xu . unresolved
maybe consolidate mirroring stats with mirroring dashboard.
File chrome/browser/ui/webui/media_router/media_router_internals_webui_message_handler.cc
Line 251, Patchset 7 (Latest):
ResolveJavascriptCallback(callback_id, base::Value(std::string()));Muyao Xu . unresolved
should return boolean here
Line 263, Patchset 7 (Latest):
auto trace_reader =Muyao Xu . unresolved
trace_reader will not be deleted after tracing stops because the lambda function keeps a copy of it. maybe explicitly reset the stop callback once tracing stops.
Related details
Attention is currently required from:
- Jordan Bayles
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages