Check for null before dereferencing in HLS [chromium/src : main]

0 views
Skip to first unread message

Ted (Chromium) Meyer (Gerrit)

unread,
Jan 21, 2026, 8:57:13 PM (14 hours ago) Jan 21
to Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov

Ted (Chromium) Meyer voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eugene Zemtsov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibdc1b50ebedc4025e39ab3045d0d4b2766a0dcbc
Gerrit-Change-Number: 7508541
Gerrit-PatchSet: 1
Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Jan 2026 01:57:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eugene Zemtsov (Gerrit)

unread,
Jan 21, 2026, 9:02:42 PM (14 hours ago) Jan 21
to Ted (Chromium) Meyer, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer

Eugene Zemtsov voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ted (Chromium) Meyer
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibdc1b50ebedc4025e39ab3045d0d4b2766a0dcbc
    Gerrit-Change-Number: 7508541
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Comment-Date: Thu, 22 Jan 2026 02:02:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ted (Chromium) Meyer (Gerrit)

    unread,
    Jan 21, 2026, 9:41:45 PM (13 hours ago) Jan 21
    to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
    Attention needed from Eugene Zemtsov

    Ted (Chromium) Meyer voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eugene Zemtsov
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibdc1b50ebedc4025e39ab3045d0d4b2766a0dcbc
    Gerrit-Change-Number: 7508541
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Attention: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Comment-Date: Thu, 22 Jan 2026 02:41:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 21, 2026, 10:05:34 PM (12 hours ago) Jan 21
    to Ted (Chromium) Meyer, Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Check for null before dereferencing in HLS

    the `rendition_manager_` pointer can be null, and should be checked
    before use.
    Fixed: 474448736
    Change-Id: Ibdc1b50ebedc4025e39ab3045d0d4b2766a0dcbc
    Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
    Auto-Submit: Ted (Chromium) Meyer <tmath...@chromium.org>
    Commit-Queue: Ted (Chromium) Meyer <tmath...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1572721}
    Files:
    • M media/filters/hls_manifest_demuxer_engine.cc
    Change size: XS
    Delta: 1 file changed, 6 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Eugene Zemtsov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibdc1b50ebedc4025e39ab3045d0d4b2766a0dcbc
    Gerrit-Change-Number: 7508541
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ted (Chromium) Meyer <tmath...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
    Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages