Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>. Bugs of
the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-comment-migration
This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>.
Bugs of the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues. See
go/crbug-todo-migration for details.
#crbug-comment-migration
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
+Toni for the couple of ash files that need OWNERS
+John for chrome_web_ui_controller_factory.cc
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>.
Bugs of the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues. See
go/crbug-todo-migration for details.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Auto-Submit | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Auto-Submit | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
LGTM
// Chrome activities in separate processes. See http://crbug.com/40425941#c11.I don't think this fragment format works, but its probably ok. This shows up in several other files. Possibly a future migration or tool improvement?
// Workaround for https://crbug.com/40518724. The backup agent is sometimes being started in
// a
// child process, before the child process loads its native library. If backup then loads
// the native library the child process is left in a very confused state and crashes.Reflow.
// https://crbug.com/41364848. We can't call setWindowAndroid here because updating the
// window
// visibility here breaks exiting Reader Mode somehow.Reflow.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Auto-Submit | +1 |
// Chrome activities in separate processes. See http://crbug.com/40425941#c11.I don't think this fragment format works, but its probably ok. This shows up in several other files. Possibly a future migration or tool improvement?
Good catch. Makes sense as a followup so I created b/505362339. Should be #comment11 which is super easy to implement everywhere
// Workaround for https://crbug.com/40518724. The backup agent is sometimes being started in
// a
// child process, before the child process loads its native library. If backup then loads
// the native library the child process is left in a very confused state and crashes.Alison GaleReflow.
Odd that git cl format didn't work correctly here
// https://crbug.com/41364848. We can't call setWindowAndroid here because updating the
// window
// visibility here breaks exiting Reader Mode somehow.| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
+Ted for owners on SearchWidgetProvider.java
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>.
Bugs of the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-comment-migration
This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>.
Bugs of the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-comment-migration
This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/android/expectations/trichrome_chrome_64_32_bundle.proguard_flags.expected
Insertions: 3, Deletions: 3.
The diff is too large to show. Please review the diff.
```
Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>.
Bugs of the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
Bug: 504707641
Change-Id: Ic450d115a922b025843db5e033fc6e82ea1d42ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7782880
Commit-Queue: Alison Gale <ag...@chromium.org>
Reviewed-by: Ted Choc <ted...@chromium.org>
Auto-Submit: Alison Gale <ag...@chromium.org>
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1619017}
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>.
Bugs of the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues. See
go/crbug-todo-migration for details.
This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
NO_IFTTT=Just changing comments not code
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>.
Bugs of the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-comment-migration
This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
I sampled a few of the bug IDs and they were correct, but I didn't check every instance.
Bugs of the following forms will all be migrated to the new format:The first line (correctly) says that this CL migrates ids from the old bug db to the new one, but then the body of the CL gave me the impression that this is a format change CL (very few of the changes actually have a wrong format).
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Auto-Submit | +1 |
Bugs of the following forms will all be migrated to the new format:The first line (correctly) says that this CL migrates ids from the old bug db to the new one, but then the body of the CL gave me the impression that this is a format change CL (very few of the changes actually have a wrong format).
Updated the description to clarify that the list of bug formats are used for finding bugs but they are only updated if the bug ID is migrated.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
+Hidehiko for OWNERS on chrome/browser/ash/input_method/DEPS
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Auto-Submit | +1 |
Removed the file that needed extra owners
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Migrate comments referencing old crbug IDs to new issue tracker IDs
The canonical bug format is crbug.com/<id> or https://crbug.com/<id>.
Bugs of the following forms will all be migrated to the new format:
- crbug.com/<old id>
- https://crbug.com/<old id>
- crbug/<old id>
- crbug/monorail/<old id>
- issues.chromium.org/<old id>
- https://issues.chromium.org/<old id>
- https://issues.chromium.org/u/1/issues/<old id>
- bugs.chromium.org/<old id>
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
Bug: 504707641
Change-Id: I9b208d048275b5f1f4e3ac71cde8d6b1d9115d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7786610
Auto-Submit: Alison Gale <ag...@chromium.org>
Reviewed-by: Eshwar Stalin <est...@chromium.org>
Commit-Queue: Alison Gale <ag...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1619659}
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |