[bedrock] Migrate BrowserListObserver to BrowserCollectionObserver - part 5/n [chromium/src : main]

[Qikai Zhong (Gerrit)]

Attention needed from Tom Lukaszewicz and Zhentao Lu

Qikai Zhong added 2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Qikai Zhong . resolved

Hi, leave one comment.

File chrome/browser/ash/system_web_apps/apps/media_app/DEPS

Line 1, Patchset 6 (Latest):include_rules = [

Qikai Zhong . unresolved

It seems more appropriate to use
`chrome/browser/ash/system_web_apps/apps/DEPS`.
But I am not sure, @tl...@chromium.org please help take a look~

Open in Gerrit

Related details

Attention is currently required from:

• Tom Lukaszewicz
• Zhentao Lu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib8831321ae002c49dc77c407b2ad1cc9662dbf21

Gerrit-Change-Number: 7509785

Gerrit-PatchSet: 6

Gerrit-Owner: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Zhentao Lu <zhent...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Fri, 23 Jan 2026 08:53:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Tom Lukaszewicz (Gerrit)]

Attention needed from Zhentao Lu

Tom Lukaszewicz added 3 comments

File chrome/browser/ash/system_web_apps/apps/media_app/DEPS

Line 1, Patchset 6 (Latest):include_rules = [

Qikai Zhong . unresolved

It seems more appropriate to use
`chrome/browser/ash/system_web_apps/apps/DEPS`.
But I am not sure, @tl...@chromium.org please help take a look~

Tom Lukaszewicz

Agree with Qikai we should reuse `chrome/browser/ash/system_web_apps/apps/DEPS` for simplicity (if ChromeOS owners disagree we can change this again later).

File chrome/browser/ui/ash/desks/desks_client_browsertest.cc

Line 432, Patchset 6 (Latest): ~BrowsersAddedObserver() override { browser_collection_observation_.Reset(); }

Tom Lukaszewicz . unresolved

nit: Shouldn't be needed and we can make this `~BrowsersAddedObserver() override = default`

File chrome/browser/ui/ash/multi_user/multi_user_window_manager_browser_adaptor.cc

Line 87, Patchset 6 (Latest): browser_collection_observation_.Reset();

Tom Lukaszewicz . unresolved

nit: We should be able to drop this also

Open in Gerrit

Related details

Attention is currently required from:

• Zhentao Lu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib8831321ae002c49dc77c407b2ad1cc9662dbf21

Gerrit-Change-Number: 7509785

Gerrit-PatchSet: 6

Gerrit-Owner: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Zhentao Lu <zhent...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Comment-Date: Mon, 26 Jan 2026 17:53:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>

[Zhentao Lu (Gerrit)]

Attention needed from Qikai Zhong and Tom Lukaszewicz

Zhentao Lu added 3 comments

File chrome/browser/ash/system_web_apps/apps/media_app/DEPS

Line 1, Patchset 6:include_rules = [

Qikai Zhong . resolved

It seems more appropriate to use
`chrome/browser/ash/system_web_apps/apps/DEPS`.
But I am not sure, @tl...@chromium.org please help take a look~

Tom Lukaszewicz

Agree with Qikai we should reuse `chrome/browser/ash/system_web_apps/apps/DEPS` for simplicity (if ChromeOS owners disagree we can change this again later).

Zhentao Lu

Done. I am only adding some specific including rules for the browser test. The DEPS is automatically reused here.

File chrome/browser/ui/ash/desks/desks_client_browsertest.cc

Line 432, Patchset 6: ~BrowsersAddedObserver() override { browser_collection_observation_.Reset(); }

Tom Lukaszewicz . resolved

nit: Shouldn't be needed and we can make this `~BrowsersAddedObserver() override = default`

Zhentao Lu

Done

File chrome/browser/ui/ash/multi_user/multi_user_window_manager_browser_adaptor.cc

Line 87, Patchset 6: browser_collection_observation_.Reset();

Tom Lukaszewicz . resolved

nit: We should be able to drop this also

Zhentao Lu

Done

Open in Gerrit

Related details

Attention is currently required from:

• Qikai Zhong
• Tom Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib8831321ae002c49dc77c407b2ad1cc9662dbf21

Gerrit-Change-Number: 7509785

Gerrit-PatchSet: 11

Gerrit-Owner: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Zhentao Lu <zhent...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Feb 2026 10:12:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>

Comment-In-Reply-To: Tom Lukaszewicz <tl...@chromium.org>

[Qikai Zhong (Gerrit)]

Attention needed from Tom Lukaszewicz and Zhentao Lu

Qikai Zhong voted and added 1 comment

Votes added by Qikai Zhong

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Qikai Zhong . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Tom Lukaszewicz
• Zhentao Lu

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib8831321ae002c49dc77c407b2ad1cc9662dbf21

Gerrit-Change-Number: 7509785

Gerrit-PatchSet: 11

Gerrit-Owner: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Zhentao Lu <zhent...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Feb 2026 10:16:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Tom Lukaszewicz (Gerrit)]

Attention needed from Hidehiko Abe and Zhentao Lu

Tom Lukaszewicz added 2 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Tom Lukaszewicz . resolved

Small comment but otherwise lgtm, hidehiko could you ptal?

File chrome/browser/ash/system_web_apps/apps/media_app/media_app_integration_browsertest.cc

Line 285, Patchset 11 (Latest):class BrowserWindowWaiter : public BrowserCollectionObserver {

Tom Lukaszewicz . unresolved

We can probably remove this class and just replace the only callsite in this file with `ui_test_utils::BrowserCreatedObserver().Wait()`. (avoids the need for BUILD / DEPS updates since this test already depends on ui_test_utils)

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe
• Zhentao Lu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib8831321ae002c49dc77c407b2ad1cc9662dbf21

Gerrit-Change-Number: 7509785

Gerrit-PatchSet: 11

Gerrit-Owner: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Zhentao Lu <zhent...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Wed, 11 Feb 2026 22:43:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Zhentao Lu (Gerrit)]

Attention needed from Hidehiko Abe, Qikai Zhong and Tom Lukaszewicz

Zhentao Lu added 1 comment

File chrome/browser/ash/system_web_apps/apps/media_app/media_app_integration_browsertest.cc

Line 285, Patchset 11:class BrowserWindowWaiter : public BrowserCollectionObserver {

Tom Lukaszewicz . resolved

We can probably remove this class and just replace the only callsite in this file with `ui_test_utils::BrowserCreatedObserver().Wait()`. (avoids the need for BUILD / DEPS updates since this test already depends on ui_test_utils)

Zhentao Lu

Done

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe
• Qikai Zhong
• Tom Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib8831321ae002c49dc77c407b2ad1cc9662dbf21

Gerrit-Change-Number: 7509785

Gerrit-PatchSet: 12

Gerrit-Owner: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Zhentao Lu <zhent...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Feb 2026 05:21:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Tom Lukaszewicz <tl...@chromium.org>

[Qikai Zhong (Gerrit)]

Attention needed from Hidehiko Abe, Tom Lukaszewicz and Zhentao Lu

Qikai Zhong voted and added 1 comment

Votes added by Qikai Zhong

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Qikai Zhong . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Hidehiko Abe
• Tom Lukaszewicz
• Zhentao Lu

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ib8831321ae002c49dc77c407b2ad1cc9662dbf21

Gerrit-Change-Number: 7509785

Gerrit-PatchSet: 12

Gerrit-Owner: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>

Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Reviewer: Zhentao Lu <zhent...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Zhentao Lu <zhent...@microsoft.com>

Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>

Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Feb 2026 05:41:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes